From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6866C433F5 for ; Thu, 20 Jan 2022 07:12:01 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0BAD817E6; Thu, 20 Jan 2022 08:11:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0BAD817E6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1642662720; bh=lh3e6vV0ucsbxWPl5G8Web/KQhxNpREIwURVXvqQlRQ=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=K8mEKxWQJGI7g4fqYfvUxiNWNFKjp+jH/bdImPrHlQC2CYAnpHcU2hJm9jHVE4SuG p+diijJ0VQjYIgMMUwnZJng1jmS7sIWfpr+E+wYhGxOJRwnduwXH9klIJvB8SylfAF ULc6OB2OMr+hfwDd1PbHLFEr7puArvCStW5X6MIc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7A5EDF805C5; Thu, 20 Jan 2022 08:03:52 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4EE66F801F7; Wed, 19 Jan 2022 11:35:53 +0100 (CET) Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0857CF80128 for ; Wed, 19 Jan 2022 11:35:48 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0857CF80128 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YzN3hIDi" Received: by mail-ed1-x52e.google.com with SMTP id j23so3948828edp.5 for ; Wed, 19 Jan 2022 02:35:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OSDFZdcVmsxc9n5bq5153WrX2NPdR5H36ptL4DF/Ld8=; b=YzN3hIDiV3bsIYsBRldtIUseIA+Xg7yiUwxhkQBN4CpuDkGRGuFL7tAwCFTPYxhsRL HPHBSnHmlPJjpHnwXFn3XLaO3n9wa1rhK6vn59VsHIzMFUB6Jaq/3jsmguiQSKRchg1F Rt8vJSiYrulpQPWwPqPi3M8d7DsPrMLpe1PuuNpPMpczmmAtVSklZu+pQaTuoZw/CFJz zmTnBvK6MUoD+sXbx5PZpdbapVrA4zutuPKb+I0hcI1WoSE1tZMwas+pgK6nHJrD6hKt eeU6QEdcKx7a9glyGv2v53ut+S9OpX/JqVokRLDZ4YgZwe4DtxLJ2DYjxyR/R4KjvJPB tM2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OSDFZdcVmsxc9n5bq5153WrX2NPdR5H36ptL4DF/Ld8=; b=MyKkCQ5lBFAo9+D4lcfDdeHaGxGNgHAZHmJUqKfvVRwrwLgvPvrTtbc+BNcBTzjFHc M2Xd8cngLbPvaDLUyxW+ILMbUzyIa9U6h3P9QFKmqUvIDaGewfqbyeVW59KM+qF/ltvs gH9sV8fAAbbb5yW0d45DUmCLupCq7bK7p0Clso+fYuDUVFtGMhpIHoCxiqv1D5PQ1ZUw oLGG0xgO1bB5+1Uc9E9x4TDrD6xcp2UvO1eMJ3QZUn1q5CLLcR0y10RzfNhs+zORCSN6 a9j+VX+h4p7krIsKfatpBpMMUgYcpy9D4ti8+izjLCrDgnqqbZEcEVKpe3Rt2ZRJZ4y6 OlmA== X-Gm-Message-State: AOAM533Xo8/botE8vxkuIxz3lG0pLzZ+qojZOOXrCNVCwvtC2zQnZ9Xc /wqC/cgSt6Ho17M9wrVag8A= X-Google-Smtp-Source: ABdhPJxftTapCLkxAI0MUlBNg1QEZq+09+lN2uAiNmyiN4LnLKb1WAquBvnPN+ndGN2eyHqbgIspAw== X-Received: by 2002:a05:6402:4310:: with SMTP id m16mr13576339edc.344.1642588546591; Wed, 19 Jan 2022 02:35:46 -0800 (PST) Received: from skbuf ([188.25.255.2]) by smtp.gmail.com with ESMTPSA id go41sm6349344ejc.200.2022.01.19.02.35.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jan 2022 02:35:46 -0800 (PST) Date: Wed, 19 Jan 2022 12:35:42 +0200 From: Vladimir Oltean To: Rob Herring Subject: Re: [PATCH] dt-bindings: Improve phandle-array schemas Message-ID: <20220119103542.el3yuqds6ihpkthn@skbuf> References: <20220119015038.2433585-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220119015038.2433585-1-robh@kernel.org> X-Mailman-Approved-At: Thu, 20 Jan 2022 08:03:35 +0100 Cc: Andrew Lunn , Ulf Hansson , Daniel Lezcano , Geert Uytterhoeven , Chun-Kuang Hu , Linus Walleij , linux-remoteproc@vger.kernel.org, alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Sebastian Reichel , linux-ide@vger.kernel.org, Thierry Reding , Laurent Pinchart , Pavel Machek , linux-phy@lists.infradead.org, netdev@vger.kernel.org, Jonathan Hunter , Lee Jones , linux-riscv@lists.infradead.org, linux-leds@vger.kernel.org, Daniel Thompson , Florian Fainelli , Herbert Xu , Krzysztof Kozlowski , Marc Zyngier , Damien Le Moal , "Rafael J. Wysocki" , iommu@lists.linux-foundation.org, Kishon Vijay Abraham I , Jakub Kicinski , Zhang Rui , linux-usb@vger.kernel.org, Vivien Didelot , Wolfgang Grandegger , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Kalle Valo , Sudeep Holla , linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, Greg Kroah-Hartman , Mark Brown , Marc Kleine-Budde , Thomas Gleixner , Mauro Carvalho Chehab , Mathieu Poirier , Stephen Boyd , Jingoo Han , Kevin Hilman , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Vinod Koul , Kieran Bingham , linux-crypto@vger.kernel.org, Philipp Zabel , Viresh Kumar , dmaengine@vger.kernel.org, Georgi Djakov , "David S. Miller" , Joerg Roedel X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Jan 18, 2022 at 07:50:38PM -0600, Rob Herring wrote: > The 'phandle-array' type is a bit ambiguous. It can be either just an > array of phandles or an array of phandles plus args. Many schemas for > phandle-array properties aren't clear in the schema which case applies > though the description usually describes it. > > The array of phandles case boils down to needing: > > items: > maxItems: 1 > > The phandle plus args cases should typically take this form: > > items: > - items: > - description: A phandle > - description: 1st arg cell > - description: 2nd arg cell > > With this change, some examples need updating so that the bracketing of > property values matches the schema. > --- (...) > diff --git a/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml > index 702df848a71d..c504feeec6db 100644 > --- a/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml > @@ -34,6 +34,8 @@ properties: > full routing information must be given, not just the one hop > routes to neighbouring switches > $ref: /schemas/types.yaml#/definitions/phandle-array > + items: > + maxItems: 1 > > ethernet: > description: For better or worse, the mainline cases of this property all take the form of: arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts link = <&switch1port9 &switch2port9>; link = <&switch1port10 &switch0port10>; arch/arm/boot/dts/vf610-zii-dev-rev-b.dts link = <&switch1port6 &switch2port9>; link = <&switch1port5 &switch0port5>; arch/arm/boot/dts/vf610-zii-scu4-aib.dts link = <&switch1port10 &switch3port10 &switch2port10>; link = <&switch3port10 &switch2port10>; link = <&switch1port9 &switch0port10>; So not really an array of phandles.