From: Dan Carpenter <dan.carpenter@oracle.com>
To: daniel.baluta@nxp.com
Cc: alsa-devel@alsa-project.org
Subject: [bug report] ASoC: SOF: compr: Add compress ops implementation
Date: Thu, 10 Feb 2022 11:34:44 +0300 [thread overview]
Message-ID: <20220210083444.GA17969@kili> (raw)
Hello Daniel Baluta,
This is a semi-automatic email about new static checker warnings.
The patch 6324cf901e14: "ASoC: SOF: compr: Add compress ops
implementation" from Jan 20, 2022, leads to the following Smatch
complaint:
sound/soc/sof/compress.c:54 snd_sof_compr_fragment_elapsed()
warn: variable dereferenced before check 'cstream' (see line 48)
sound/soc/sof/compress.c
47 {
48 struct snd_soc_pcm_runtime *rtd = cstream->private_data;
49 struct snd_compr_runtime *crtd = cstream->runtime;
^^^^^^^^^^^^^^^^
The patch adds a new dereference
50 struct snd_soc_component *component;
51 struct snd_compr_tstamp *tstamp;
52 struct snd_sof_pcm *spcm;
53
54 if (!cstream)
^^^^^^^^
The old code assumed "cstream" could be NULL
55 return;
56
regards,
dan carpenter
reply other threads:[~2022-02-10 8:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220210083444.GA17969@kili \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=daniel.baluta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).