From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94E0AC433F5 for ; Wed, 23 Feb 2022 12:49:37 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 78CD71A98; Wed, 23 Feb 2022 13:48:45 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 78CD71A98 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1645620575; bh=7U3dBXvnvJSXR66MUjtmjBPnFPs6h5fn1DN++jies5w=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=VW9VMxnkVcFRzuw9a5dNmsN5HUjDgdn3TEdwysa1oyVswR13AtSTUB9dFd3YrUgXO 3t+rycLjUQNYCkK7/c7RgLlnIuJ7M/a1hG3eXlNuqhZlKtO1pnAP9h6lVAGpmBxPll 0wElYI1rvQjBrnshx1apiuekc/fDHSCRSP6UbER0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 19E5BF800F5; Wed, 23 Feb 2022 13:48:45 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id ACF6CF80237; Wed, 23 Feb 2022 13:48:43 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 63F0FF800F5 for ; Wed, 23 Feb 2022 13:48:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 63F0FF800F5 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MDJeRhXW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645620518; x=1677156518; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7U3dBXvnvJSXR66MUjtmjBPnFPs6h5fn1DN++jies5w=; b=MDJeRhXWrdU39TjcPliUByUVoVbBQjPEcDuYH8R1pId+Te+IO3f6Io9r LktXcNEI5BdjLY+OLLjOYRZCNPuZAwgQeL8cR3oswH/Ol3BslBl8CexU2 tXsw4Ld2/lSAp2Ly/wc4wBgTQg3/8NrnBSFJ0KFydrYOblIyuEffZtg4P ylnmpDsVdwif4QWrOyHLisw1dtkuJDMs2zJrNitFw5U1Vz0zaLyyPBbe6 s7JV/Bv/bWPJovGt86krbr7Kc2fP2WxznYoF7TpGu2GgcR7gCCAUoH/oL I1GSgzx3BV7y4TRPJSGHR1MODfLld9WxoI9Q0cRQSS7Q0fwNwVYdQoisP Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10266"; a="232574784" X-IronPort-AV: E=Sophos;i="5.88,390,1635231600"; d="scan'208";a="232574784" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 04:48:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,390,1635231600"; d="scan'208";a="637409614" Received: from lkp-server01.sh.intel.com (HELO 788b1cd46f0d) ([10.239.97.150]) by fmsmga002.fm.intel.com with ESMTP; 23 Feb 2022 04:48:30 -0800 Received: from kbuild by 788b1cd46f0d with local (Exim 4.92) (envelope-from ) id 1nMr4I-0001Pq-3g; Wed, 23 Feb 2022 12:48:30 +0000 Date: Wed, 23 Feb 2022 20:48:10 +0800 From: kernel test robot To: Vijendar Mukunda , broonie@kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 1/9] ASoC: amd: vg: fix for pm resume callback sequence Message-ID: <202202232021.rBs2qLvB-lkp@intel.com> References: <20220223071959.13539-1-Vijendar.Mukunda@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220223071959.13539-1-Vijendar.Mukunda@amd.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Pierre-Louis Bossart , Sunil-kumar.Dommati@amd.com, kbuild-all@lists.01.org, wtli@nuvoton.com, open list , Takashi Iwai , Liam Girdwood , Vijendar Mukunda , Alexander.Deucher@amd.com, krisman@collabora.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Vijendar, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on broonie-sound/for-next] [also build test WARNING on v5.17-rc5 next-20220222] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Vijendar-Mukunda/ASoC-amd-vg-fix-for-pm-resume-callback-sequence/20220223-152636 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220223/202202232021.rBs2qLvB-lkp@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/43c5f728cf59371b29569d941fb2ef2bdc3a279d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Vijendar-Mukunda/ASoC-amd-vg-fix-for-pm-resume-callback-sequence/20220223-152636 git checkout 43c5f728cf59371b29569d941fb2ef2bdc3a279d # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash sound/soc/amd/vangogh/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): sound/soc/amd/vangogh/acp5x-pcm-dma.c: In function 'acp5x_pcm_resume': >> sound/soc/amd/vangogh/acp5x-pcm-dma.c:430:20: warning: variable 'frmt_val' set but not used [-Wunused-but-set-variable] 430 | u32 val, reg_val, frmt_val; | ^~~~~~~~ >> sound/soc/amd/vangogh/acp5x-pcm-dma.c:430:11: warning: variable 'reg_val' set but not used [-Wunused-but-set-variable] 430 | u32 val, reg_val, frmt_val; | ^~~~~~~ vim +/frmt_val +430 sound/soc/amd/vangogh/acp5x-pcm-dma.c 361414dc1f07b72 Vijendar Mukunda 2021-07-21 425 361414dc1f07b72 Vijendar Mukunda 2021-07-21 426 static int __maybe_unused acp5x_pcm_resume(struct device *dev) 361414dc1f07b72 Vijendar Mukunda 2021-07-21 427 { 361414dc1f07b72 Vijendar Mukunda 2021-07-21 428 struct i2s_dev_data *adata; 43c5f728cf59371 Vijendar Mukunda 2022-02-23 429 struct i2s_stream_instance *rtd; 361414dc1f07b72 Vijendar Mukunda 2021-07-21 @430 u32 val, reg_val, frmt_val; 361414dc1f07b72 Vijendar Mukunda 2021-07-21 431 361414dc1f07b72 Vijendar Mukunda 2021-07-21 432 reg_val = 0; 361414dc1f07b72 Vijendar Mukunda 2021-07-21 433 frmt_val = 0; 361414dc1f07b72 Vijendar Mukunda 2021-07-21 434 adata = dev_get_drvdata(dev); 361414dc1f07b72 Vijendar Mukunda 2021-07-21 435 361414dc1f07b72 Vijendar Mukunda 2021-07-21 436 if (adata->play_stream && adata->play_stream->runtime) { 43c5f728cf59371 Vijendar Mukunda 2022-02-23 437 rtd = adata->play_stream->runtime->private_data; 361414dc1f07b72 Vijendar Mukunda 2021-07-21 438 config_acp5x_dma(rtd, SNDRV_PCM_STREAM_PLAYBACK); 43c5f728cf59371 Vijendar Mukunda 2022-02-23 439 acp_writel((rtd->xfer_resolution << 3), rtd->acp5x_base + ACP_HSTDM_ITER); 43c5f728cf59371 Vijendar Mukunda 2022-02-23 440 if (adata->tdm_mode == TDM_ENABLE) { 43c5f728cf59371 Vijendar Mukunda 2022-02-23 441 acp_writel(adata->tdm_fmt, adata->acp5x_base + ACP_HSTDM_TXFRMT); 43c5f728cf59371 Vijendar Mukunda 2022-02-23 442 val = acp_readl(adata->acp5x_base + ACP_HSTDM_ITER); 43c5f728cf59371 Vijendar Mukunda 2022-02-23 443 acp_writel(val | 0x2, adata->acp5x_base + ACP_HSTDM_ITER); 43c5f728cf59371 Vijendar Mukunda 2022-02-23 444 } 43c5f728cf59371 Vijendar Mukunda 2022-02-23 445 } 43c5f728cf59371 Vijendar Mukunda 2022-02-23 446 if (adata->i2ssp_play_stream && adata->i2ssp_play_stream->runtime) { 43c5f728cf59371 Vijendar Mukunda 2022-02-23 447 rtd = adata->i2ssp_play_stream->runtime->private_data; 43c5f728cf59371 Vijendar Mukunda 2022-02-23 448 config_acp5x_dma(rtd, SNDRV_PCM_STREAM_PLAYBACK); 43c5f728cf59371 Vijendar Mukunda 2022-02-23 449 acp_writel((rtd->xfer_resolution << 3), rtd->acp5x_base + ACP_I2STDM_ITER); 43c5f728cf59371 Vijendar Mukunda 2022-02-23 450 if (adata->tdm_mode == TDM_ENABLE) { 43c5f728cf59371 Vijendar Mukunda 2022-02-23 451 acp_writel(adata->tdm_fmt, adata->acp5x_base + ACP_I2STDM_TXFRMT); 43c5f728cf59371 Vijendar Mukunda 2022-02-23 452 val = acp_readl(adata->acp5x_base + ACP_I2STDM_ITER); 43c5f728cf59371 Vijendar Mukunda 2022-02-23 453 acp_writel(val | 0x2, adata->acp5x_base + ACP_I2STDM_ITER); 361414dc1f07b72 Vijendar Mukunda 2021-07-21 454 } 361414dc1f07b72 Vijendar Mukunda 2021-07-21 455 } 361414dc1f07b72 Vijendar Mukunda 2021-07-21 456 361414dc1f07b72 Vijendar Mukunda 2021-07-21 457 if (adata->capture_stream && adata->capture_stream->runtime) { 43c5f728cf59371 Vijendar Mukunda 2022-02-23 458 rtd = adata->capture_stream->runtime->private_data; 361414dc1f07b72 Vijendar Mukunda 2021-07-21 459 config_acp5x_dma(rtd, SNDRV_PCM_STREAM_CAPTURE); 43c5f728cf59371 Vijendar Mukunda 2022-02-23 460 acp_writel((rtd->xfer_resolution << 3), rtd->acp5x_base + ACP_HSTDM_IRER); 43c5f728cf59371 Vijendar Mukunda 2022-02-23 461 if (adata->tdm_mode == TDM_ENABLE) { 43c5f728cf59371 Vijendar Mukunda 2022-02-23 462 acp_writel(adata->tdm_fmt, adata->acp5x_base + ACP_HSTDM_RXFRMT); 43c5f728cf59371 Vijendar Mukunda 2022-02-23 463 val = acp_readl(adata->acp5x_base + ACP_HSTDM_IRER); 43c5f728cf59371 Vijendar Mukunda 2022-02-23 464 acp_writel(val | 0x2, adata->acp5x_base + ACP_HSTDM_IRER); 361414dc1f07b72 Vijendar Mukunda 2021-07-21 465 } 361414dc1f07b72 Vijendar Mukunda 2021-07-21 466 } 43c5f728cf59371 Vijendar Mukunda 2022-02-23 467 if (adata->i2ssp_capture_stream && adata->i2ssp_capture_stream->runtime) { 43c5f728cf59371 Vijendar Mukunda 2022-02-23 468 rtd = adata->i2ssp_capture_stream->runtime->private_data; 43c5f728cf59371 Vijendar Mukunda 2022-02-23 469 config_acp5x_dma(rtd, SNDRV_PCM_STREAM_CAPTURE); 43c5f728cf59371 Vijendar Mukunda 2022-02-23 470 acp_writel((rtd->xfer_resolution << 3), rtd->acp5x_base + ACP_I2STDM_IRER); 361414dc1f07b72 Vijendar Mukunda 2021-07-21 471 if (adata->tdm_mode == TDM_ENABLE) { 43c5f728cf59371 Vijendar Mukunda 2022-02-23 472 acp_writel(adata->tdm_fmt, adata->acp5x_base + ACP_I2STDM_RXFRMT); 43c5f728cf59371 Vijendar Mukunda 2022-02-23 473 val = acp_readl(adata->acp5x_base + ACP_I2STDM_IRER); 43c5f728cf59371 Vijendar Mukunda 2022-02-23 474 acp_writel(val | 0x2, adata->acp5x_base + ACP_I2STDM_IRER); 43c5f728cf59371 Vijendar Mukunda 2022-02-23 475 } 361414dc1f07b72 Vijendar Mukunda 2021-07-21 476 } 361414dc1f07b72 Vijendar Mukunda 2021-07-21 477 acp_writel(1, adata->acp5x_base + ACP_EXTERNAL_INTR_ENB); 361414dc1f07b72 Vijendar Mukunda 2021-07-21 478 return 0; 361414dc1f07b72 Vijendar Mukunda 2021-07-21 479 } 361414dc1f07b72 Vijendar Mukunda 2021-07-21 480 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org