* [PATCH] slimbus: qcom: Fix IRQ check in qcom_slim_probe
@ 2022-01-14 6:18 Miaoqian Lin
2022-01-14 15:14 ` Pierre-Louis Bossart
0 siblings, 1 reply; 4+ messages in thread
From: Miaoqian Lin @ 2022-01-14 6:18 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Srinivas Kandagatla,
Greg Kroah-Hartman, Sagar Dharia, linux-arm-msm, alsa-devel,
linux-kernel
Cc: linmq006
platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:
int irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;
Fix the check of return value to catch errors correctly.
Fixes: ad7fcbc308b0 ("slimbus: qcom: Add Qualcomm Slimbus controller driver")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/slimbus/qcom-ctrl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c
index f04b961b96cd..ec58091fc948 100644
--- a/drivers/slimbus/qcom-ctrl.c
+++ b/drivers/slimbus/qcom-ctrl.c
@@ -510,9 +510,9 @@ static int qcom_slim_probe(struct platform_device *pdev)
}
ctrl->irq = platform_get_irq(pdev, 0);
- if (!ctrl->irq) {
+ if (ctrl->irq < 0) {
dev_err(&pdev->dev, "no slimbus IRQ\n");
- return -ENODEV;
+ return ctrl->irq;
}
sctrl = &ctrl->ctrl;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] slimbus: qcom: Fix IRQ check in qcom_slim_probe
2022-01-14 6:18 [PATCH] slimbus: qcom: Fix IRQ check in qcom_slim_probe Miaoqian Lin
@ 2022-01-14 15:14 ` Pierre-Louis Bossart
2022-03-01 6:14 ` [PATCH v2] " Miaoqian Lin
0 siblings, 1 reply; 4+ messages in thread
From: Pierre-Louis Bossart @ 2022-01-14 15:14 UTC (permalink / raw)
To: Miaoqian Lin, Andy Gross, Bjorn Andersson, Srinivas Kandagatla,
Greg Kroah-Hartman, Sagar Dharia, linux-arm-msm, alsa-devel,
linux-kernel
On 1/14/22 12:18 AM, Miaoqian Lin wrote:
> platform_get_irq() returns negative error number instead 0 on failure.
the 'instead of' wording is a bit misleading:
platform_get_irq() returns non-zero IRQ number on success, negative
error number on failure. Zero is not a valid return valid.
> And the doc of platform_get_irq() provides a usage example:
>
> int irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> return irq;
>
> Fix the check of return value to catch errors correctly.
>
> Fixes: ad7fcbc308b0 ("slimbus: qcom: Add Qualcomm Slimbus controller driver")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> drivers/slimbus/qcom-ctrl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c
> index f04b961b96cd..ec58091fc948 100644
> --- a/drivers/slimbus/qcom-ctrl.c
> +++ b/drivers/slimbus/qcom-ctrl.c
> @@ -510,9 +510,9 @@ static int qcom_slim_probe(struct platform_device *pdev)
> }
>
> ctrl->irq = platform_get_irq(pdev, 0);
> - if (!ctrl->irq) {
> + if (ctrl->irq < 0) {
> dev_err(&pdev->dev, "no slimbus IRQ\n");
> - return -ENODEV;
> + return ctrl->irq;
> }
>
> sctrl = &ctrl->ctrl;
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] slimbus: qcom: Fix IRQ check in qcom_slim_probe
2022-01-14 15:14 ` Pierre-Louis Bossart
@ 2022-03-01 6:14 ` Miaoqian Lin
2022-04-12 9:06 ` Srinivas Kandagatla
0 siblings, 1 reply; 4+ messages in thread
From: Miaoqian Lin @ 2022-03-01 6:14 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Srinivas Kandagatla,
Greg Kroah-Hartman, Sagar Dharia, linux-arm-msm, alsa-devel,
linux-kernel
Cc: linmq006
platform_get_irq() returns non-zero IRQ number on success,
negative error number on failure.
And the doc of platform_get_irq() provides a usage example:
int irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;
Fix the check of return value to catch errors correctly.
Fixes: ad7fcbc308b0 ("slimbus: qcom: Add Qualcomm Slimbus controller driver")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
changes in v2:
- use more precise expression in commit message.
---
drivers/slimbus/qcom-ctrl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c
index f04b961b96cd..ec58091fc948 100644
--- a/drivers/slimbus/qcom-ctrl.c
+++ b/drivers/slimbus/qcom-ctrl.c
@@ -510,9 +510,9 @@ static int qcom_slim_probe(struct platform_device *pdev)
}
ctrl->irq = platform_get_irq(pdev, 0);
- if (!ctrl->irq) {
+ if (ctrl->irq < 0) {
dev_err(&pdev->dev, "no slimbus IRQ\n");
- return -ENODEV;
+ return ctrl->irq;
}
sctrl = &ctrl->ctrl;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] slimbus: qcom: Fix IRQ check in qcom_slim_probe
2022-03-01 6:14 ` [PATCH v2] " Miaoqian Lin
@ 2022-04-12 9:06 ` Srinivas Kandagatla
0 siblings, 0 replies; 4+ messages in thread
From: Srinivas Kandagatla @ 2022-04-12 9:06 UTC (permalink / raw)
To: Miaoqian Lin, Andy Gross, Bjorn Andersson, Greg Kroah-Hartman,
Sagar Dharia, linux-arm-msm, alsa-devel, linux-kernel
On 01/03/2022 06:14, Miaoqian Lin wrote:
> platform_get_irq() returns non-zero IRQ number on success,
> negative error number on failure.
> And the doc of platform_get_irq() provides a usage example:
>
> int irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> return irq;
>
> Fix the check of return value to catch errors correctly.
>
> Fixes: ad7fcbc308b0 ("slimbus: qcom: Add Qualcomm Slimbus controller driver")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Applied thanks,
--srini
> ---
> changes in v2:
> - use more precise expression in commit message.
> ---
> drivers/slimbus/qcom-ctrl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c
> index f04b961b96cd..ec58091fc948 100644
> --- a/drivers/slimbus/qcom-ctrl.c
> +++ b/drivers/slimbus/qcom-ctrl.c
> @@ -510,9 +510,9 @@ static int qcom_slim_probe(struct platform_device *pdev)
> }
>
> ctrl->irq = platform_get_irq(pdev, 0);
> - if (!ctrl->irq) {
> + if (ctrl->irq < 0) {
> dev_err(&pdev->dev, "no slimbus IRQ\n");
> - return -ENODEV;
> + return ctrl->irq;
> }
>
> sctrl = &ctrl->ctrl;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-12 9:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-14 6:18 [PATCH] slimbus: qcom: Fix IRQ check in qcom_slim_probe Miaoqian Lin
2022-01-14 15:14 ` Pierre-Louis Bossart
2022-03-01 6:14 ` [PATCH v2] " Miaoqian Lin
2022-04-12 9:06 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).