From: Miles Chen <miles.chen@mediatek.com>
To: <trevor.wu@mediatek.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org, tiwai@suse.com,
tzungbi@google.com, miles.chen@mediatek.com, broonie@kernel.org,
linux-mediatek@lists.infradead.org, yc.hung@mediatek.com,
matthias.bgg@gmail.com, aaronyu@google.com,
linux-arm-kernel@lists.infradead.org,
angelogioacchino.delregno@collabora.com
Subject: Re: [PATCH v4 3/6] ASoC: dt-bindings: mediatek: mt8195: merge mt8195 machine yaml
Date: Thu, 24 Mar 2022 13:57:00 +0800 [thread overview]
Message-ID: <20220324055700.28736-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <20220324053851.27350-4-trevor.wu@mediatek.com>
> Because the same binding components can be shared by all codecs
> combinations, we only reserve one binding file for mt8195 machine driver
> and rename to a generic name.
>
> We use compatible string to separate different codec combination instead
> of creating a new binding file for new codec combination.
>
> Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
>---
...snip...
>diff --git a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8195-mt6359.yaml
>similarity index 87%
>rename from Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml
>rename to Documentation/devicetree/bindings/sound/mt8195-mt6359.yaml
>index 8f177e02ad35..04953f5b44a4 100644
>--- a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml
>+++ b/Documentation/devicetree/bindings/sound/mt8195-mt6359.yaml
>@@ -1,10 +1,10 @@
> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> %YAML 1.2
> ---
>-$id: http://devicetree.org/schemas/sound/mt8195-mt6359-rt1019-rt5682.yaml#
>+$id: http://devicetree.org/schemas/sound/mt8195-mt6359.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
>-title: Mediatek MT8195 with MT6359, RT1019 and RT5682 ASoC sound card driver
>+title: MediaTek MT8195 ASoC sound card driver
>
I also tested:
'make dt_binding_check DT_CHECKER_FLAGS=-m DT_SCHEMA_FILES=Documentation/devicetree/bindings/sound/mt8195-mt6359.yaml'
and it wotks fine.
Reviewed-by: Miles Chen <miles.chen@mediatek.com>
> maintainers:
> - Trevor Wu <trevor.wu@mediatek.com>
>@@ -14,7 +14,9 @@ description:
>
> properties:
> compatible:
>- const: mediatek,mt8195_mt6359_rt1019_rt5682
>+ enum:
>+ - mediatek,mt8195_mt6359_rt1019_rt5682
>+ - mediatek,mt8195_mt6359_rt1011_rt5682
>
> model:
> $ref: /schemas/types.yaml#/definitions/string
>--
>2.18.0
>
>
next prev parent reply other threads:[~2022-03-24 5:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 5:38 [PATCH v4 0/6] ASoC: mediatek: Add support for MT8195 sound card with max98390 and rt5682 Trevor Wu
2022-03-24 5:38 ` [PATCH v4 1/6] ASoC: mediatek: mt8195: revise mt8195-mt6359-rt1019-rt5682.c Trevor Wu
2022-03-24 16:11 ` AngeloGioacchino Del Regno
2022-03-24 5:38 ` [PATCH v4 2/6] ASoC: mediatek: mt8195: merge machine driver Trevor Wu
2022-03-24 7:45 ` Tzung-Bi Shih
2022-03-24 16:10 ` AngeloGioacchino Del Regno
2022-03-24 5:38 ` [PATCH v4 3/6] ASoC: dt-bindings: mediatek: mt8195: merge mt8195 machine yaml Trevor Wu
2022-03-24 5:57 ` Miles Chen [this message]
2022-03-29 23:26 ` Rob Herring
2022-03-24 5:38 ` [PATCH v4 4/6] ASoC: mediatek: mt8195: rename card controls Trevor Wu
2022-03-24 16:11 ` AngeloGioacchino Del Regno
2022-03-24 5:38 ` [PATCH v4 5/6] ASoC: mediatek: mt8195: add machine support for max98390 and rt5682 Trevor Wu
2022-03-24 7:45 ` Tzung-Bi Shih
2022-03-24 16:12 ` AngeloGioacchino Del Regno
2022-03-24 5:38 ` [PATCH v4 6/6] ASoC: dt-bindings: mediatek: mt8195: support mt8195-mt6359-max98390-rt5682 Trevor Wu
2022-03-29 23:26 ` Rob Herring
2022-04-05 9:31 ` [PATCH v4 0/6] ASoC: mediatek: Add support for MT8195 sound card with max98390 and rt5682 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220324055700.28736-1-miles.chen@mediatek.com \
--to=miles.chen@mediatek.com \
--cc=aaronyu@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=trevor.wu@mediatek.com \
--cc=tzungbi@google.com \
--cc=yc.hung@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox