From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Kai-Heng Feng <kai.heng.feng@canonical.com>,
tiwai@suse.com
Cc: alsa-devel@alsa-project.org, Kailang Yang <kailang@realtek.com>,
kbuild-all@lists.01.org, lkp@intel.com,
Lucas Tanure <tanureal@opensource.cirrus.com>,
Jeremy Szu <jeremy.szu@canonical.com>,
linux-kernel@vger.kernel.org,
Werner Sembach <wse@tuxedocomputers.com>,
Hui Wang <hui.wang@canonical.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Sami Loone <sami@loone.fi>, Cameron Berkenpas <cam@neo-zeon.de>
Subject: Re: [PATCH] ALSA: hda/realtek: Fix audio regression on Mi Notebook Pro 2020
Date: Tue, 29 Mar 2022 14:05:53 +0300 [thread overview]
Message-ID: <202203291807.UCLuP6Fi-lkp@intel.com> (raw)
In-Reply-To: <20220329001845.776776-1-kai.heng.feng@canonical.com>
Hi Kai-Heng,
url: https://github.com/intel-lab-lkp/linux/commits/Kai-Heng-Feng/ALSA-hda-realtek-Fix-audio-regression-on-Mi-Notebook-Pro-2020/20220329-082021
base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: xtensa-randconfig-m031-20220327 (https://download.01.org/0day-ci/archive/20220329/202203291807.UCLuP6Fi-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
sound/pci/hda/patch_realtek.c:3620 alc256_shutup() warn: was && intended here instead of ||?
vim +3620 sound/pci/hda/patch_realtek.c
4a219ef8f37071 Kailang Yang 2017-06-16 3595 static void alc256_shutup(struct hda_codec *codec)
4a219ef8f37071 Kailang Yang 2017-06-16 3596 {
4a219ef8f37071 Kailang Yang 2017-06-16 3597 struct alc_spec *spec = codec->spec;
35a39f98567d8d Takashi Iwai 2019-02-01 3598 hda_nid_t hp_pin = alc_get_hp_pin(spec);
4a219ef8f37071 Kailang Yang 2017-06-16 3599 bool hp_pin_sense;
4a219ef8f37071 Kailang Yang 2017-06-16 3600
6447c962bc47a5 Kailang Yang 2019-05-08 3601 if (!hp_pin)
6447c962bc47a5 Kailang Yang 2019-05-08 3602 hp_pin = 0x21;
4a219ef8f37071 Kailang Yang 2017-06-16 3603
4a219ef8f37071 Kailang Yang 2017-06-16 3604 hp_pin_sense = snd_hda_jack_detect(codec, hp_pin);
4a219ef8f37071 Kailang Yang 2017-06-16 3605
4a219ef8f37071 Kailang Yang 2017-06-16 3606 if (hp_pin_sense)
4a219ef8f37071 Kailang Yang 2017-06-16 3607 msleep(2);
4a219ef8f37071 Kailang Yang 2017-06-16 3608
4a219ef8f37071 Kailang Yang 2017-06-16 3609 snd_hda_codec_write(codec, hp_pin, 0,
4a219ef8f37071 Kailang Yang 2017-06-16 3610 AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE);
4a219ef8f37071 Kailang Yang 2017-06-16 3611
6447c962bc47a5 Kailang Yang 2019-05-08 3612 if (hp_pin_sense || spec->ultra_low_power)
4a219ef8f37071 Kailang Yang 2017-06-16 3613 msleep(85);
4a219ef8f37071 Kailang Yang 2017-06-16 3614
1c9609e3a8cf59 Takashi Iwai 2018-01-19 3615 /* 3k pull low control for Headset jack. */
1c9609e3a8cf59 Takashi Iwai 2018-01-19 3616 /* NOTE: call this before clearing the pin, otherwise codec stalls */
3f74249057827c Hui Wang 2020-09-14 3617 /* If disable 3k pulldown control for alc257, the Mic detection will not work correctly
3f74249057827c Hui Wang 2020-09-14 3618 * when booting with headset plugged. So skip setting it for the codec alc257
3f74249057827c Hui Wang 2020-09-14 3619 */
b86b7ea348ec9b Kai-Heng Feng 2022-03-29 @3620 if (codec->core.vendor_id != 0x10ec0236 ||
This should be && instead of ||
b86b7ea348ec9b Kai-Heng Feng 2022-03-29 3621 codec->core.vendor_id != 0x10ec0257)
1c9609e3a8cf59 Takashi Iwai 2018-01-19 3622 alc_update_coef_idx(codec, 0x46, 0, 3 << 12);
1c9609e3a8cf59 Takashi Iwai 2018-01-19 3623
c0ca5eced22215 Takashi Iwai 2019-02-20 3624 if (!spec->no_shutup_pins)
4a219ef8f37071 Kailang Yang 2017-06-16 3625 snd_hda_codec_write(codec, hp_pin, 0,
4a219ef8f37071 Kailang Yang 2017-06-16 3626 AC_VERB_SET_PIN_WIDGET_CONTROL, 0x0);
4a219ef8f37071 Kailang Yang 2017-06-16 3627
6447c962bc47a5 Kailang Yang 2019-05-08 3628 if (hp_pin_sense || spec->ultra_low_power)
4a219ef8f37071 Kailang Yang 2017-06-16 3629 msleep(100);
4a219ef8f37071 Kailang Yang 2017-06-16 3630
4a219ef8f37071 Kailang Yang 2017-06-16 3631 alc_auto_setup_eapd(codec, false);
c0ca5eced22215 Takashi Iwai 2019-02-20 3632 alc_shutup_pins(codec);
6447c962bc47a5 Kailang Yang 2019-05-08 3633 if (spec->ultra_low_power) {
6447c962bc47a5 Kailang Yang 2019-05-08 3634 msleep(50);
6447c962bc47a5 Kailang Yang 2019-05-08 3635 alc_update_coef_idx(codec, 0x03, 1<<1, 0);
6447c962bc47a5 Kailang Yang 2019-05-08 3636 alc_update_coef_idx(codec, 0x08, 7<<4, 7<<4);
6447c962bc47a5 Kailang Yang 2019-05-08 3637 alc_update_coef_idx(codec, 0x08, 3<<2, 0);
6447c962bc47a5 Kailang Yang 2019-05-08 3638 alc_update_coef_idx(codec, 0x3b, 1<<15, 1<<15);
6447c962bc47a5 Kailang Yang 2019-05-08 3639 alc_update_coef_idx(codec, 0x0e, 7<<6, 0);
6447c962bc47a5 Kailang Yang 2019-05-08 3640 msleep(30);
6447c962bc47a5 Kailang Yang 2019-05-08 3641 }
4a219ef8f37071 Kailang Yang 2017-06-16 3642 }
--
0-DAY CI Kernel Test Service
https://01.org/lkp
prev parent reply other threads:[~2022-03-29 11:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 0:18 [PATCH] ALSA: hda/realtek: Fix audio regression on Mi Notebook Pro 2020 Kai-Heng Feng
2022-03-29 4:39 ` kernel test robot
2022-03-29 11:05 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202203291807.UCLuP6Fi-lkp@intel.com \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=cam@neo-zeon.de \
--cc=hui.wang@canonical.com \
--cc=jeremy.szu@canonical.com \
--cc=kai.heng.feng@canonical.com \
--cc=kailang@realtek.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=sami@loone.fi \
--cc=tanureal@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox