From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20A41C433F5 for ; Thu, 28 Apr 2022 09:13:52 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 54A60164D; Thu, 28 Apr 2022 11:13:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 54A60164D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1651137230; bh=LPrMDs4NgTPMMVGO+pTv6eFH4YrmdsHlQ5ANGzrurrY=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=uiPJXfxiWBYLcsaMxHcsVLDlcFEu6xyiHubt3gux37HSShvKivY0GIN1yIOTokMmz YgOGcwDTAILEPIi2gVrW5a9NmI+6SwMnG/WbQ5H0AtCi40PUvb+ETBE/jaoPB7Wb9e 0Cojkx5b5KwmQVGWJd2+a42jgR2Cfo+yaOR1N5r4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id F1887F8014E; Thu, 28 Apr 2022 11:12:59 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id F161AF800F2; Thu, 28 Apr 2022 11:12:58 +0200 (CEST) Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C2BDDF800F2 for ; Thu, 28 Apr 2022 11:12:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C2BDDF800F2 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="enTIccuO" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23S85oPm014938; Thu, 28 Apr 2022 04:12:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=fhO5OWNs7ldbb0025j9mY6KX+Symbg/QpoLGDSOJ+uE=; b=enTIccuO6DnllbRS7rvvcVza73OAWwSHdlFrRddxjsHM8oHoiLCvVyF86O2c5uWo10tM setgC0y2gGV9AQ3RbFBqfB/ZGI2sAoJTzfwFMK6W0HFwsw0iGZGPDRmm93ciffyhh8AT p/bmFvcamhpZqtBZWmpOpUj+H0DsdWECX1OW0M2B7JKgcAmm9fHgSiaSJXTTah5SLCMB a6xaLBUkJGFqJAqVxpUW9krzeOW4T1LU6CgkuahSFmSlY/7NBspqAhgadCjEhIT7HAW+ otd/OawR1ZwBXYuiatGBpO663Mjdh0jZlg7dysV6QBW+6UVWaVeXq+v7OqOS8frYhwKC Ew== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3fprt61w5e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 28 Apr 2022 04:12:50 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 28 Apr 2022 10:12:48 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Thu, 28 Apr 2022 10:12:48 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 9276146C; Thu, 28 Apr 2022 09:12:48 +0000 (UTC) Date: Thu, 28 Apr 2022 09:12:48 +0000 From: Charles Keepax To: Vitaly Rodionov Subject: Re: [PATCH 20/26] ASoC: cs35l41: Add common cs35l41 enter hibernate function Message-ID: <20220428091248.GP38351@ediswmail.ad.cirrus.com> References: <20220427150720.9194-1-vitalyr@opensource.cirrus.com> <20220427150720.9194-21-vitalyr@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220427150720.9194-21-vitalyr@opensource.cirrus.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-GUID: GQdJADMGzk9gxOMYQuqQXSy4g2VGf6d1 X-Proofpoint-ORIG-GUID: GQdJADMGzk9gxOMYQuqQXSy4g2VGf6d1 X-Proofpoint-Spam-Reason: safe Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, Takashi Iwai , linux-kernel@vger.kernel.org, Stefan Binding , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Apr 27, 2022 at 04:07:14PM +0100, Vitaly Rodionov wrote: > From: Stefan Binding > > Since the CS35L41 HDA driver also support hibernation, it > makes sense to move code from the ASoC driver to enter > hibernation into common code. > > Since HDA must support laptops which do not support hibernation > due to lack of external boost GPIO it is necessary to > ensure the function returns an error when an unsupported > boost type is in use. > > Signed-off-by: Stefan Binding > Signed-off-by: Vitaly Rodionov > --- Acked-by: Charles Keepax Thanks, Charles