From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A60DC433F5 for ; Sat, 30 Apr 2022 18:44:40 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 97B261F7; Sat, 30 Apr 2022 20:43:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 97B261F7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1651344277; bh=oWYIihokUaJM/i9/QmGaXX3gl+K8rlFxtNay5clvk0I=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=h/RkhVVEENhrP0owGSDdwVq5ObklDTr2R9dx25upzt3uUcMBtdlWCPcxqwc0aG6y6 6JcvxtMJWr61Cf6nOJnbO4vOE8UafU9pc0lqosOr836CcpoORXfrlBVBtL7nbcRQXX ONyriYe7yq/Hl/qNQejOmlNn3NAJ08/xp9YV9+Eg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1A7E3F80128; Sat, 30 Apr 2022 20:43:47 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6A8D6F8012A; Sat, 30 Apr 2022 20:43:44 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3DD13F80121 for ; Sat, 30 Apr 2022 20:43:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3DD13F80121 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Fv/AL+qn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651344219; x=1682880219; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=oWYIihokUaJM/i9/QmGaXX3gl+K8rlFxtNay5clvk0I=; b=Fv/AL+qnrWTA9fQl/7slmpHqv/Ne3c545yKqTnApq8MZzQckLMTpKG4f lEMvIeqx/btP6BNehiooMjVCIoztoN13x5iL2uu48nuJHmDFZr/VSYdAj Ne2Jxpshr4JHdvqdXw4kEzwZUmhI3idhwkImnFrWwTHuh3ikUif+XS0Kk Lb6nD5RR803c4Kb5x4f+aST5LPLT3uxoem1kEvk8FXgrQZfAbdehpZXHt rrhFqcYk50jukFHsBuIg2MTfkHQGN5L0kCit+YpGsoLz9hkAXCLiwupnU vSXt5e/8omA6K11AZfVO4WFtK4prUunQd/vlQ5DE1rhaqeTq5+SKWME++ g==; X-IronPort-AV: E=McAfee;i="6400,9594,10333"; a="254327114" X-IronPort-AV: E=Sophos;i="5.91,188,1647327600"; d="scan'208";a="254327114" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2022 11:43:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,188,1647327600"; d="scan'208";a="732688331" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by orsmga005.jf.intel.com with ESMTP; 30 Apr 2022 11:43:30 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1nks41-0007VT-Fq; Sat, 30 Apr 2022 18:43:29 +0000 Date: Sun, 1 May 2022 02:42:58 +0800 From: kernel test robot To: Mauro Carvalho Chehab , Luis Chamberlain Subject: Re: [PATCH v3 2/2] ALSA: hda - identify when audio is provided by a video driver Message-ID: <202205010257.ZFhZYEG9-lkp@intel.com> References: <6b5f1e2cec0137d5aab089a7e7497972ff5addb1.1651326000.git.mchehab@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6b5f1e2cec0137d5aab089a7e7497972ff5addb1.1651326000.git.mchehab@kernel.org> Cc: alsa-devel@alsa-project.org, kbuild-all@lists.01.org, mauro.chehab@linux.intel.com, David Airlie , Greg KH , intel-gfx@lists.freedesktop.org, llvm@lists.linux.dev, Lucas De Marchi , Takashi Iwai , dri-devel@lists.freedesktop.org, Kai Vehmanen , linux-modules@vger.kernel.org, Daniel Vetter , Pierre-Louis Bossart , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Mauro, I love your patch! Yet something to improve: [auto build test ERROR on mcgrof/modules-next] [also build test ERROR on linus/master v5.18-rc4 next-20220429] [cannot apply to tiwai-sound/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Mauro-Carvalho-Chehab/Let-userspace-know-when-snd-hda-intel-needs-i915/20220430-214332 base: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git modules-next config: riscv-buildonly-randconfig-r003-20220428 (https://download.01.org/0day-ci/archive/20220501/202205010257.ZFhZYEG9-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 400775649969b9baf3bc2a510266e7912bb16ae9) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/32f6557b5cc77c3cc2fcf6e68f11d989e31c954d git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Mauro-Carvalho-Chehab/Let-userspace-know-when-snd-hda-intel-needs-i915/20220430-214332 git checkout 32f6557b5cc77c3cc2fcf6e68f11d989e31c954d # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash sound/hda/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> sound/hda/hdac_component.c:202:7: error: call to undeclared function '__try_module_get'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] if (!__try_module_get(acomp->ops->owner, dev->driver->owner)) { ^ sound/hda/hdac_component.c:202:7: note: did you mean 'try_module_get'? include/linux/module.h:759:20: note: 'try_module_get' declared here static inline bool try_module_get(struct module *module) ^ 1 error generated. vim +/__try_module_get +202 sound/hda/hdac_component.c 183 184 static int hdac_component_master_bind(struct device *dev) 185 { 186 struct drm_audio_component *acomp = hdac_get_acomp(dev); 187 int ret; 188 189 if (WARN_ON(!acomp)) 190 return -EINVAL; 191 192 ret = component_bind_all(dev, acomp); 193 if (ret < 0) 194 return ret; 195 196 if (WARN_ON(!(acomp->dev && acomp->ops))) { 197 ret = -EINVAL; 198 goto out_unbind; 199 } 200 201 /* pin the module to avoid dynamic unbinding, but only if given */ > 202 if (!__try_module_get(acomp->ops->owner, dev->driver->owner)) { 203 ret = -ENODEV; 204 goto out_unbind; 205 } 206 207 if (acomp->audio_ops && acomp->audio_ops->master_bind) { 208 ret = acomp->audio_ops->master_bind(dev, acomp); 209 if (ret < 0) 210 goto module_put; 211 } 212 213 complete_all(&acomp->master_bind_complete); 214 return 0; 215 216 module_put: 217 module_put(acomp->ops->owner); 218 out_unbind: 219 component_unbind_all(dev, acomp); 220 complete_all(&acomp->master_bind_complete); 221 222 return ret; 223 } 224 -- 0-DAY CI Kernel Test Service https://01.org/lkp