From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D8EAC433F5 for ; Mon, 30 May 2022 13:34:20 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 607701B4A; Mon, 30 May 2022 15:33:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 607701B4A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1653917658; bh=e4rQjDbcX7pYuLi/MagzF5WQm9G9+qVy7DrNZMANN00=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Mi62vheQ9XwRm6ZkPw7f+1dsfPScS4QDScwq0q/e5k1tt+bAciS6k1eyYvWjJwUUe yAN3iBrcIpZZZFAEyCe565CN6UO7o6s0PNRQr9BWKcV6gt4cqopnLc8mTOYB2N9WzH IQUwRo2O+OfwIutN7U4XV0bZmdWb2jBsBDAqpwx8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0A04AF801F5; Mon, 30 May 2022 15:33:28 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D365AF80240; Mon, 30 May 2022 15:33:26 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E533EF8019D for ; Mon, 30 May 2022 15:33:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E533EF8019D Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oRh/fMSr" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D774960DD5; Mon, 30 May 2022 13:33:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DAD8CC36AE3; Mon, 30 May 2022 13:33:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653917591; bh=e4rQjDbcX7pYuLi/MagzF5WQm9G9+qVy7DrNZMANN00=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oRh/fMSrchS7dnBG73vbAqG6hOOBSVgSaeOjQIqJPSC5mwcxtGUaQHs1usNvWDmHE VPPAkRIJd3sDy6tHzB2vCqaNPBS5HploltdQ793BmaCbtBMzbWtIclrUtvbnRiI57O +vSjDmVd9ihXoqTp3m/q7fr0TI+MWb7ouCTjb0eyboxAJhwAcyG7+KGXqKWlpxvZVs +ij9y+qmk1mqNgYzBgttxwtYF9J1kN7su6IS4JdPtmwwdU3yj61hrI4UcGcPuJiUQl pRQA2skljixfcjEBfBcI2z2i860KWYb0PJ+GCEKH04Mmk85w+hjeMHhOBvcWfTKsci dvz8t03cmHYcw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 5.17 036/135] ASoC: rsnd: care default case on rsnd_ssiu_busif_err_status_clear() Date: Mon, 30 May 2022 09:29:54 -0400 Message-Id: <20220530133133.1931716-36-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220530133133.1931716-1-sashal@kernel.org> References: <20220530133133.1931716-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Cc: Sasha Levin , alsa-devel@alsa-project.org, kernel test robot , Kuninori Morimoto , tiwai@suse.com, lgirdwood@gmail.com, Mark Brown , colin.king@intel.com, Dan Carpenter X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Kuninori Morimoto [ Upstream commit b1384d4c95088d01f4266237faabf165d3d605fc ] commit cfb7b8bf1e2d66 ("ASoC: rsnd: tidyup rsnd_ssiu_busif_err_status_clear()") merged duplicate code, but it didn't care about default case, and causes smatch warnings. smatch warnings: sound/soc/sh/rcar/ssiu.c:112 rsnd_ssiu_busif_err_status_clear() \ error: uninitialized symbol 'offset'. sound/soc/sh/rcar/ssiu.c:114 rsnd_ssiu_busif_err_status_clear() \ error: uninitialized symbol 'shift'. This patch cares it. Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Kuninori Morimoto Link: https://lore.kernel.org/r/87r15rgn6p.wl-kuninori.morimoto.gx@renesas.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/sh/rcar/ssiu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c index 0d8f97633dd2..138f95dd9f4a 100644 --- a/sound/soc/sh/rcar/ssiu.c +++ b/sound/soc/sh/rcar/ssiu.c @@ -102,6 +102,8 @@ bool rsnd_ssiu_busif_err_status_clear(struct rsnd_mod *mod) shift = 1; offset = 1; break; + default: + goto out; } for (i = 0; i < 4; i++) { @@ -120,7 +122,7 @@ bool rsnd_ssiu_busif_err_status_clear(struct rsnd_mod *mod) } rsnd_mod_write(mod, reg, val); } - +out: return error; } -- 2.35.1