From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Sasha Levin <sashal@kernel.org>,
alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
tiwai@suse.com, lgirdwood@gmail.com,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Mark Brown <broonie@kernel.org>
Subject: [PATCH AUTOSEL 5.18 20/47] ASoC: wm_adsp: Fix event generation for wm_adsp_fw_put()
Date: Mon, 13 Jun 2022 22:04:13 -0400 [thread overview]
Message-ID: <20220614020441.1098348-20-sashal@kernel.org> (raw)
In-Reply-To: <20220614020441.1098348-1-sashal@kernel.org>
From: Mark Brown <broonie@kernel.org>
[ Upstream commit 2abdf9f80019e8244d3806ed0e1c9f725e50b452 ]
Currently wm_adsp_fw_put() returns 0 rather than 1 when updating the value
of the control, meaning that no event is generated to userspace. Fix this
by setting the default return value to 1, the code already exits early with
a return value of 0 if the value is unchanged.
Signed-off-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20220603115003.3865834-1-broonie@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
sound/soc/codecs/wm_adsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
index e32c8ded181d..9cfd4f18493f 100644
--- a/sound/soc/codecs/wm_adsp.c
+++ b/sound/soc/codecs/wm_adsp.c
@@ -333,7 +333,7 @@ int wm_adsp_fw_put(struct snd_kcontrol *kcontrol,
struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol);
struct soc_enum *e = (struct soc_enum *)kcontrol->private_value;
struct wm_adsp *dsp = snd_soc_component_get_drvdata(component);
- int ret = 0;
+ int ret = 1;
if (ucontrol->value.enumerated.item[0] == dsp[e->shift_l].fw)
return 0;
--
2.35.1
next prev parent reply other threads:[~2022-06-14 2:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220614020441.1098348-1-sashal@kernel.org>
2022-06-14 2:03 ` [PATCH AUTOSEL 5.18 02/47] ASoC: nau8822: Add operation for internal PLL off and on Sasha Levin
2022-06-14 2:03 ` [PATCH AUTOSEL 5.18 03/47] ASoC: qcom: lpass-platform: Update VMA access permissions in mmap callback Sasha Levin
2022-06-14 2:04 ` [PATCH AUTOSEL 5.18 08/47] ASoC: Intel: cirrus-common: fix incorrect channel mapping Sasha Levin
2022-06-14 2:04 ` [PATCH AUTOSEL 5.18 09/47] ASoC: cs42l52: Fix TLV scales for mixer controls Sasha Levin
2022-06-14 2:04 ` [PATCH AUTOSEL 5.18 10/47] ASoC: cs35l36: Update digital volume TLV Sasha Levin
2022-06-14 2:04 ` [PATCH AUTOSEL 5.18 11/47] ASoC: cs53l30: Correct number of volume levels on SX controls Sasha Levin
2022-06-14 2:04 ` [PATCH AUTOSEL 5.18 12/47] ASoC: cs42l52: Correct TLV for Bypass Volume Sasha Levin
2022-06-14 2:04 ` [PATCH AUTOSEL 5.18 13/47] ASoC: cs42l56: Correct typo in minimum level for SX volume controls Sasha Levin
2022-06-14 2:04 ` [PATCH AUTOSEL 5.18 14/47] ASoC: cs42l51: Correct minimum value for SX volume control Sasha Levin
2022-06-14 2:04 ` [PATCH AUTOSEL 5.18 18/47] ASoC: wm8962: Fix suspend while playing music Sasha Levin
2022-06-14 2:04 ` [PATCH AUTOSEL 5.18 19/47] ASoC: es8328: Fix event generation for deemphasis control Sasha Levin
2022-06-14 2:04 ` Sasha Levin [this message]
2022-06-14 2:04 ` [PATCH AUTOSEL 5.18 21/47] ALSA: hda: MTL: add HD Audio PCI ID and HDMI codec vendor ID Sasha Levin
2022-06-14 2:04 ` [PATCH AUTOSEL 5.18 30/47] ALSA: hda/realtek - Add HW8326 support Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614020441.1098348-20-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rf@opensource.cirrus.com \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox