From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B1A0C433EF for ; Tue, 14 Jun 2022 02:14:36 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E3F1818CD; Tue, 14 Jun 2022 04:13:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E3F1818CD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1655172875; bh=XOI0c77YmpwmB73ozt+1WFSrwCF5nxhWw69Zwe/maM0=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WCWREEgSTYB0yh3RnDu2FhRIAQryymuMJTm0D5AGgPA/eKHixxxgyddtVaMK4rrRb 4hNY8crVzM2c5vCWz+7Bozo57wG3K9Fl4PLuEHR9rhfKNUhRF0z3Nf+G8+Bsq9xd40 QeNRRByYGstuSA5tV3Vmt70EugNWS5r8Wfn7juG4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3232FF805FA; Tue, 14 Jun 2022 04:07:43 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 61DEEF805FC; Tue, 14 Jun 2022 04:07:41 +0200 (CEST) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2DE44F805FA for ; Tue, 14 Jun 2022 04:07:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2DE44F805FA Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DQ93gpki" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BB2BCB80AC1; Tue, 14 Jun 2022 02:07:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7533DC3411B; Tue, 14 Jun 2022 02:07:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655172457; bh=XOI0c77YmpwmB73ozt+1WFSrwCF5nxhWw69Zwe/maM0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DQ93gpkiVrcHtXUSni+9xQIzG5cXHe8sL19I6/yJqlJEJaEDbyCl5pzKsbhgIjhR6 hFIxgDo414kUfH9FubO8JjYQ/tc4u8OeyWEPSkSse8MIcG7AUL6fYyI0wM7LnpTdIR Hip5WoTDle4BLGHgfg9M0Go9YPXowEOv+5EdjmLiBF5IUmX0EbAgqKSnKuaprb0vqF LAwI8FqwH+O2+MRzFyl5ELy85DXc5Kqn5Qu+KakO5yUOicQ7vN/3VANmuUi+5FEVTV 1/e2LTOwNQZnX5DiDeWz5TCLBkM381t6S07QMsHntI5eVozezfskTLOoVgM5kqfdN/ iPWUP55+/KikA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 17/41] ASoC: es8328: Fix event generation for deemphasis control Date: Mon, 13 Jun 2022 22:06:42 -0400 Message-Id: <20220614020707.1099487-17-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220614020707.1099487-1-sashal@kernel.org> References: <20220614020707.1099487-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Cc: Sasha Levin , alsa-devel@alsa-project.org, tiwai@suse.com, lgirdwood@gmail.com, Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Mark Brown [ Upstream commit 8259610c2ec01c5cbfb61882ae176aabacac9c19 ] Currently the put() method for the deemphasis control returns 0 when a new value is written to the control even if the value changed, meaning events are not generated. Fix this, skip the work of updating the value when it is unchanged and then return 1 after having done so. Signed-off-by: Mark Brown Link: https://lore.kernel.org/r/20220603123937.4013603-1-broonie@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/es8328.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/es8328.c b/sound/soc/codecs/es8328.c index 9632afc2d4d6..ca3b1c00fa78 100644 --- a/sound/soc/codecs/es8328.c +++ b/sound/soc/codecs/es8328.c @@ -161,13 +161,16 @@ static int es8328_put_deemph(struct snd_kcontrol *kcontrol, if (deemph > 1) return -EINVAL; + if (es8328->deemph == deemph) + return 0; + ret = es8328_set_deemph(component); if (ret < 0) return ret; es8328->deemph = deemph; - return 0; + return 1; } -- 2.35.1