From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D12CC43334 for ; Tue, 14 Jun 2022 02:23:20 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CEBC418F9; Tue, 14 Jun 2022 04:22:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CEBC418F9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1655173398; bh=ADtRrt3V39JZgtjHY/+41M5NR/geQPE2msmcwBrkHyw=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=EBxqlpO6I9FT+UwYggiSJSaFl87rOlRcRLSEo7MKvYuNiNShzGFVO+O7SKm6EA2Dw Mf5Z4ADqNRE17zoXwbIHnPED7Dw+OUEpCR8sOZomajuHNR000bN40NeNR3Ic7kaQT1 yK/GzdSOsXUQgiHLyiy+4urtQUdvwtU5+ztv7jaM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0BF93F806F1; Tue, 14 Jun 2022 04:10:18 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 331C6F806E7; Tue, 14 Jun 2022 04:10:15 +0200 (CEST) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 42FD3F805B3 for ; Tue, 14 Jun 2022 04:10:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 42FD3F805B3 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bQ3MiisL" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D8732B816B0; Tue, 14 Jun 2022 02:10:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93B60C34114; Tue, 14 Jun 2022 02:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655172606; bh=ADtRrt3V39JZgtjHY/+41M5NR/geQPE2msmcwBrkHyw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bQ3MiisL02JtVYTmf1pRhg1jXi7NIQJy85b7q1IKu6C9VsOZg7oKu8TZEbGrLYpea pOdWx0eNdfQW57e9MDcH7cMaeaL+Lb/l3V+suLG34cBusKnW+rg5FYDPDITi8QUq48 4iNlzW0g/UntDBoQYiBTFL952a/8tqen/LAZVyVX+hlG+vcRS0Fm6sikCE8uz529rN cMNS/3eMv8mp0iZTL13CLL1yzHeYSGj8agI5tOqltWm8+IFR867y8+XazodNhzfqxK DIOS0RF/SRq5H9NmK8aWl6AlAsPHOYk3gUiz262UwI9G9zR0r6/qouVMKLMohbQzNF dNTaVNI5rCipw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 09/18] ASoC: wm_adsp: Fix event generation for wm_adsp_fw_put() Date: Mon, 13 Jun 2022 22:09:32 -0400 Message-Id: <20220614020941.1100702-9-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220614020941.1100702-1-sashal@kernel.org> References: <20220614020941.1100702-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Cc: Sasha Levin , alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, tiwai@suse.com, lgirdwood@gmail.com, Richard Fitzgerald , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Mark Brown [ Upstream commit 2abdf9f80019e8244d3806ed0e1c9f725e50b452 ] Currently wm_adsp_fw_put() returns 0 rather than 1 when updating the value of the control, meaning that no event is generated to userspace. Fix this by setting the default return value to 1, the code already exits early with a return value of 0 if the value is unchanged. Signed-off-by: Mark Brown Reviewed-by: Richard Fitzgerald Link: https://lore.kernel.org/r/20220603115003.3865834-1-broonie@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/wm_adsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c index 02c557e1f779..c5b0b56d9c94 100644 --- a/sound/soc/codecs/wm_adsp.c +++ b/sound/soc/codecs/wm_adsp.c @@ -697,7 +697,7 @@ int wm_adsp_fw_put(struct snd_kcontrol *kcontrol, struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); struct soc_enum *e = (struct soc_enum *)kcontrol->private_value; struct wm_adsp *dsp = snd_soc_component_get_drvdata(component); - int ret = 0; + int ret = 1; if (ucontrol->value.enumerated.item[0] == dsp[e->shift_l].fw) return 0; -- 2.35.1