From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: "Cezary Rojewski" <cezary.rojewski@intel.com>,
"Bard Liao" <yung-chuan.liao@linux.intel.com>,
tiwai@suse.de, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>,
broonie@kernel.org,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
Subject: [PATCH 01/13] ASoC: SOF: Intel: hda-dsp: report error on power-up/down
Date: Thu, 16 Jun 2022 16:53:39 -0500 [thread overview]
Message-ID: <20220616215351.135643-2-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20220616215351.135643-1-pierre-louis.bossart@linux.intel.com>
dev_dbg() is not good-enough since the flow returns an error.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
---
sound/soc/sof/intel/hda-dsp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/sof/intel/hda-dsp.c b/sound/soc/sof/intel/hda-dsp.c
index 263ad455e283a..2afaee91b982a 100644
--- a/sound/soc/sof/intel/hda-dsp.c
+++ b/sound/soc/sof/intel/hda-dsp.c
@@ -743,7 +743,7 @@ int hda_dsp_resume(struct snd_sof_dev *sdev)
if (hlink->ref_count) {
ret = snd_hdac_ext_bus_link_power_up(hlink);
if (ret < 0) {
- dev_dbg(sdev->dev,
+ dev_err(sdev->dev,
"error %d in %s: failed to power up links",
ret, __func__);
return ret;
@@ -871,7 +871,7 @@ int hda_dsp_suspend(struct snd_sof_dev *sdev, u32 target_state)
/* no link can be powered in s0ix state */
ret = snd_hdac_ext_bus_link_power_down_all(bus);
if (ret < 0) {
- dev_dbg(sdev->dev,
+ dev_err(sdev->dev,
"error %d in %s: failed to power down links",
ret, __func__);
return ret;
--
2.34.1
next prev parent reply other threads:[~2022-06-16 21:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 21:53 [PATCH 00/13] ASoC: SOF/Intel: remove __func__ from dev_dbg() Pierre-Louis Bossart
2022-06-16 21:53 ` Pierre-Louis Bossart [this message]
2022-06-16 21:53 ` [PATCH 02/13] ASoC: SOF: Intel: hda-stream: report error on stream not opened Pierre-Louis Bossart
2022-06-16 21:53 ` [PATCH 03/13] ASoC: SOF: Intel: hda-dai: remove use of __func__ in dev_dbg Pierre-Louis Bossart
2022-06-16 21:53 ` [PATCH 04/13] ASoC: SOF: Intel: hda-stream: " Pierre-Louis Bossart
2022-06-16 21:53 ` [PATCH 05/13] ASoC: SOF: Intel: mtl: " Pierre-Louis Bossart
2022-06-16 21:53 ` [PATCH 06/13] ASoC: SOF: ipc3-dtrace: " Pierre-Louis Bossart
2022-06-16 21:53 ` [PATCH 07/13] ASoC: SOF: ipc3-loader: " Pierre-Louis Bossart
2022-06-16 21:53 ` [PATCH 08/13] ASoC: SOF: ipc3-topology: " Pierre-Louis Bossart
2022-06-16 21:53 ` [PATCH 09/13] ASoC: SOF: ipc4-topology " Pierre-Louis Bossart
2022-06-16 21:53 ` [PATCH 10/13] ASoC: SOF: sof-client: " Pierre-Louis Bossart
2022-06-16 21:53 ` [PATCH 11/13] ASoC: SOF: ipc4: " Pierre-Louis Bossart
2022-06-16 21:53 ` [PATCH 12/13] ASoC: Intel: boards: hda: " Pierre-Louis Bossart
2022-06-17 12:25 ` Cezary Rojewski
2022-06-16 21:53 ` [PATCH 13/13] ASoC: Intel: boards: sof_sdw: " Pierre-Louis Bossart
2022-06-17 16:29 ` [PATCH 00/13] ASoC: SOF/Intel: remove __func__ from dev_dbg() Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220616215351.135643-2-pierre-louis.bossart@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.de \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox