From: Cezary Rojewski <cezary.rojewski@intel.com>
To: alsa-devel@alsa-project.org, broonie@kernel.org
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
pierre-louis.bossart@linux.intel.com, tiwai@suse.com,
hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com
Subject: [PATCH v3 02/17] ASoC: Intel: hsw_rt5640: Reword prefixes of all driver members
Date: Mon, 20 Jun 2022 10:22:11 +0200 [thread overview]
Message-ID: <20220620082226.2489357-3-cezary.rojewski@intel.com> (raw)
In-Reply-To: <20220620082226.2489357-1-cezary.rojewski@intel.com>
Replace ambiguous 'haswell_rt5640_' prefixes in favour of 'card_',
'link_' and other similar strings to clearly state which object given
member implements behavior for.
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
---
sound/soc/intel/boards/hsw_rt5640.c | 46 ++++++++++++++---------------
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/sound/soc/intel/boards/hsw_rt5640.c b/sound/soc/intel/boards/hsw_rt5640.c
index aa61e101f793..b51ce8d0ca22 100644
--- a/sound/soc/intel/boards/hsw_rt5640.c
+++ b/sound/soc/intel/boards/hsw_rt5640.c
@@ -16,12 +16,12 @@
#include "../../codecs/rt5640.h"
/* Haswell ULT platforms have a Headphone and Mic jack */
-static const struct snd_soc_dapm_widget haswell_widgets[] = {
+static const struct snd_soc_dapm_widget card_widgets[] = {
SND_SOC_DAPM_HP("Headphones", NULL),
SND_SOC_DAPM_MIC("Mic", NULL),
};
-static const struct snd_soc_dapm_route haswell_rt5640_map[] = {
+static const struct snd_soc_dapm_route card_routes[] = {
{"Headphones", NULL, "HPOR"},
{"Headphones", NULL, "HPOL"},
@@ -32,7 +32,7 @@ static const struct snd_soc_dapm_route haswell_rt5640_map[] = {
{"AIF1 Playback", NULL, "SSP0 CODEC OUT"},
};
-static int haswell_ssp0_fixup(struct snd_soc_pcm_runtime *rtd,
+static int codec_link_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
struct snd_pcm_hw_params *params)
{
struct snd_interval *rate = hw_param_interval(params,
@@ -49,7 +49,7 @@ static int haswell_ssp0_fixup(struct snd_soc_pcm_runtime *rtd,
return 0;
}
-static int haswell_rt5640_hw_params(struct snd_pcm_substream *substream,
+static int codec_link_hw_params(struct snd_pcm_substream *substream,
struct snd_pcm_hw_params *params)
{
struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
@@ -70,8 +70,8 @@ static int haswell_rt5640_hw_params(struct snd_pcm_substream *substream,
return ret;
}
-static const struct snd_soc_ops haswell_rt5640_ops = {
- .hw_params = haswell_rt5640_hw_params,
+static const struct snd_soc_ops codec_link_ops = {
+ .hw_params = codec_link_hw_params,
};
SND_SOC_DAILINK_DEF(dummy,
@@ -98,7 +98,7 @@ SND_SOC_DAILINK_DEF(platform,
SND_SOC_DAILINK_DEF(ssp0_port,
DAILINK_COMP_ARRAY(COMP_CPU("ssp0-port")));
-static struct snd_soc_dai_link haswell_rt5640_dais[] = {
+static struct snd_soc_dai_link card_dai_links[] = {
/* Front End DAI links */
{
.name = "System",
@@ -147,8 +147,8 @@ static struct snd_soc_dai_link haswell_rt5640_dais[] = {
.dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
SND_SOC_DAIFMT_CBC_CFC,
.ignore_pmdown_time = 1,
- .be_hw_params_fixup = haswell_ssp0_fixup,
- .ops = &haswell_rt5640_ops,
+ .be_hw_params_fixup = codec_link_hw_params_fixup,
+ .ops = &codec_link_ops,
.dpcm_playback = 1,
.dpcm_capture = 1,
SND_SOC_DAILINK_REG(ssp0_port, codec, platform),
@@ -156,44 +156,44 @@ static struct snd_soc_dai_link haswell_rt5640_dais[] = {
};
/* audio machine driver for Haswell Lynxpoint DSP + RT5640 */
-static struct snd_soc_card haswell_rt5640 = {
+static struct snd_soc_card hsw_rt5640_card = {
.name = "haswell-rt5640",
.owner = THIS_MODULE,
- .dai_link = haswell_rt5640_dais,
- .num_links = ARRAY_SIZE(haswell_rt5640_dais),
- .dapm_widgets = haswell_widgets,
- .num_dapm_widgets = ARRAY_SIZE(haswell_widgets),
- .dapm_routes = haswell_rt5640_map,
- .num_dapm_routes = ARRAY_SIZE(haswell_rt5640_map),
+ .dai_link = card_dai_links,
+ .num_links = ARRAY_SIZE(card_dai_links),
+ .dapm_widgets = card_widgets,
+ .num_dapm_widgets = ARRAY_SIZE(card_widgets),
+ .dapm_routes = card_routes,
+ .num_dapm_routes = ARRAY_SIZE(card_routes),
.fully_routed = true,
};
-static int haswell_audio_probe(struct platform_device *pdev)
+static int hsw_rt5640_probe(struct platform_device *pdev)
{
struct snd_soc_acpi_mach *mach;
int ret;
- haswell_rt5640.dev = &pdev->dev;
+ hsw_rt5640_card.dev = &pdev->dev;
/* override platform name, if required */
mach = pdev->dev.platform_data;
- ret = snd_soc_fixup_dai_links_platform_name(&haswell_rt5640,
+ ret = snd_soc_fixup_dai_links_platform_name(&hsw_rt5640_card,
mach->mach_params.platform);
if (ret)
return ret;
- return devm_snd_soc_register_card(&pdev->dev, &haswell_rt5640);
+ return devm_snd_soc_register_card(&pdev->dev, &hsw_rt5640_card);
}
-static struct platform_driver haswell_audio = {
- .probe = haswell_audio_probe,
+static struct platform_driver hsw_rt5640_driver = {
+ .probe = hsw_rt5640_probe,
.driver = {
.name = "haswell-audio",
.pm = &snd_soc_pm_ops,
},
};
-module_platform_driver(haswell_audio)
+module_platform_driver(hsw_rt5640_driver)
/* Module information */
MODULE_AUTHOR("Liam Girdwood, Xingchao Wang");
--
2.25.1
next prev parent reply other threads:[~2022-06-20 8:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 8:22 [PATCH v3 00/17] ASoC: Intel: haswell and broadwell boards update Cezary Rojewski
2022-06-20 8:22 ` [PATCH v3 01/17] ASoC: Intel: Rename haswell source file to hsw_rt5640 Cezary Rojewski
2022-06-20 8:22 ` Cezary Rojewski [this message]
2022-06-20 8:22 ` [PATCH v3 03/17] ASoC: Intel: hsw_rt5640: Reword driver name Cezary Rojewski
2022-06-20 8:22 ` [PATCH v3 04/17] ASoC: Intel: hsw_rt5640: Update code indentation Cezary Rojewski
2022-06-20 8:22 ` [PATCH v3 05/17] ASoC: Intel: hsw_rt5640: Update file comments Cezary Rojewski
2022-06-20 8:22 ` [PATCH v3 06/17] ASoC: Intel: hsw_rt5640: Improve probe() function quality Cezary Rojewski
2022-06-20 8:22 ` [PATCH v3 07/17] ASoC: Intel: hsw_rt5640: Improve hw_params() debug-ability Cezary Rojewski
2022-06-20 8:22 ` [PATCH v3 08/17] ASoC: Intel: Rename broadwell source file to bdw_rt286 Cezary Rojewski
2022-06-20 8:22 ` [PATCH v3 09/17] ASoC: Intel: bdw_rt286: Reword prefixes of all driver members Cezary Rojewski
2022-06-20 8:22 ` [PATCH v3 10/17] ASoC: Intel: bdw_rt286: Reword driver name Cezary Rojewski
2022-06-20 8:22 ` [PATCH v3 11/17] ASoC: Intel: bdw_rt286: Update code indentation Cezary Rojewski
2022-06-20 8:22 ` [PATCH v3 12/17] ASoC: Intel: bdw_rt286: Update file comments Cezary Rojewski
2022-06-20 8:22 ` [PATCH v3 13/17] ASoC: Intel: bdw_rt286: Improve probe() function quality Cezary Rojewski
2022-06-20 8:22 ` [PATCH v3 14/17] ASoC: Intel: bdw_rt286: Improve hw_params() debug-ability Cezary Rojewski
2022-06-20 8:22 ` [PATCH v3 15/17] ASoC: Intel: bdw_rt286: Improve codec_init() quality Cezary Rojewski
2022-06-20 8:22 ` [PATCH v3 16/17] ASoC: Intel: bdw_rt286: Refactor jack handling Cezary Rojewski
2022-06-20 8:22 ` [PATCH v3 17/17] ASoC: Intel: bdw_rt286: Remove FE DAI ops Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220620082226.2489357-3-cezary.rojewski@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox