From: Cezary Rojewski <cezary.rojewski@intel.com>
To: alsa-devel@alsa-project.org, broonie@kernel.org
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
pierre-louis.bossart@linux.intel.com, tiwai@suse.com,
hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com
Subject: [PATCH v4 13/17] ASoC: Intel: bdw_rt286: Improve probe() function quality
Date: Mon, 20 Jun 2022 12:13:58 +0200 [thread overview]
Message-ID: <20220620101402.2684366-14-cezary.rojewski@intel.com> (raw)
In-Reply-To: <20220620101402.2684366-1-cezary.rojewski@intel.com>
Declare local 'dev' and make use of it plus dev_get_platdata() to
improve code readability. Relocate few relevant to the function macros
for the exact same read too.
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
---
sound/soc/intel/boards/bdw_rt286.c | 23 +++++++++++------------
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/sound/soc/intel/boards/bdw_rt286.c b/sound/soc/intel/boards/bdw_rt286.c
index 9d815c31e1f4..c5737f548bef 100644
--- a/sound/soc/intel/boards/bdw_rt286.c
+++ b/sound/soc/intel/boards/bdw_rt286.c
@@ -235,13 +235,6 @@ static int bdw_rt286_resume(struct snd_soc_card *card)
return 0;
}
-/* Use space before codec name to simplify card ID, and simplify driver name. */
-#define SOF_CARD_NAME "bdw rt286" /* card name will be 'sof-bdw rt286' */
-#define SOF_DRIVER_NAME "SOF"
-
-#define CARD_NAME "broadwell-rt286"
-#define DRIVER_NAME NULL /* card name will be used for driver name */
-
static struct snd_soc_card bdw_rt286_card = {
.owner = THIS_MODULE,
.dai_link = card_dai_links,
@@ -257,27 +250,33 @@ static struct snd_soc_card bdw_rt286_card = {
.resume_post = bdw_rt286_resume,
};
+/* Use space before codec name to simplify card ID, and simplify driver name. */
+#define SOF_CARD_NAME "bdw rt286" /* card name will be 'sof-bdw rt286' */
+#define SOF_DRIVER_NAME "SOF"
+
+#define CARD_NAME "broadwell-rt286"
+
static int bdw_rt286_probe(struct platform_device *pdev)
{
struct snd_soc_acpi_mach *mach;
+ struct device *dev = &pdev->dev;
int ret;
- bdw_rt286_card.dev = &pdev->dev;
- mach = pdev->dev.platform_data;
+ bdw_rt286_card.dev = dev;
+ mach = dev_get_platdata(dev);
ret = snd_soc_fixup_dai_links_platform_name(&bdw_rt286_card, mach->mach_params.platform);
if (ret)
return ret;
- if (snd_soc_acpi_sof_parent(&pdev->dev)) {
+ if (snd_soc_acpi_sof_parent(dev)) {
bdw_rt286_card.name = SOF_CARD_NAME;
bdw_rt286_card.driver_name = SOF_DRIVER_NAME;
} else {
bdw_rt286_card.name = CARD_NAME;
- bdw_rt286_card.driver_name = DRIVER_NAME;
}
- return devm_snd_soc_register_card(&pdev->dev, &bdw_rt286_card);
+ return devm_snd_soc_register_card(dev, &bdw_rt286_card);
}
static int bdw_rt286_remove(struct platform_device *pdev)
--
2.25.1
next prev parent reply other threads:[~2022-06-20 10:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 10:13 [PATCH v4 00/17] ASoC: Intel: haswell and broadwell boards update Cezary Rojewski
2022-06-20 10:13 ` [PATCH v4 01/17] ASoC: Intel: Rename haswell source file to hsw_rt5640 Cezary Rojewski
2022-06-20 10:13 ` [PATCH v4 02/17] ASoC: Intel: hsw_rt5640: Reword prefixes of all driver members Cezary Rojewski
2022-06-20 10:13 ` [PATCH v4 03/17] ASoC: Intel: hsw_rt5640: Reword driver name Cezary Rojewski
2022-06-20 10:13 ` [PATCH v4 04/17] ASoC: Intel: hsw_rt5640: Update code indentation Cezary Rojewski
2022-06-20 10:13 ` [PATCH v4 05/17] ASoC: Intel: hsw_rt5640: Update file comments Cezary Rojewski
2022-06-20 10:13 ` [PATCH v4 06/17] ASoC: Intel: hsw_rt5640: Improve probe() function quality Cezary Rojewski
2022-06-20 10:13 ` [PATCH v4 07/17] ASoC: Intel: hsw_rt5640: Improve hw_params() debug-ability Cezary Rojewski
2022-06-20 10:13 ` [PATCH v4 08/17] ASoC: Intel: Rename broadwell source file to bdw_rt286 Cezary Rojewski
2022-06-20 10:13 ` [PATCH v4 09/17] ASoC: Intel: bdw_rt286: Reword prefixes of all driver members Cezary Rojewski
2022-06-20 10:13 ` [PATCH v4 10/17] ASoC: Intel: bdw_rt286: Reword driver name Cezary Rojewski
2022-06-20 10:13 ` [PATCH v4 11/17] ASoC: Intel: bdw_rt286: Update code indentation Cezary Rojewski
2022-06-20 10:13 ` [PATCH v4 12/17] ASoC: Intel: bdw_rt286: Update file comments Cezary Rojewski
2022-06-20 10:13 ` Cezary Rojewski [this message]
2022-06-20 10:13 ` [PATCH v4 14/17] ASoC: Intel: bdw_rt286: Improve hw_params() debug-ability Cezary Rojewski
2022-06-20 10:14 ` [PATCH v4 15/17] ASoC: Intel: bdw_rt286: Improve codec_init() quality Cezary Rojewski
2022-06-20 10:14 ` [PATCH v4 16/17] ASoC: Intel: bdw_rt286: Refactor jack handling Cezary Rojewski
2022-06-20 10:14 ` [PATCH v4 17/17] ASoC: Intel: bdw_rt286: Remove FE DAI ops Cezary Rojewski
2022-06-21 16:36 ` [PATCH v4 00/17] ASoC: Intel: haswell and broadwell boards update Pierre-Louis Bossart
2022-06-21 17:47 ` Cezary Rojewski
2022-06-21 21:11 ` Pierre-Louis Bossart
2022-06-22 18:15 ` Cezary Rojewski
2022-06-22 18:55 ` Pierre-Louis Bossart
2022-06-23 8:16 ` Cezary Rojewski
2022-06-24 10:59 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220620101402.2684366-14-cezary.rojewski@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox