From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 314EBC43334 for ; Tue, 21 Jun 2022 00:53:30 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5E8CE2031; Tue, 21 Jun 2022 02:52:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5E8CE2031 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1655772808; bh=lKdhkZXkI4k6wa8+uQOzhJu5OvBIf64/xrTaRZ2FKzI=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=EST5ybuWrU+YkRJdOyKtrA0vwuIh9peSVJ/cjDUMWTaWuQ/IB6Zekz/SehGZOuTKr 7UYceTYydolw//DuEwwSQDaicgQYEiyD/Ix0oHOvBbwnQ8P32skSz/lVr4Ij9Nkaoc FbJaW/BtY0jw8Mjt4cbo397fIaYYxsbGwy0iPsik= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id DAE99F804D2; Tue, 21 Jun 2022 02:52:37 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B06FCF804D8; Tue, 21 Jun 2022 02:52:35 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 05B76F800CB for ; Tue, 21 Jun 2022 02:52:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 05B76F800CB Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Cj33T5G8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655772750; x=1687308750; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lKdhkZXkI4k6wa8+uQOzhJu5OvBIf64/xrTaRZ2FKzI=; b=Cj33T5G80/moMOV/JTOb9RbSzM1ve4uPOoFttdyaAJQURX3QCJftJqQr FADQxW8H/twmdWYfV1v7subZWuYPHvBSS4A6iGKYdTLD4D8zj6WLtu/4R ifAoYQ9tqkSf6/pVfYYSmRgOcqb+vUR7i9nwcOjN1RTd+Pa643/+Ktn9X G2pBmmoncceAZwQQW6kK9n4v8KV5W+Qpg6j9yjfggfGillAnO/nVaAUHO DnRxGSnArsGsPHEROKecmc4rz3r23Y+x2g7kBqIuMwcjBS+CekkN0XbRK CrWlFqbmsv3mFKBHzdojy+FcjsV8LPdgud7sra9Ni8e5OKw985n6q//A7 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10384"; a="366320235" X-IronPort-AV: E=Sophos;i="5.92,207,1650956400"; d="scan'208";a="366320235" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2022 17:52:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,207,1650956400"; d="scan'208";a="562150223" Received: from lkp-server01.sh.intel.com (HELO 60dabacc1df6) ([10.239.97.150]) by orsmga006.jf.intel.com with ESMTP; 20 Jun 2022 17:52:21 -0700 Received: from kbuild by 60dabacc1df6 with local (Exim 4.95) (envelope-from ) id 1o3S7x-000XZb-3D; Tue, 21 Jun 2022 00:52:21 +0000 Date: Tue, 21 Jun 2022 08:52:10 +0800 From: kernel test robot To: Vitaly Rodionov , Jaroslav Kysela , Takashi Iwai , Mark Brown Subject: Re: [PATCH v5 04/14] ALSA: hda: cs35l41: Add initial DSP support and firmware loading Message-ID: <202206210829.FlHFxgAO-lkp@intel.com> References: <20220620205432.3809-5-vitalyr@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220620205432.3809-5-vitalyr@opensource.cirrus.com> Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Vitaly Rodionov X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Vitaly, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tiwai-sound/for-next] [also build test WARNING on linus/master v5.19-rc2 next-20220617] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Vitaly-Rodionov/ALSA-hda-cirrus-Add-initial-DSP-support-and-firmware-loading/20220621-045835 base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220621/202206210829.FlHFxgAO-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/90a2fe69cdb8e417d88f54f2dc4f57e06041c112 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Vitaly-Rodionov/ALSA-hda-cirrus-Add-initial-DSP-support-and-firmware-loading/20220621-045835 git checkout 90a2fe69cdb8e417d88f54f2dc4f57e06041c112 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash sound/pci/hda/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from include/linux/device.h:15, from include/linux/platform_device.h:13, from include/sound/soc.h:14, from sound/pci/hda/hda_cs_dsp_ctl.c:10: sound/pci/hda/hda_cs_dsp_ctl.c: In function 'hda_cs_dsp_add_kcontrol': >> sound/pci/hda/hda_cs_dsp_ctl.c:101:43: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Wformat=] 101 | dev_err(cs_ctl->dsp->dev, "Control %s: length %ld exceeds maximum %d\n", ctl->name, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ^~~ include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt' 144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~ sound/pci/hda/hda_cs_dsp_ctl.c:101:17: note: in expansion of macro 'dev_err' 101 | dev_err(cs_ctl->dsp->dev, "Control %s: length %ld exceeds maximum %d\n", ctl->name, | ^~~~~~~ sound/pci/hda/hda_cs_dsp_ctl.c:101:65: note: format string is defined here 101 | dev_err(cs_ctl->dsp->dev, "Control %s: length %ld exceeds maximum %d\n", ctl->name, | ~~^ | | | long int | %d vim +101 sound/pci/hda/hda_cs_dsp_ctl.c 03621b0e3c3696 Stefan Binding 2022-06-20 92 03621b0e3c3696 Stefan Binding 2022-06-20 93 static int hda_cs_dsp_add_kcontrol(struct hda_cs_dsp_coeff_ctl *ctl) 03621b0e3c3696 Stefan Binding 2022-06-20 94 { 03621b0e3c3696 Stefan Binding 2022-06-20 95 struct cs_dsp_coeff_ctl *cs_ctl = ctl->cs_ctl; 03621b0e3c3696 Stefan Binding 2022-06-20 96 struct snd_kcontrol_new *kcontrol; 03621b0e3c3696 Stefan Binding 2022-06-20 97 struct snd_kcontrol *kctl; 03621b0e3c3696 Stefan Binding 2022-06-20 98 int ret = 0; 03621b0e3c3696 Stefan Binding 2022-06-20 99 03621b0e3c3696 Stefan Binding 2022-06-20 100 if (cs_ctl->len > ADSP_MAX_STD_CTRL_SIZE) { 03621b0e3c3696 Stefan Binding 2022-06-20 @101 dev_err(cs_ctl->dsp->dev, "Control %s: length %ld exceeds maximum %d\n", ctl->name, 03621b0e3c3696 Stefan Binding 2022-06-20 102 cs_ctl->len, ADSP_MAX_STD_CTRL_SIZE); 03621b0e3c3696 Stefan Binding 2022-06-20 103 return -EINVAL; 03621b0e3c3696 Stefan Binding 2022-06-20 104 } 03621b0e3c3696 Stefan Binding 2022-06-20 105 03621b0e3c3696 Stefan Binding 2022-06-20 106 kcontrol = kzalloc(sizeof(*kcontrol), GFP_KERNEL); 03621b0e3c3696 Stefan Binding 2022-06-20 107 if (!kcontrol) 03621b0e3c3696 Stefan Binding 2022-06-20 108 return -ENOMEM; 03621b0e3c3696 Stefan Binding 2022-06-20 109 03621b0e3c3696 Stefan Binding 2022-06-20 110 kcontrol->name = ctl->name; 03621b0e3c3696 Stefan Binding 2022-06-20 111 kcontrol->info = hda_cs_dsp_coeff_info; 03621b0e3c3696 Stefan Binding 2022-06-20 112 kcontrol->iface = SNDRV_CTL_ELEM_IFACE_MIXER; 03621b0e3c3696 Stefan Binding 2022-06-20 113 kcontrol->private_value = (unsigned long)ctl; 03621b0e3c3696 Stefan Binding 2022-06-20 114 kcontrol->access = wmfw_convert_flags(cs_ctl->flags); 03621b0e3c3696 Stefan Binding 2022-06-20 115 03621b0e3c3696 Stefan Binding 2022-06-20 116 kcontrol->get = hda_cs_dsp_coeff_get; 03621b0e3c3696 Stefan Binding 2022-06-20 117 kcontrol->put = hda_cs_dsp_coeff_put; 03621b0e3c3696 Stefan Binding 2022-06-20 118 03621b0e3c3696 Stefan Binding 2022-06-20 119 kctl = snd_ctl_new1(kcontrol, NULL); 03621b0e3c3696 Stefan Binding 2022-06-20 120 if (!kctl) { 03621b0e3c3696 Stefan Binding 2022-06-20 121 ret = -ENOMEM; 03621b0e3c3696 Stefan Binding 2022-06-20 122 goto err; 03621b0e3c3696 Stefan Binding 2022-06-20 123 } 03621b0e3c3696 Stefan Binding 2022-06-20 124 ctl->kctl = kctl; 03621b0e3c3696 Stefan Binding 2022-06-20 125 03621b0e3c3696 Stefan Binding 2022-06-20 126 ret = snd_ctl_add(ctl->card, kctl); 03621b0e3c3696 Stefan Binding 2022-06-20 127 if (ret) 03621b0e3c3696 Stefan Binding 2022-06-20 128 dev_err(cs_ctl->dsp->dev, "Failed to add KControl: %s - Ret: %d\n", kcontrol->name, 03621b0e3c3696 Stefan Binding 2022-06-20 129 ret); 03621b0e3c3696 Stefan Binding 2022-06-20 130 else 03621b0e3c3696 Stefan Binding 2022-06-20 131 dev_dbg(cs_ctl->dsp->dev, "Added KControl: %s\n", kcontrol->name); 03621b0e3c3696 Stefan Binding 2022-06-20 132 03621b0e3c3696 Stefan Binding 2022-06-20 133 err: 03621b0e3c3696 Stefan Binding 2022-06-20 134 kfree(kcontrol); 03621b0e3c3696 Stefan Binding 2022-06-20 135 03621b0e3c3696 Stefan Binding 2022-06-20 136 return ret; 03621b0e3c3696 Stefan Binding 2022-06-20 137 } 03621b0e3c3696 Stefan Binding 2022-06-20 138 -- 0-DAY CI Kernel Test Service https://01.org/lkp