From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DC32C433EF for ; Sat, 16 Jul 2022 17:03:41 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1421918D6; Sat, 16 Jul 2022 19:02:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1421918D6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657991019; bh=bx44fzVV/pU7FupcvnbdsoAX7+LJaPuk82I0A7w/avs=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=q4sI/Zr+vPADTKgGOjrgJxw4TY+1ZUYgtqWU1PjL/4bg0QmqsyS0m5MNokyZtZPRt 3L34T+B63IKMxkhRQDoxoYc2+6WeEPEr+ortjpwBXyM7UcVFAWZVAJ9qgcogvBBqiG PlUP1nLG4SYI/I6ge0m/VUN57MeMW2aIHNFlRDMg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9539DF8016B; Sat, 16 Jul 2022 19:02:48 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DB763F8023A; Sat, 16 Jul 2022 19:02:40 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0D1F1F800CB for ; Sat, 16 Jul 2022 19:02:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0D1F1F800CB Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SKTThaZM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657990955; x=1689526955; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=bx44fzVV/pU7FupcvnbdsoAX7+LJaPuk82I0A7w/avs=; b=SKTThaZMB3sYO4h5Q/l/JupB7yoGW06NwqjYlfypprbhu0YzARU7FHTS O9IHORikZSdc83tchKjmnY1wzsWFwdQNJJVvfCrSPVihO2+XfG7OROOrK dHvNR2JBB5/oD8i+lXgq3l7ZbnT+y7QQhmpLcu/Guj7NmPYlr1zJ3In25 zLolxJSDGLkjrdCFcol9FQguupHIontXpw4G0ZEeNxKcE2BserSTurDt4 p9FbrfMcXBycLMP7ffJ0NZkgbnjpS520Bd7XhXwljjLChgAOXSLH/pv29 UPMEAczGezm2l7NDc3OeZ81VOc/VYHwVscS24egYliImb31BlrPeZA91C Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10410"; a="269010304" X-IronPort-AV: E=Sophos;i="5.92,277,1650956400"; d="scan'208";a="269010304" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2022 10:02:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,277,1650956400"; d="scan'208";a="596798626" Received: from lkp-server02.sh.intel.com (HELO ff137eb26ff1) ([10.239.97.151]) by orsmga002.jf.intel.com with ESMTP; 16 Jul 2022 10:02:26 -0700 Received: from kbuild by ff137eb26ff1 with local (Exim 4.95) (envelope-from ) id 1oClBR-0001rD-TE; Sat, 16 Jul 2022 17:02:25 +0000 Date: Sun, 17 Jul 2022 01:02:08 +0800 From: kernel test robot To: Takashi Iwai , alsa-devel@alsa-project.org Subject: Re: [PATCH 2/5] ALSA: pcm: Drop async signal support Message-ID: <202207170009.xmmdeeBR-lkp@intel.com> References: <20220715102935.4695-3-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220715102935.4695-3-tiwai@suse.de> Cc: kbuild-all@lists.01.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Takashi, I love your patch! Perhaps something to improve: [auto build test WARNING on tiwai-sound/for-next] [also build test WARNING on linus/master v5.19-rc6 next-20220715] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Takashi-Iwai/ALSA-Drop-async-signal-support/20220716-211853 base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next config: i386-randconfig-a001 (https://download.01.org/0day-ci/archive/20220717/202207170009.xmmdeeBR-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/6705167eb6bf093c8a099fa16c0aeb5f3da0dfba git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Takashi-Iwai/ALSA-Drop-async-signal-support/20220716-211853 git checkout 6705167eb6bf093c8a099fa16c0aeb5f3da0dfba # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash sound/core/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): sound/core/pcm_lib.c: In function 'snd_pcm_period_elapsed_under_stream_lock': >> sound/core/pcm_lib.c:1810:33: warning: variable 'runtime' set but not used [-Wunused-but-set-variable] 1810 | struct snd_pcm_runtime *runtime; | ^~~~~~~ vim +/runtime +1810 sound/core/pcm_lib.c e88e8ae639a490 Takashi Iwai 2006-04-28 1780 ^1da177e4c3f41 Linus Torvalds 2005-04-16 1781 /** 47271b1b98c980 Takashi Sakamoto 2021-06-10 1782 * snd_pcm_period_elapsed_under_stream_lock() - update the status of runtime for the next period 47271b1b98c980 Takashi Sakamoto 2021-06-10 1783 * under acquired lock of PCM substream. 47271b1b98c980 Takashi Sakamoto 2021-06-10 1784 * @substream: the instance of pcm substream. 47271b1b98c980 Takashi Sakamoto 2021-06-10 1785 * 47271b1b98c980 Takashi Sakamoto 2021-06-10 1786 * This function is called when the batch of audio data frames as the same size as the period of 47271b1b98c980 Takashi Sakamoto 2021-06-10 1787 * buffer is already processed in audio data transmission. 47271b1b98c980 Takashi Sakamoto 2021-06-10 1788 * 47271b1b98c980 Takashi Sakamoto 2021-06-10 1789 * The call of function updates the status of runtime with the latest position of audio data 47271b1b98c980 Takashi Sakamoto 2021-06-10 1790 * transmission, checks overrun and underrun over buffer, awaken user processes from waiting for 47271b1b98c980 Takashi Sakamoto 2021-06-10 1791 * available audio data frames, sampling audio timestamp, and performs stop or drain the PCM 47271b1b98c980 Takashi Sakamoto 2021-06-10 1792 * substream according to configured threshold. 47271b1b98c980 Takashi Sakamoto 2021-06-10 1793 * 47271b1b98c980 Takashi Sakamoto 2021-06-10 1794 * The function is intended to use for the case that PCM driver operates audio data frames under 47271b1b98c980 Takashi Sakamoto 2021-06-10 1795 * acquired lock of PCM substream; e.g. in callback of any operation of &snd_pcm_ops in process 47271b1b98c980 Takashi Sakamoto 2021-06-10 1796 * context. In any interrupt context, it's preferrable to use ``snd_pcm_period_elapsed()`` instead 47271b1b98c980 Takashi Sakamoto 2021-06-10 1797 * since lock of PCM substream should be acquired in advance. ^1da177e4c3f41 Linus Torvalds 2005-04-16 1798 * 47271b1b98c980 Takashi Sakamoto 2021-06-10 1799 * Developer should pay enough attention that some callbacks in &snd_pcm_ops are done by the call of 47271b1b98c980 Takashi Sakamoto 2021-06-10 1800 * function: ^1da177e4c3f41 Linus Torvalds 2005-04-16 1801 * 47271b1b98c980 Takashi Sakamoto 2021-06-10 1802 * - .pointer - to retrieve current position of audio data transmission by frame count or XRUN state. 47271b1b98c980 Takashi Sakamoto 2021-06-10 1803 * - .trigger - with SNDRV_PCM_TRIGGER_STOP at XRUN or DRAINING state. 47271b1b98c980 Takashi Sakamoto 2021-06-10 1804 * - .get_time_info - to retrieve audio time stamp if needed. 47271b1b98c980 Takashi Sakamoto 2021-06-10 1805 * 47271b1b98c980 Takashi Sakamoto 2021-06-10 1806 * Even if more than one periods have elapsed since the last call, you have to call this only once. ^1da177e4c3f41 Linus Torvalds 2005-04-16 1807 */ 47271b1b98c980 Takashi Sakamoto 2021-06-10 1808 void snd_pcm_period_elapsed_under_stream_lock(struct snd_pcm_substream *substream) ^1da177e4c3f41 Linus Torvalds 2005-04-16 1809 { 877211f5e1b119 Takashi Iwai 2005-11-17 @1810 struct snd_pcm_runtime *runtime; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1811 f5cdc9d4003a2f paulhsia 2019-11-13 1812 if (PCM_RUNTIME_CHECK(substream)) 47271b1b98c980 Takashi Sakamoto 2021-06-10 1813 return; f5cdc9d4003a2f paulhsia 2019-11-13 1814 runtime = substream->runtime; f5cdc9d4003a2f paulhsia 2019-11-13 1815 ^1da177e4c3f41 Linus Torvalds 2005-04-16 1816 if (!snd_pcm_running(substream) || f240406babfe15 Jaroslav Kysela 2010-01-05 1817 snd_pcm_update_hw_ptr0(substream, 1) < 0) 6705167eb6bf09 Takashi Iwai 2022-07-15 1818 return; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1819 -- 0-DAY CI Kernel Test Service https://01.org/lkp