From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Xiaolei Wang <xiaolei.wang@windriver.com>
Cc: alsa-devel@alsa-project.org, steve@sk2.org,
geert+renesas@glider.be, patches@opensource.cirrus.com,
tiwai@suse.com, chi.minghao@zte.com.cn, lgirdwood@gmail.com,
broonie@kernel.org, aford173@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: wm8962: Add an event handler for TEMP_HP and TEMP_SPK
Date: Mon, 10 Oct 2022 14:57:26 +0000 [thread overview]
Message-ID: <20221010145726.GD92394@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20221010092014.2229246-1-xiaolei.wang@windriver.com>
On Mon, Oct 10, 2022 at 05:20:14PM +0800, Xiaolei Wang wrote:
> In wm8962 driver, the WM8962_ADDITIONAL_CONTROL_4 is used as a volatile
> register, but this register mixes a bunch of volatile status bits and a
> bunch of non-volatile control bits. The dapm widgets TEMP_HP and
> TEMP_SPK leverages the control bits in this register. After the wm8962
> probe, the regmap will bet set to cache only mode, then a read error
> like below would be triggered when trying to read the initial power
> state of the dapm widgets TEMP_HP and TEMP_SPK.
> wm8962 0-001a: ASoC: error at soc_component_read_no_lock
> on wm8962.0-001a: -16
>
> In order to fix this issue, we add event handler to actually power
> up/down these widgets. With this change, we also need to explicitly
> power off these widgets in the wm8962 probe since they are enabled
> by default.
>
> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2022-10-10 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 9:20 [PATCH] ASoC: wm8962: Add an event handler for TEMP_HP and TEMP_SPK Xiaolei Wang
2022-10-10 14:57 ` Charles Keepax [this message]
2022-10-11 17:45 ` Adam Ford
2022-10-13 14:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221010145726.GD92394@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=aford173@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=chi.minghao@zte.com.cn \
--cc=geert+renesas@glider.be \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=steve@sk2.org \
--cc=tiwai@suse.com \
--cc=xiaolei.wang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).