From: Xiaolong Huang <butterflyhuangxx@gmail.com>
To: perex@perex.cz, tiwai@suse.com
Cc: Xiaolong Huang <butterflyhuangxx@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ALSA: rawmidi: fix infoleak in snd_rawmidi_ioctl_status_compat64
Date: Wed, 23 Nov 2022 04:08:41 +0800 [thread overview]
Message-ID: <20221122200841.1026335-1-butterflyhuangxx@gmail.com> (raw)
The compat_status is declared off of the stack, so it needs to
be zeroed out before copied back to userspace to prevent any
unintentional data leakage.
Signed-off-by: Xiaolong Huang <butterflyhuangxx@gmail.com>
---
sound/core/rawmidi_compat.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/core/rawmidi_compat.c b/sound/core/rawmidi_compat.c
index 68a93443583c..6afa68165b17 100644
--- a/sound/core/rawmidi_compat.c
+++ b/sound/core/rawmidi_compat.c
@@ -80,6 +80,7 @@ static int snd_rawmidi_ioctl_status_compat64(struct snd_rawmidi_file *rfile,
if (err < 0)
return err;
+ memset(&compat_status, 0, sizeof(compat_status));
compat_status = (struct compat_snd_rawmidi_status64) {
.stream = status.stream,
.tstamp_sec = status.tstamp_sec,
base-commit: eb7081409f94a9a8608593d0fb63a1aa3d6f95d8
--
2.25.1
reply other threads:[~2022-11-22 20:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122200841.1026335-1-butterflyhuangxx@gmail.com \
--to=butterflyhuangxx@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).