From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80F68C433FE for ; Mon, 28 Nov 2022 17:44:49 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A9FC4171D; Mon, 28 Nov 2022 18:43:57 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A9FC4171D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1669657487; bh=UaURbPuHpQtA0YRB1oWG4r32xC1LDY9emPmigIFWxUI=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=QRYAwpE+p0vjsV2LVG+QRjt8oCW35MTDhM8lFgyVOhJDOKejLpd/p/O5xuIOFzFxU 4v5i5zGqVqXamZYOTJZsGqcnO96DEWLzvWo2UQGoJoIBpQYxJOJ4cWPjh+zkvpWS7W ibimi8qWcHsVref4poKhgMrcqI8sVcPCgZDRFc/I= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 576CCF8028B; Mon, 28 Nov 2022 18:43:31 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B7866F8028B; Mon, 28 Nov 2022 18:43:30 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D8A8AF8028B for ; Mon, 28 Nov 2022 18:43:22 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D8A8AF8028B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NnFAE8U/" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CE813B80E56; Mon, 28 Nov 2022 17:43:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8FEDC4347C; Mon, 28 Nov 2022 17:43:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669657400; bh=UaURbPuHpQtA0YRB1oWG4r32xC1LDY9emPmigIFWxUI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NnFAE8U//65EYUu9hyrlt2RTwnzs4YXW1KMkTTwlyNdtClkVGqShHm0ZHI4meiDtG dwrsTkI0RjjgWEObKCZu20mu9azJ0Lrub/aYdO6wzKZivXgdKU96xsxSgi9/oKnJ/N GttKfkJCa1FpcSbRYy5wNdJHEETRgu90lXM067uytFWuIV4A7cOP1upLMCNL/sG3Fb L691IKlAEY7Te+iDhqWG6tJxSslQXayvDGWdL+m1wbfsIoiqQjBMcy4Rx/SiyECkeJ I8LCfXIsnkYGWbXd/TUS4mjedh/JH598KQ/g9hJtbTpighHrfrIMIR3FakdtuvXwCC jZQiR46Zbhu1A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 7/9] ASoC: soc-pcm: Add NULL check in BE reparenting Date: Mon, 28 Nov 2022 12:43:00 -0500 Message-Id: <20221128174303.1443008-7-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221128174303.1443008-1-sashal@kernel.org> References: <20221128174303.1443008-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Cc: Sasha Levin , alsa-devel@alsa-project.org, lgirdwood@gmail.com, tiwai@suse.com, Mark Brown , Srinivasa Rao Mandadapu X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Srinivasa Rao Mandadapu [ Upstream commit db8f91d424fe0ea6db337aca8bc05908bbce1498 ] Add NULL check in dpcm_be_reparent API, to handle kernel NULL pointer dereference error. The issue occurred in fuzzing test. Signed-off-by: Srinivasa Rao Mandadapu Link: https://lore.kernel.org/r/1669098673-29703-1-git-send-email-quic_srivasam@quicinc.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/soc-pcm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index e995e96ab903..3a9c875534c1 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -1168,6 +1168,8 @@ static void dpcm_be_reparent(struct snd_soc_pcm_runtime *fe, return; be_substream = snd_soc_dpcm_get_substream(be, stream); + if (!be_substream) + return; list_for_each_entry(dpcm, &be->dpcm[stream].fe_clients, list_fe) { if (dpcm->fe == fe) -- 2.35.1