From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A816C54EAA for ; Tue, 24 Jan 2023 14:16:27 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5A369A4F; Tue, 24 Jan 2023 15:15:34 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5A369A4F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1674569784; bh=wncoAzyXG5qsMcp0PRhq+OyH4q+2zPPWC1JALwXFRUY=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=h6q8Np+OXuGza4f26cD6HhC6P3UEk5joU6o44uTDPTFFAsvJztAJSGJUwzF6rb7cn x8OLD2CSrzhL8r5GyWdpnan/ABn6TRcAVrxehiCvA9XB6N+UHo/DIHl1TLo166YdHb 5431hUYuWquuup12d2W/MfWbB+s2ggGw4L+dGjcU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 802DCF8025D; Tue, 24 Jan 2023 15:15:33 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 98E9AF800FB; Tue, 24 Jan 2023 15:15:30 +0100 (CET) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4C856F800FB for ; Tue, 24 Jan 2023 15:15:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4C856F800FB Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=l286gH4z Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 42D451BF207; Tue, 24 Jan 2023 14:15:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674569720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nIw7NLrNROmQKNYPnuHqk2CqEst9nY4HbXU+KKl/pwM=; b=l286gH4zaStuaORA777qpXwbAcZhj+YncUk7uAzqZWieWArt4tThJzZODVGh3YOrFbJHtU m8cKCADL7W5gTqH9C4sVG9v10R83cBxOoitdOMZmEMoIL3wjgzIRy0QYHkbhsJWb0M0q99 DSGZNYvWKavYM1d3HCPODu3BTzKd25pk8CS3NSrusau5hMrD7nXly7YbUmg2k2VKrKmcnT SSI1M6d7PAkbbHtw+r41Jpo+T68ejoqYgqa4ScFyV9VHcOP2NXTAOmbhMvzAeJyPxkVLqr xgz62FwAENgzCQVsiux7WoHiKL3FWptBkgnR5k1Toe7gRkcSgk14Mdyqzkmbsw== Date: Tue, 24 Jan 2023 15:15:14 +0100 From: Herve Codina To: Krzysztof Kozlowski Subject: Re: [PATCH v3 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Message-ID: <20230124151514.58d77765@bootlin.com> In-Reply-To: <81f80190-a05c-5d0d-11b2-a80573b86e1c@linaro.org> References: <20230113103759.327698-1-herve.codina@bootlin.com> <20230113103759.327698-6-herve.codina@bootlin.com> <316ddb81-8d13-71dd-3396-412e31cfb880@linaro.org> <20230124104232.183cc9ff@bootlin.com> <37a95380-ee68-5c3a-3b96-48cc8b525f19@linaro.org> <20230124122347.1a531d0f@bootlin.com> <81f80190-a05c-5d0d-11b2-a80573b86e1c@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Fabio Estevam , linux-kernel@vger.kernel.org, Thomas Petazzoni , Xiubo Li , Michael Ellerman , Takashi Iwai , Nicholas Piggin , Liam Girdwood , Rob Herring , Li Yang , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, Mark Brown , Christophe Leroy , Krzysztof Kozlowski , Shengjiu Wang , linux-arm-kernel@lists.infradead.org, Qiang Zhao Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 24 Jan 2023 13:24:48 +0100 Krzysztof Kozlowski wrote: > On 24/01/2023 12:23, Herve Codina wrote: > > On Tue, 24 Jan 2023 11:02:52 +0100 > > Krzysztof Kozlowski wrote: > > =20 > >> On 24/01/2023 10:42, Herve Codina wrote: =20 > >>> Hi Krzysztof, > >>> > >>> On Tue, 17 Jan 2023 12:31:09 +0100 > >>> Krzysztof Kozlowski wrote: > >>> =20 > >>>> On 13/01/2023 11:37, Herve Codina wrote: =20 > >>>>> Add support for the QMC (QUICC Multichannel Controller) > >>>>> available in some PowerQUICC SoC such as MPC885 or MPC866. > >>>>> > >>>>> Signed-off-by: Herve Codina > >>>>> --- > >>>>> .../bindings/soc/fsl/cpm_qe/fsl,qmc.yaml | 164 ++++++++++++++= ++++ > >>>>> 1 file changed, 164 insertions(+) > >>>>> create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_q= e/fsl,qmc.yaml > >>>>> > >>>>> diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,q= mc.yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml > >>>>> new file mode 100644 > >>>>> index 000000000000..3ec52f1635c8 > >>>>> --- /dev/null > >>>>> +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml > >>>>> @@ -0,0 +1,164 @@ > >>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>>>> +%YAML 1.2 > >>>>> +--- > >>>>> +$id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qmc.yaml# > >>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>>>> + > >>>>> +title: PowerQUICC CPM QUICC Multichannel Controller (QMC) > >>>>> + > >>>>> +maintainers: > >>>>> + - Herve Codina > >>>>> + > >>>>> +description: | > >>>>> + The QMC (QUICC Multichannel Controller) emulates up to 64 channe= ls within > >>>>> + one serial controller using the same TDM physical interface rout= ed from > >>>>> + TSA. > >>>>> + > >>>>> +properties: > >>>>> + compatible: > >>>>> + items: > >>>>> + - enum: > >>>>> + - fsl,mpc885-scc-qmc > >>>>> + - fsl,mpc866-scc-qmc > >>>>> + - const: fsl,cpm1-scc-qmc > >>>>> + > >>>>> + reg: > >>>>> + items: > >>>>> + - description: SCC (Serial communication controller) registe= r base > >>>>> + - description: SCC parameter ram base > >>>>> + - description: Dual port ram base > >>>>> + > >>>>> + reg-names: > >>>>> + items: > >>>>> + - const: scc_regs > >>>>> + - const: scc_pram > >>>>> + - const: dpram > >>>>> + > >>>>> + interrupts: > >>>>> + maxItems: 1 > >>>>> + description: SCC interrupt line in the CPM interrupt controller > >>>>> + > >>>>> + fsl,tsa: > >>>>> + $ref: /schemas/types.yaml#/definitions/phandle > >>>>> + description: phandle to the TSA > >>>>> + > >>>>> + fsl,tsa-cell-id: > >>>>> + $ref: /schemas/types.yaml#/definitions/uint32 > >>>>> + enum: [1, 2, 3] > >>>>> + description: | > >>>>> + TSA cell ID (dt-bindings/soc/fsl,tsa.h defines these values) > >>>>> + - 1: SCC2 > >>>>> + - 2: SCC3 > >>>>> + - 3: SCC4 =20 > >>>> > >>>> Is this used as argument to tsa? If so, this should be part of fsl,t= sa > >>>> property, just like we do for all syscon-like phandles. =20 > >>> > >>> Yes, indeed. > >>> I will move 'fsl,tsa' to 'fsl,tsa-cell' with 'fsl,tsa-cell' a phandle= /number > >>> pair (the phandle to TSA node and the TSA cell id to use) =20 > >> > >> Move to fsl,tsa, not from. =20 > >=20 > > Well, I plan to remove both fsl,tsa and fsl,tsa-cell-id and use this: > > fsl,tsa-cell: > > $ref: /schemas/types.yaml#/definitions/phandle-array > > items: > > - items: > > - description: phandle to TSA node > > - enum: [1, 2, 3] > > description: | > > TSA cell ID (dt-bindings/soc/fsl,tsa.h defines these valu= es) > > - 1: SCC2 > > - 2: SCC3 > > - 3: SCC4 > > description: > > Should be a phandle/number pair. The phandle to TSA node and the = TSA > > cell ID to use. > >=20 > > Is that what you were thinking about ? =20 >=20 > Yes, except again, so third time, why calling this "cell"? Move it to > fsl,tsa. >=20 Why calling this "cell" ? Just because we reference a "cell" using the TSA cell ID inside TSA and not the TSA itself. Maybe the problem is the term "cell" as it is not the DT definition of "cell" but the source/destination of the TSA routing. TSA can route data from/to some "serial controller". These serial controllers are : - SCC (Serial Communication Controller) - SMC (Serial Management Controller) - UCC (Unified Communication Controller) Only SCCs are handled here. Maybe the term "serial" makes more sense which will lead to fsl,tsa-serial =3D <&tsa, SCC4>; Best regards, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com