From: Rob Herring <robh@kernel.org>
To: Kiseok Jo <kiseok.jo@irondevice.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
application@irondevice.com
Subject: Re: [PATCH v4 2/2] Modified the schema binding and added the vendor prefixes.
Date: Mon, 30 Jan 2023 08:04:38 -0600 [thread overview]
Message-ID: <20230130140438.GA2329394-robh@kernel.org> (raw)
In-Reply-To: <20230126020156.3252-4-kiseok.jo@irondevice.com>
On Thu, Jan 26, 2023 at 02:01:56AM +0000, Kiseok Jo wrote:
> Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com>
> ---
> .../bindings/sound/irondevice,sma1303.yaml | 32 +++++++++++++++++++
> .../devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 2 files changed, 34 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml
This is now in linux-next and breaking the bindings checks:
make[1]: *** Deleting file 'Documentation/devicetree/bindings/sound/irondevice,sma1303.example.dts'
Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml:28:1: found a tab character where an indentation space is expected
make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/sound/irondevice,sma1303.example.dts] Error 1
./Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml:28:1: [error] syntax error: found character '\t' that cannot start any token (syntax)
./Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml:28:1: found a tab character where an indentation space is expected
/builds/robherring/linux-dt/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml: ignoring, error parsing file
Please send a fix. DT bindings also need to be sent to the
devicetree@vger.kernel.org list. IOW, use get_maintainers.pl.
> diff --git a/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml b/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml
> new file mode 100644
> index 000000000000..eb87374cc812
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml
> @@ -0,0 +1,32 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/irondevice,sma1303.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Iron Device SMA1303 Audio Amplifier
> +
> +maintainers:
> + - Kiseok Jo <kiseok.jo@irondevice.com>
> +
> +description:
> + SMA1303 digital class-D audio amplifier with an integrated boost converter.
> +
> +allOf:
> + - $ref: name-prefix.yaml#
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: true
false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
Why do you need this?
> + i2c_bus {
i2c {
> + sma1303_amp: sma1303@1e {
Drop unused labels. Node name should be 'amplifier@1e'.
> + compatible = "irondevice,sma1303";
> + reg = <0x1e>;
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 70ffb3780621..271ff119764a 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -635,6 +635,8 @@ patternProperties:
> description: Inverse Path
> "^iom,.*":
> description: Iomega Corporation
> + "^irondevice,.*":
> + description: Iron Device Corporation
> "^isee,.*":
> description: ISEE 2007 S.L.
> "^isil,.*":
> --
> 2.20.1
>
next prev parent reply other threads:[~2023-01-30 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 2:01 [PATCH v4 1/2] The Iron Device SMA1303 is a boosted Class-D audio amplifier Kiseok Jo
2023-01-26 2:01 ` [PATCH v4 2/2] Modified the schema binding and added the vendor prefixes Kiseok Jo
2023-01-30 14:04 ` Rob Herring [this message]
2023-01-28 17:18 ` [PATCH v4 1/2] The Iron Device SMA1303 is a boosted Class-D audio amplifier Mark Brown
2023-01-30 2:26 ` FW: " Ki-Seok Jo
2023-01-30 11:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230130140438.GA2329394-robh@kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=application@irondevice.com \
--cc=broonie@kernel.org \
--cc=kiseok.jo@irondevice.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox