From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Lucas Tanure <lucas.tanure@collabora.com>
Cc: David Rhodes <david.rhodes@cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH v2 1/5] ASoC: cs35l41: Only disable internal boost
Date: Wed, 8 Feb 2023 10:02:43 +0000 [thread overview]
Message-ID: <20230208100243.GD36097@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20230207162526.1024286-2-lucas.tanure@collabora.com>
On Tue, Feb 07, 2023 at 04:25:22PM +0000, Lucas Tanure wrote:
> In error situations, only the internal boost case
> should be disabled and re-enabled.
> Also, for other boost cases re-enabling the boost
> to the default internal boost config is incorrect.
>
> Fixes: 6450ef559056 ("ASoC: cs35l41: CS35L41 Boosted Smart Amplifier")
> Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
> ---
Would quite like David to review as well, but looks good to me.
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2023-02-08 10:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 16:25 [PATCH v2 0/5] Add CS35L41 shared boost feature Lucas Tanure
2023-02-07 16:25 ` [PATCH v2 1/5] ASoC: cs35l41: Only disable internal boost Lucas Tanure
2023-02-08 10:02 ` Charles Keepax [this message]
2023-02-07 16:25 ` [PATCH v2 2/5] ASoC: cs35l41: Refactor error release code Lucas Tanure
2023-02-08 10:03 ` Charles Keepax
2023-02-07 16:25 ` [PATCH v2 3/5] ALSA: cs35l41: Add shared boost feature Lucas Tanure
2023-02-08 10:09 ` Charles Keepax
2023-02-08 12:27 ` lucas.tanure
2023-02-07 16:25 ` [PATCH v2 4/5] ASoC: cs35l41: Document CS35l41 external boost without VSPK Lucas Tanure
2023-02-07 16:48 ` Krzysztof Kozlowski
2023-02-07 16:25 ` [PATCH v2 5/5] ASoC: cs35l41: Document CS35l41 shared boost Lucas Tanure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208100243.GD36097@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.tanure@collabora.com \
--cc=patches@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox