From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53780C77B7D for ; Tue, 18 Apr 2023 16:27:35 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 422A5E84; Tue, 18 Apr 2023 18:26:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 422A5E84 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1681835253; bh=QZ4JzFP7rUGbI9Qp4WnBpRWdImLCng/fQeboSL5NIl0=; h=Date:From:To:Subject:References:In-Reply-To:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=A4GqJq1uCPleYTIgyoj5wfnWD3MW4LVlE8dxcB5Bb0co4EKs92oF6Z7RZR1rHzo1G fhDoptH5gSFmo/Lj0TW7l8nFIShXAWTEOdv5Jo+kTaIRue7p1tIZTtJ6rQo1wh1nfM JDwirF8RDbS3KhjI6Tg4vzGRTCRscUlPnSjhdyV8= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 01A1DF80155; Tue, 18 Apr 2023 18:26:18 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6FAC1F80155; Tue, 18 Apr 2023 18:26:15 +0200 (CEST) Received: from mail-oo1-f47.google.com (mail-oo1-f47.google.com [209.85.161.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EF073F800F8 for ; Tue, 18 Apr 2023 18:26:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EF073F800F8 Received: by mail-oo1-f47.google.com with SMTP id 006d021491bc7-541af0d27d8so304198eaf.3 for ; Tue, 18 Apr 2023 09:26:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681835159; x=1684427159; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GALPTZ5rs1mIduJF7Jl53u7XfsfluO0jc0nwk+zxYao=; b=l1JLFFl2+hq7OqTIhH5h7DHzvmDUe+fAOX8wZfgqtinJfk4W4sqqkHabW8njQu8H7x kPPcqa6lkAKg3Dou8My2UrjvKTfsMdXsxfZekIQ1iGDCukQvlsOYco2+CvylYRBjO33n T928kxQUePbwrSmtNFNbTx+FuojqzWBhrWmiivDsXgoHU+/rAUFRu22Xl1elUzuzEwZc iJlRHsSTYyZKzWUXd+//YsfwVX6LJEUU8WBKPW0S9bAFEHpE8YUxaXlH+fqRYnXt+Nd1 ORgBIkArajkgs4l+i4tILqPl3r8eZaDLwUUVEZor87nmqceaizNHQpulWEPe99623p2r h/Ng== X-Gm-Message-State: AAQBX9e0fnhvAphtb/LSHmwbh40SgQbwK7NCXkOGeaxaocu5eXCKn4h1 weUWHQayrJXxS63GrhLinA== X-Google-Smtp-Source: AKy350aqiwGvkm3PEtoK/oiOYt0ohBeRtozgRcDrXi5U4KbApLSinkvRa0UgAiJEnhzYkN4LUDI3oQ== X-Received: by 2002:a05:6871:149:b0:169:dcba:1ec9 with SMTP id z9-20020a056871014900b00169dcba1ec9mr1623622oab.41.1681835158903; Tue, 18 Apr 2023 09:25:58 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id r204-20020a4a37d5000000b00541fbbbcd31sm1737771oor.5.2023.04.18.09.25.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 09:25:58 -0700 (PDT) Received: (nullmailer pid 1808654 invoked by uid 1000); Tue, 18 Apr 2023 16:25:57 -0000 Date: Tue, 18 Apr 2023 11:25:57 -0500 From: Rob Herring To: Jaroslav Kysela , Takashi Iwai Subject: Re: [PATCH] ALSA: Use of_property_read_bool() for boolean properties Message-ID: <20230418162557.GD1764573-robh@kernel.org> References: <20230310144734.1546587-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230310144734.1546587-1-robh@kernel.org> Message-ID-Hash: 3XP7WFSENMOD2KHHKCZ4XY5E2FNHYOMU X-Message-ID-Hash: 3XP7WFSENMOD2KHHKCZ4XY5E2FNHYOMU X-MailFrom: robherring2@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, Mar 10, 2023 at 08:47:33AM -0600, Rob Herring wrote: > It is preferred to use typed property access functions (i.e. > of_property_read_ functions) rather than low-level > of_get_property/of_find_property functions for reading properties. > Convert reading boolean properties to to of_property_read_bool(). > > Signed-off-by: Rob Herring > --- > sound/ppc/tumbler.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Ping! > > diff --git a/sound/ppc/tumbler.c b/sound/ppc/tumbler.c > index 6c882873b344..12f1e10db1c4 100644 > --- a/sound/ppc/tumbler.c > +++ b/sound/ppc/tumbler.c > @@ -1361,7 +1361,7 @@ int snd_pmac_tumbler_init(struct snd_pmac *chip) > > for_each_child_of_node(chip->node, np) { > if (of_node_name_eq(np, "sound")) { > - if (of_get_property(np, "has-anded-reset", NULL)) > + if (of_property_read_bool(np, "has-anded-reset")) > mix->anded_reset = 1; > if (of_property_present(np, "layout-id")) > mix->reset_on_sleep = 0; > -- > 2.39.2 >