From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7861C77B75 for ; Fri, 12 May 2023 13:45:30 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 01AAE1FA; Fri, 12 May 2023 15:44:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 01AAE1FA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1683899127; bh=Xqxbgh+Vub0UE9eyQphC4+CKNJTooJBc+p6679TMRlw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=oGJBqQ9RlNvzaj/PM+h+ykzviAUwrC7UqhN9aORLJ/pEjhvK2D+14WX35kFTmPTWo qxjquO+ce51B8rUgRLDhnT0J2I41noY0J9FW3tJKc31WnB8IUjkgEFpjP5B1j0Lp7+ fl34Srwz/wZR+RWtogsvx3B7j48hoy/haxIjTz9M= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 77A63F80542; Fri, 12 May 2023 15:44:36 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 33A1DF8052E; Fri, 12 May 2023 15:44:36 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E566DF8052E; Fri, 12 May 2023 15:44:30 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4D6CEF802E8 for ; Fri, 12 May 2023 15:44:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4D6CEF802E8 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.a=rsa-sha256 header.s=fm1 header.b=Ma07HyZ/; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm1 header.b=Bdu5TsTJ Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 58C605C02CC; Fri, 12 May 2023 09:44:20 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 12 May 2023 09:44:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1683899060; x= 1683985460; bh=qkFj2mVhoUMnv8Ir3jUAh/NYj5vyzTkP0+jLwf8Mh4Q=; b=M a07HyZ/Nb0GoAjn9/d6NJcOLBLFJoiKfFm3zDCXXcirNfWnVk0zVaSBPu0J1pg2y ZvLGFQIp8LygLEaKTctgC3xpiik25e769SZ0vsYwk1jomF2ii09B7cb3rGWz2xgf MRptWwo6d0gbRRTlOV46LbJU13I6dFGzf91z9tLIpbxLboqfheqHYBobkYs1rqGv d8OJjhwPVByrF9iTr38pEWtJ3IAXXW58KCgzpDjbRPhRV/eW6JLPUYTOMZXsrxsl KGW7Q6TrLAv93Rk06e3Rh0KcsJEmJpT4uzOwBMtyT53fqv70/HskI5QEvu5iwdOn eYbjzPfW71rsNX9fnrjBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1683899060; x=1683985460; bh=qkFj2mVhoUMnv 8Ir3jUAh/NYj5vyzTkP0+jLwf8Mh4Q=; b=Bdu5TsTJabJXzIL1PBPnVgZ49G2ew MrPFULoq91h821wUTDbY/A+APYZHivmEgDHovR+n03yTvoR0mJHRcBUqRuPJj7QD clbaNOK/ihBHUGjeoylm/W0y+xUIkqqF9sM1tIi9nhixTya0c+GQPSOjNPKWeX9G wd/4MgErX7McTyQQgryN3JILN9yDpFw2/hGfXcgzTZ576erw2LLvaAeKit6RMxHe sPhHDj82//n9GiDbfRJcmyL5s/rsxc5v5YWXQitlxryd2CsKTgs0/1surzLK8Fd5 9fCEYOjCxXkHsh96AKIhnsIE9HnseSDz9thQqjf4+/inC1wjBTtFmb5xA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeehtddgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepvfgrkhgr shhhihcuufgrkhgrmhhothhouceoohdqthgrkhgrshhhihesshgrkhgrmhhotggthhhird hjpheqnecuggftrfgrthhtvghrnhephefhhfettefgkedvieeuffevveeufedtlefhjeei ieetvdelfedtgfefuedukeeunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepohdqthgrkhgrshhhihesshgrkhgrmhhotggthhhirdhjph X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 12 May 2023 09:44:17 -0400 (EDT) Date: Fri, 12 May 2023 22:44:14 +0900 From: Takashi Sakamoto To: Takashi Iwai Cc: Dan Carpenter , Clemens Ladisch , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ALSA: firewire-digi00x: prevent potential use after free Message-ID: <20230512134414.GA913159@workstation> Mail-Followup-To: Takashi Iwai , Dan Carpenter , Clemens Ladisch , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org References: <873542aro1.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <873542aro1.wl-tiwai@suse.de> Message-ID-Hash: FQXTT4EWEKR6P7LQIAUP65KFMWM4ZZBB X-Message-ID-Hash: FQXTT4EWEKR6P7LQIAUP65KFMWM4ZZBB X-MailFrom: o-takashi@sakamocchi.jp X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi, On Fri, May 12, 2023 at 10:18:54AM +0200, Takashi Iwai wrote: > On Tue, 09 May 2023 11:07:11 +0200, > Dan Carpenter wrote: > > > > This code was supposed to return an error code if init_stream() > > failed, but it instead freed dg00x->rx_stream and returned success. > > This potentially leads to a use after free. > > > > Fixes: 9a08067ec318 ("ALSA: firewire-digi00x: support AMDTP domain") > > Signed-off-by: Dan Carpenter > > Thanks, applied now. I overlooked the patch. It looks good to me as well. Acked-by: Takashi Sakamoto Thanks Takashi Sakamoto