From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EE21C77B7C for ; Sun, 28 May 2023 17:24:08 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 57D2E3E7; Sun, 28 May 2023 19:23:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 57D2E3E7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1685294645; bh=a0bn35byPravsJL/aYIpPMkp2CEo3YyQfJm8G1Uhmj0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=K76BvBZ069dvLNhTI2TMqqIPdqI+mEZCZPKUuFYJF2zpiWws4Xt0v2lMeUUBQuK8t 8kqYbTmrckEKhdOGCkrd/c0ST3o9qbLiJctHcqPvNcS/TdFVMetibJSRI/CUMOfm9X Gk5pkjm++a7+j+xG3+0zqrPASWjrjaLbEo6WWDiA= Received: by alsa1.perex.cz (Postfix, from userid 50401) id EF13FF8042F; Sun, 28 May 2023 19:22:46 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 61DACF8042F; Sun, 28 May 2023 19:22:46 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 88CE2F8042F; Sun, 28 May 2023 19:22:42 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4F9D6F80149 for ; Sun, 28 May 2023 19:22:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4F9D6F80149 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=JcSvyNHS Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8814A60B6A; Sun, 28 May 2023 17:22:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14F97C433EF; Sun, 28 May 2023 17:22:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685294558; bh=a0bn35byPravsJL/aYIpPMkp2CEo3YyQfJm8G1Uhmj0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JcSvyNHSuJhMCIZhkT0NmgEV5yatXQOX99p2xnzxjucNbNZ6i+BarPWm+13xPevVd KnycU6jKzIlvm7c2h7mYTACvih4blk1JQl65IJZfKFy9lzQDMiWBd9fp6RMx+4sZEG ibDQ0gagPYT7jefM+FoWANzeB8YfacbrZ6le8iCjeL13sJyotz6bySx47Um43dQ9G3 bwo2hN2kWqgdJTsdpjEHJszC3HNRRx7MtHXZPm8Kuhj+8llDq9h56E4lsVZ6p0atQA FzK0m/L8lOLn9PUhYRNtOciGzh5XjkBGF/zDc5GE6A52LX5sxmDOsGCALfgjU6O8xY IzaFvxx+p9pXg== Date: Sun, 28 May 2023 18:38:55 +0100 From: Jonathan Cameron To: Herve Codina Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lars-Peter Clausen , Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Christophe Leroy , Thomas Petazzoni Subject: Re: [PATCH v2 7/9] ASoC: codecs: Add support for the generic IIO auxiliary devices Message-ID: <20230528183855.0c95d308@jic23-huawei> In-Reply-To: <20230523151223.109551-8-herve.codina@bootlin.com> References: <20230523151223.109551-1-herve.codina@bootlin.com> <20230523151223.109551-8-herve.codina@bootlin.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: KNKB4CYW67NOIPMPZGRYFHYVL5QH2XYY X-Message-ID-Hash: KNKB4CYW67NOIPMPZGRYFHYVL5QH2XYY X-MailFrom: jic23@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 23 May 2023 17:12:21 +0200 Herve Codina wrote: > Industrial I/O devices can be present in the audio path. > These devices needs to be used as audio components in order to be fully > integrated in the audio path. > > This support allows to consider these Industrial I/O devices as auxliary > audio devices and allows to control them using mixer controls. > > Signed-off-by: Herve Codina > --- > diff --git a/sound/soc/codecs/audio-iio-aux.c b/sound/soc/codecs/audio-iio-aux.c > new file mode 100644 > index 000000000000..21575c4b35fd > --- /dev/null > +++ b/sound/soc/codecs/audio-iio-aux.c > @@ -0,0 +1,302 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +// > +// audio-iio-aux.c -- ALSA SoC glue to use IIO devices as audio components > +// > +// Copyright 2023 CS GROUP France > +// > +// Author: Herve Codina > + > +#include > +#include #include ideally to pick up the of_device_id definition without bouncing through some non obvious header path. > +#include > +#include > +#include Otherwise, the IIO elements of this look good. So for those at least Reviewed-by: Jonathan Cameron I don't have enough knowledge of the snd stuff to review those parts. Jonathan