From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: <lee@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<linus.walleij@linaro.org>, <vkoul@kernel.org>,
<robh+dt@kernel.org>, <conor+dt@kernel.org>,
<lgirdwood@gmail.com>, <yung-chuan.liao@linux.intel.com>,
<sanyog.r.kale@intel.com>, <pierre-louis.bossart@linux.intel.com>,
<alsa-devel@alsa-project.org>, <patches@opensource.cirrus.com>,
<devicetree@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/6] spi: cs42l43: Add SPI controller support
Date: Wed, 31 May 2023 08:34:02 +0000 [thread overview]
Message-ID: <20230531083402.GF68926@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <171e2054-e41c-46a5-b478-f699909c5bd7@sirena.org.uk>
On Tue, May 30, 2023 at 10:30:46PM +0100, Mark Brown wrote:
> On Tue, May 30, 2023 at 01:21:11PM +0100, Charles Keepax wrote:
>
> A couple of small things:
>
> > +static unsigned int cs42l43_clock_divs[16] = {
> > + 2, 2, 4, 6, 8, 10, 12, 14, 16, 18, 20, 22, 24, 26, 28, 30
> > +};
>
> Do we need to specify the size of the array? I just had to count the
> number of initialisers :( Should probably also be const.
>
> > + for (; buf < block - (sizeof(u32) - 1); buf += sizeof(u32))
> > + regmap_write(regmap, CS42L43_TX_DATA, *(const u32 *)buf);
>
> We're passing a byte stream through a u32 here - are you sure this is
> endian safe?
Ah shoot, yeah Andy made some comments on this that seem to have
got lost in my mass of fixups. I will fixup for a v3.
Thanks,
Charles
next prev parent reply other threads:[~2023-05-31 8:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 12:21 [PATCH v2 0/6] Add cs42l43 PC focused SoundWire CODEC Charles Keepax
2023-05-30 12:21 ` [PATCH v2 1/6] soundwire: bus: Allow SoundWire peripherals to register IRQ handlers Charles Keepax
2023-05-30 12:21 ` [PATCH v2 2/6] dt-bindings: sound: cirrus,cs42l43: Add initial DT binding Charles Keepax
2023-05-31 8:50 ` Charles Keepax
2023-05-31 9:02 ` Krzysztof Kozlowski
2023-05-31 14:12 ` Charles Keepax
2023-05-30 12:21 ` [PATCH v2 3/6] mfd: cs42l43: Add support for cs42l43 core driver Charles Keepax
2023-05-30 12:21 ` [PATCH v2 4/6] pinctrl: cs42l43: Add support for the cs42l43 Charles Keepax
2023-06-01 11:22 ` Linus Walleij
2023-05-30 12:21 ` [PATCH v2 5/6] spi: cs42l43: Add SPI controller support Charles Keepax
2023-05-30 21:30 ` Mark Brown
2023-05-31 8:34 ` Charles Keepax [this message]
2023-05-31 5:26 ` Mahapatra, Amit Kumar
2023-05-31 8:44 ` Charles Keepax
2023-05-30 12:21 ` [PATCH v2 6/6] ASoC: cs42l43: Add support for the cs42l43 Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531083402.GF68926@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox