From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B7E7C77B73 for ; Mon, 5 Jun 2023 17:38:05 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D788A3E7; Mon, 5 Jun 2023 19:37:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D788A3E7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1685986682; bh=eOM1QQpaTQIMrgVqkxLpu8cchSBKMYQp6H/dwtHfVrc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=G+X0aVsDiU1RXP31LeKPPadTBLG+UY8Lq9IiCnqhd/otVC0b1yua07lTJRaULthYo F+1Ahet63l1uRKGo3u2xh1iB+1/Epk3rJRpqm0MxWv3OVs0KIQYCorXBXHu1cmZaR2 fAsA/cjbfXlDN5c5ff3ra5/yzZ1KZz311geOzEPE= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8C205F80199; Mon, 5 Jun 2023 19:36:46 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 48A20F80199; Mon, 5 Jun 2023 19:36:46 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 92893F80199; Mon, 5 Jun 2023 19:36:43 +0200 (CEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5EC26F800ED for ; Mon, 5 Jun 2023 19:36:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5EC26F800ED Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=fi5uoXdA X-GND-Sasl: herve.codina@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1685986599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yjxc+85Bq54GZEvP6akAc9UZPm7vVtcD2MajvGxNqiY=; b=fi5uoXdANbPmsJUCGLlp8YkQvRea5sm2llsgEt0TFFbN/DiK/ijhu1QIs5Lb2SHJSBwlTa xdRattLNG7l9JpgH7Z2IWlWWnCWosU1xEqePGqf0QzTm5HkuErSI72aB0EIN6+4amnT0Ga 8P+eqvTkLDpUBP2q2wVkWdPbKHMPlb/UrWbta2UWHEFpzfSkXWd8qOJMTia0XbM4I72MNo htz4tOzOJNwc7ZqbKvRPvV4SamC6GjcYV5Yf3fFGzU1Qozhdsb7h7PJ7F8Vnc6JSTYkcZc ETtauzV/LnDHBQc6O1Sj8LPo50Bx0osDRQ1RHgVz9XCDZ+P/SY/4l7DojYpbKA== X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com X-GND-Sasl: herve.codina@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id A2C4E20004; Mon, 5 Jun 2023 17:36:37 +0000 (UTC) Date: Mon, 5 Jun 2023 19:36:36 +0200 From: Herve Codina To: Jonathan Cameron Cc: Andy Shevchenko , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , Lars-Peter Clausen , Jaroslav Kysela , Takashi Iwai , "Kuninori Morimoto" , , , , , Christophe Leroy , Thomas Petazzoni Subject: Re: [PATCH v2 5/9] iio: inkern: Add a helper to query an available minimum raw value Message-ID: <20230605193636.5239a271@bootlin.com> In-Reply-To: <20230605180547.0000528b@Huawei.com> References: <20230523151223.109551-1-herve.codina@bootlin.com> <20230523151223.109551-6-herve.codina@bootlin.com> <20230605094637.7615b689@bootlin.com> <20230605180547.0000528b@Huawei.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Message-ID-Hash: DORZVNHBU45ALHXP3QGTY2UPAQ6VJFSQ X-Message-ID-Hash: DORZVNHBU45ALHXP3QGTY2UPAQ6VJFSQ X-MailFrom: herve.codina@bootlin.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Jonathan, Andy, On Mon, 5 Jun 2023 18:05:47 +0100 Jonathan Cameron wrote: > On Mon, 5 Jun 2023 12:45:24 +0300 > Andy Shevchenko wrote: > ... > > > > > + default: > > > > > + /* FIXME: learn about min for other iio values */ > > > > > > > > I believe in a final version this comment won't be here. > > > > > > We have the same FIXME comment in the iio_channel_read_max() function I > > > copied to create this iio_channel_read_min() and, to be honest, I > > > don't really know how to handle these other cases. > > > > > > In this series, I would prefer to keep this FIXME. > > > > I see, Jonathan needs to be involved here then. > > It's really more of a TODO when someone needs it than a FIXME. > I'm not particularly keen to see a bunch of code supporting cases > that no one uses, but it's useful to call out where the code would > go if other cases were to be supported. > > Perhaps soften it to a note that doesn't have the work FIXME in it. > > Jonathan > Right, I will change to /* TODO: learn about max for other iio values */ in the next iteration (both iio_channel_read_max() and iio_channel_read_min()) Regards, Hervé > > > > > > > > + return -EINVAL; > > >