From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA91EEB64D7 for ; Fri, 16 Jun 2023 10:33:13 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 63D01E0E; Fri, 16 Jun 2023 12:32:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 63D01E0E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1686911591; bh=gXQNjNoCFoi3qRgG5JfUdAujGHNYzIpHAOKgEMcQnss=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=Pa+Emw0Br4uAtYdmSKA5csm9TRru6hBoxu9yz7c4oDv06xHPdGSp6J7etbIa2xERy FdmKF7e+2z0BuyfdFF6KcrHQJQiIVF1ZJ0FvRylg8WnnnaOrEMMZQOC8PVdZ9vYWEc a/V1ZtdFXvH27D/K7nWf5AEUX8WRMMkf8aOSnjmE= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 42486F80635; Fri, 16 Jun 2023 12:28:37 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id B309DF80635; Fri, 16 Jun 2023 12:28:37 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1FAB8F805A1; Fri, 16 Jun 2023 12:28:34 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C067EF80635 for ; Fri, 16 Jun 2023 12:28:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C067EF80635 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=dAlteZCG Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AC1F663736; Fri, 16 Jun 2023 10:28:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 327A5C433A9; Fri, 16 Jun 2023 10:28:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686911307; bh=gXQNjNoCFoi3qRgG5JfUdAujGHNYzIpHAOKgEMcQnss=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dAlteZCGupm7HOhB8ROQmqbQ/jl56jP6dimHUCaDHUJ38S5Y0R6VsO2W/A7JU8A1Y 25e/x79H5jYh4ReImnYPg0GzFVvnM+xLvhlRki1p99bXLL6FirTjwM6xS7zzgZhsxJ fIYEr3+CIcPBNbeYxGhDEA3WW2yI7x8p3VNHS2EdtcfZ1Vu4KdQsW0pjdDEjBQ3LNk bVuouFw7d/BF+TflrkYeZJsSaLjmf17eC8RMgQ7NlMwbau0CUrQj4PsTIYyl6NDvzU /ZeAx376zPkyEpa38vUKWSpgqkDw69sl48RZ1QSOWu/DzDpzV/4SSviY2kC3fuNZKW 2ag4+P1hMbHJQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Herve Codina , Kuninori Morimoto , Mark Brown , Sasha Levin , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, astrid.rost@axis.com, aidanmacdonald.0x0@gmail.com, alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 5.4 2/8] ASoC: simple-card: Add missing of_node_put() in case of error Date: Fri, 16 Jun 2023 06:28:15 -0400 Message-Id: <20230616102821.674153-2-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230616102821.674153-1-sashal@kernel.org> References: <20230616102821.674153-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.247 Content-Transfer-Encoding: 8bit Message-ID-Hash: AMZ5RA63HUYIG27UTJ6KIZECMPLAG7QF X-Message-ID-Hash: AMZ5RA63HUYIG27UTJ6KIZECMPLAG7QF X-MailFrom: sashal@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Herve Codina [ Upstream commit 8938f75a5e35c597a647c28984a0304da7a33d63 ] In the error path, a of_node_put() for platform is missing. Just add it. Signed-off-by: Herve Codina Acked-by: Kuninori Morimoto Link: https://lore.kernel.org/r/20230523151223.109551-9-herve.codina@bootlin.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/generic/simple-card.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c index 4484c40c7a39c..653181d7eaa34 100644 --- a/sound/soc/generic/simple-card.c +++ b/sound/soc/generic/simple-card.c @@ -404,6 +404,7 @@ static int simple_for_each_link(struct asoc_simple_priv *priv, if (ret < 0) { of_node_put(codec); + of_node_put(plat); of_node_put(np); goto error; } -- 2.39.2