From: Syed Saba Kareem <Syed.SabaKareem@amd.com>
To: <broonie@kernel.org>, <alsa-devel@alsa-project.org>
Cc: Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
Sunil-kumar.Dommati@amd.com,
"Syed Saba Kareem" <Syed.SabaKareem@amd.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"V sujith kumar Reddy" <Vsujithkumar.Reddy@amd.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"open list" <linux-kernel@vger.kernel.org>
Subject: [PATCH 01/11] ASoC: amd: acp: remove acp poweroff function
Date: Thu, 22 Jun 2023 20:53:39 +0530 [thread overview]
Message-ID: <20230622152406.3709231-2-Syed.SabaKareem@amd.com> (raw)
In-Reply-To: <20230622152406.3709231-1-Syed.SabaKareem@amd.com>
BIOS invokes ACP Power off sequence based on ACP device state.
Remove redundant code from ACP PCI driver for ACP Power off sequence.
Signed-off-by: Syed Saba Kareem <Syed.SabaKareem@amd.com>
---
sound/soc/amd/acp/acp-rembrandt.c | 25 -------------------------
sound/soc/amd/acp/acp-renoir.c | 17 -----------------
2 files changed, 42 deletions(-)
diff --git a/sound/soc/amd/acp/acp-rembrandt.c b/sound/soc/amd/acp/acp-rembrandt.c
index 5c455cc04113..1b997837c7d8 100644
--- a/sound/soc/amd/acp/acp-rembrandt.c
+++ b/sound/soc/amd/acp/acp-rembrandt.c
@@ -204,23 +204,6 @@ static int acp6x_power_on(void __iomem *base)
return -ETIMEDOUT;
}
-static int acp6x_power_off(void __iomem *base)
-{
- u32 val;
- int timeout;
-
- writel(ACP_PGFSM_CNTL_POWER_OFF_MASK,
- base + ACP6X_PGFSM_CONTROL);
- timeout = 0;
- while (++timeout < 500) {
- val = readl(base + ACP6X_PGFSM_STATUS);
- if ((val & ACP_PGFSM_STATUS_MASK) == ACP_POWERED_OFF)
- return 0;
- udelay(1);
- }
- return -ETIMEDOUT;
-}
-
static int acp6x_reset(void __iomem *base)
{
u32 val;
@@ -299,14 +282,6 @@ static int rmb_acp_deinit(void __iomem *base)
}
writel(0x00, base + ACP_CONTROL);
-
- /* power off */
- ret = acp6x_power_off(base);
- if (ret) {
- pr_err("ACP power off failed\n");
- return ret;
- }
-
return 0;
}
diff --git a/sound/soc/amd/acp/acp-renoir.c b/sound/soc/amd/acp/acp-renoir.c
index b3cbc7f19ec5..f188365fe214 100644
--- a/sound/soc/amd/acp/acp-renoir.c
+++ b/sound/soc/amd/acp/acp-renoir.c
@@ -169,17 +169,6 @@ static int acp3x_power_on(void __iomem *base)
return readl_poll_timeout(base + ACP_PGFSM_STATUS, val, !val, DELAY_US, ACP_TIMEOUT);
}
-static int acp3x_power_off(void __iomem *base)
-{
- u32 val;
-
- writel(ACP_PWR_OFF_MASK, base + ACP_PGFSM_CONTROL);
-
- return readl_poll_timeout(base + ACP_PGFSM_STATUS, val,
- (val & ACP_PGFSM_STAT_MASK) == ACP_POWERED_OFF,
- DELAY_US, ACP_TIMEOUT);
-}
-
static int acp3x_reset(void __iomem *base)
{
u32 val;
@@ -246,12 +235,6 @@ static int rn_acp_deinit(void __iomem *base)
return ret;
writel(0x00, base + ACP_CONTROL);
-
- /* power off */
- ret = acp3x_power_off(base);
- if (ret)
- return ret;
-
return 0;
}
static int renoir_audio_probe(struct platform_device *pdev)
--
2.25.1
next prev parent reply other threads:[~2023-06-22 15:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 15:23 [PATCH 01/12] ASoC: amd: acp: clear pdm dma interrupt mask Syed Saba Kareem
2023-06-22 15:23 ` Syed Saba Kareem [this message]
2023-06-22 15:23 ` [PATCH 02/11] ASoC: amd: acp: refactor the acp init and de-init sequence Syed Saba Kareem
2023-06-22 15:23 ` [PATCH 02/12] ASoC: amd: acp: remove acp poweroff function Syed Saba Kareem
2023-06-22 15:23 ` [PATCH 03/11] ASoC: amd: acp: add acp i2s master clock generation for rembrandt platform Syed Saba Kareem
2023-06-22 15:23 ` [PATCH 03/12] ASoC: amd: acp: refactor the acp init and de-init sequence Syed Saba Kareem
2023-06-22 15:23 ` [PATCH 04/12] ASoC: amd: acp: add acp i2s master clock generation for rembrandt platform Syed Saba Kareem
2023-06-22 22:30 ` Mark Brown
2023-06-23 14:07 ` Saba Kareem, Syed
2023-06-22 22:30 ` kernel test robot
2023-06-22 15:23 ` [PATCH 04/11] ASoC: amd: acp: remove the redundant acp enable/disable interrupts functions Syed Saba Kareem
2023-06-22 15:23 ` [PATCH 05/12] " Syed Saba Kareem
2023-06-23 4:13 ` kernel test robot
2023-06-22 15:23 ` [PATCH 05/11] ASoC: amd: acp: store platform device reference created in pci probe call Syed Saba Kareem
2023-06-22 15:23 ` [PATCH 06/11] ASoC: amd: acp: add pm ops support for acp pci driver Syed Saba Kareem
2023-06-22 15:23 ` [PATCH 06/12] ASoC: amd: acp: store platform device reference created in pci probe call Syed Saba Kareem
2023-06-22 15:23 ` [PATCH 07/12] ASoC: amd: acp: add pm ops support for acp pci driver Syed Saba Kareem
2023-06-22 15:23 ` [PATCH 07/11] ASoC: amd: acp: store xfer_resolution of the stream Syed Saba Kareem
2023-06-22 15:23 ` [PATCH 08/11] ASoC: amd: acp: export config_acp_dma() and config_pte_for_stream() symbols Syed Saba Kareem
2023-06-22 15:23 ` [PATCH 08/12] ASoC: amd: acp: store xfer_resolution of the stream Syed Saba Kareem
2023-06-22 15:23 ` [PATCH 09/12] ASoC: amd: acp: export config_acp_dma() and config_pte_for_stream() symbols Syed Saba Kareem
2023-06-22 15:23 ` [PATCH 09/11] ASoC: amd: acp: store the pdm stream channel mask Syed Saba Kareem
2023-06-22 15:23 ` [PATCH 10/11] ASoC: amd: acp: move pdm macros to common header file Syed Saba Kareem
2023-06-22 15:23 ` [PATCH 10/12] ASoC: amd: acp: store the pdm stream channel mask Syed Saba Kareem
2023-06-22 15:23 ` [PATCH 11/11] ASoC: amd: acp: add pm ops support for rembrandt platform Syed Saba Kareem
2023-06-22 15:23 ` [PATCH 11/12] ASoC: amd: acp: move pdm macros to common header file Syed Saba Kareem
2023-06-22 15:24 ` [PATCH 12/12] ASoC: amd: acp: add pm ops support for rembrandt platform Syed Saba Kareem
2023-06-23 0:49 ` [PATCH 01/12] ASoC: amd: acp: clear pdm dma interrupt mask Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230622152406.3709231-2-Syed.SabaKareem@amd.com \
--to=syed.sabakareem@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=Vsujithkumar.Reddy@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox