From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F03EEB64D9 for ; Thu, 29 Jun 2023 15:25:00 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7D72D826; Thu, 29 Jun 2023 17:24:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7D72D826 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1688052298; bh=uEZ+i5d2u82iYj67d+xX7ScW+fCo0ujDDDUeVm1r1s0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=HRAmPSyeNtYVMzOhz6NUAHWXMQTJieeBFmky48zATruRKATO9/mh3QdyqMXKQ0V6x JcRFhk1y5US6rkdactKNpiUUXIOsJXufQ1uZ5vPAHDvlgZE7FTEtvLohic3dzCyV9Y tu42gtAuKWqmCz0MK1hgSR1qmLrWfE+cnG8TpN+w= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9EBC2F80431; Thu, 29 Jun 2023 17:23:47 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 07918F80246; Thu, 29 Jun 2023 17:23:47 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BEAD2F80246; Thu, 29 Jun 2023 17:23:43 +0200 (CEST) Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4C5E4F80169 for ; Thu, 29 Jun 2023 17:23:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4C5E4F80169 Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-7836272f36eso33544239f.1 for ; Thu, 29 Jun 2023 08:23:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688052220; x=1690644220; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pIbzwk+16IGxV6FWzckLUrfZmaj1Jf5Ee41P3nY/4zc=; b=c/FAVy6dbOrUAtlmFEn/+ITvAbsICMIDEYSxjdoFeSHj0shuXDYeYUwNPrl21ie8mq Y58tBeUTKLzgD/SwQ+VIEBwIEwCDvyz0EB6qyYrdkr9NCPSm2r42pDUFuITlx7ixXaUG b39Biudi/h3KRyYG3ZYbS6QBhajGqbevgLlsTuF62Zg0N2BNlxRgToeNakiSechxlvti /Z2+JLBPgoc4d9MMX1kddEiTBNUGc7C8qFnWlOM7kuPg567kdchu1srxzxwTTbM2O043 nHDPsHhpYEn3aIxv8UJSxnl5LluKqRXZLypeaVp7wknHZdIOUsXff7amtU4uKXZ7cci3 B/GQ== X-Gm-Message-State: AC+VfDyMu8IwCfbomDIpeS9M4Biej75THOAEspRBzLfdcypaqhGd5AJP w/WgpFe8GBWmcmFLDwulpA== X-Google-Smtp-Source: ACHHUZ4BPmwhYeRuCB1b3WD8WeQpdEUY5Y/vga5MesEG9brj/gXSLEqJny1Nwo0NSJlCoeZIxy778g== X-Received: by 2002:a5e:9508:0:b0:785:fbe8:1da0 with SMTP id r8-20020a5e9508000000b00785fbe81da0mr5086305ioj.15.1688052219729; Thu, 29 Jun 2023 08:23:39 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id ei23-20020a05663829b700b0042ad757be01sm2260064jab.121.2023.06.29.08.23.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jun 2023 08:23:38 -0700 (PDT) Received: (nullmailer pid 3060526 invoked by uid 1000); Thu, 29 Jun 2023 15:23:35 -0000 Date: Thu, 29 Jun 2023 09:23:35 -0600 From: Rob Herring To: Konrad Dybcio Cc: cros-qcom-dts-watchers@chromium.org, Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , Conor Dooley , Dmitry Baryshkov , Benjamin Li , James Willcox , Joseph Gates , Stephan Gerhold , Zac Crosby , Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , Lee Jones , Stephen Boyd , Joerg Roedel , Will Deacon , Robin Murphy , Greg Kroah-Hartman , Xu Yang , Peng Fan , Christian Marangi , Wesley Cheng , Jun Nie , Max Chen , Shawn Guo , Vivek Gautam , Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Knecht , "Bryan O'Donoghue" , Konrad Dybcio , alsa-devel@alsa-project.org, iommu@lists.linux.dev, linux-usb@vger.kernel.org, Krzysztof Kozlowski , Leo Yan , Andy Gross Subject: Re: [PATCH 08/11] dt-bindings: usb: ci-hdrc-usb2: Fix handling pinctrl properties Message-ID: <20230629152335.GA3055525-robh@kernel.org> References: <20230627-topic-more_bindings-v1-0-6b4b6cd081e5@linaro.org> <20230627-topic-more_bindings-v1-8-6b4b6cd081e5@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230627-topic-more_bindings-v1-8-6b4b6cd081e5@linaro.org> Message-ID-Hash: 6YM2VEVGXW6FQVJA7KR4BCXW6GG3AP6Q X-Message-ID-Hash: 6YM2VEVGXW6FQVJA7KR4BCXW6GG3AP6Q X-MailFrom: robherring2@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, Jun 27, 2023 at 06:24:24PM +0200, Konrad Dybcio wrote: > Untangle the bit messy oneOf trees and add the missing pinctrl-2 mention > to handle the different pinctrl combinations. > > Fixes: 4c8375d35f72 ("dt-bindings: usb: ci-hdrc-usb2: convert to DT schema format") > Signed-off-by: Konrad Dybcio > --- > .../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 27 ++++++---------------- > 1 file changed, 7 insertions(+), 20 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > index 782402800d4a..24431a7adf3e 100644 > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > @@ -199,17 +199,6 @@ properties: > In case of HSIC-mode, "idle" and "active" pin modes are mandatory. > In this case, the "idle" state needs to pull down the data and > strobe pin and the "active" state needs to pull up the strobe pin. > - oneOf: > - - items: > - - const: idle > - - const: active These are no longer valid values? The description still mentions them. > - - items: > - - const: default > - - enum: > - - host > - - device > - - items: > - - const: default > > pinctrl-0: > maxItems: 1 > @@ -357,17 +346,15 @@ allOf: > - const: active > else: > properties: > + pinctrl-2: This should be implicitly allowed. Is it not? I'm reallly at a loss as to what problem this patch solves. > + maxItems: 1 > + > pinctrl-names: > minItems: 1 > - maxItems: 2 > - oneOf: > - - items: > - - const: default > - - enum: > - - host > - - device > - - items: > - - const: default > + items: > + - const: default > + - const: host > + - const: device > - if: > properties: > compatible: > > -- > 2.41.0 >