From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1784CEB64D9 for ; Wed, 12 Jul 2023 11:59:13 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D80AC84A; Wed, 12 Jul 2023 13:58:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D80AC84A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1689163150; bh=BPwn7ycrAHdiOF8yVt+5jZUIynmY0GSHF1SaS+Uh9HI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=gNJgs+AEVxdo9kaFpi53RmjZlmfbYZi7nZFuouPDnP8OnmP9MebE0+Oo4VDmG7wai nzjA56+JDGUpsXqO4TDsdJlxlCXsp0eIOQxOEiXplLtiKcMxRQ58aJtCIyS4V05fOa cmI2luqC0s2szP+KN5f2A2jyDLRSeISMVURR1pkM= Received: by alsa1.perex.cz (Postfix, from userid 50401) id AE3D8F80153; Wed, 12 Jul 2023 13:58:19 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 2B995F80249; Wed, 12 Jul 2023 13:58:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3110BF80249; Wed, 12 Jul 2023 13:58:16 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B273DF80153 for ; Wed, 12 Jul 2023 13:58:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B273DF80153 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=twit5vP4 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7FB6461794; Wed, 12 Jul 2023 11:58:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46615C433C8; Wed, 12 Jul 2023 11:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689163090; bh=BPwn7ycrAHdiOF8yVt+5jZUIynmY0GSHF1SaS+Uh9HI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=twit5vP4HZmDg1OUtV3zp39IIdA3GcgdIFUcCwXcZ2MQqpD9wlLeMZZZT44WlJmOW Czhz2zQdWB0zYX2prS7nSsn71GE67kUDe7EBCOr6eBfGS59iCkVGyA2/V9xb9A7jSy SJ/HO+uAwR7KEAKnOdLanjQeovqKN3YJZnT5XuzawSoKw5QRqIBRP2C2ev6fc14wbM I8Bmm1iKe1Gtqgw2o8KyiUC/0fSlfCzl/1WiYvXa9t1GCgHlvaalRrQgpJjG7AJOny bG66eHoqx+0ae76mvknhjvW0Oc4zqvhSIQ3JutlwQoHgms7Asaj9vjku8leLQyTR77 kbfOiGwmNZEeQ== Date: Wed, 12 Jul 2023 12:58:04 +0100 From: Lee Jones To: Geert Uytterhoeven Cc: Mark Brown , Greg Kroah-Hartman , "Rafael J . Wysocki" , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Benjamin Gray , Christophe Leroy , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] regmap: REGMAP_SLIMBUS should select REGMAP Message-ID: <20230712115804.GC10768@google.com> References: <7519324a34015e1c046227269409fef688889f4f.1688643442.git.geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7519324a34015e1c046227269409fef688889f4f.1688643442.git.geert@linux-m68k.org> Message-ID-Hash: EBHFCR5DPZJSS6K5MS6MNQRVBMK37BEJ X-Message-ID-Hash: EBHFCR5DPZJSS6K5MS6MNQRVBMK37BEJ X-MailFrom: lee@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 06 Jul 2023, Geert Uytterhoeven wrote: > If CONFIG_SND_SOC_WCD934X=y, CONFIG_COMPILE_TEST=y, > CONFIG_MFD_WCD934X=n, CONFIG_REGMAP=n: > > sound/soc/codecs/wcd934x.c:518:38: error: array type has incomplete element type ‘struct regmap_range_cfg’ > 518 | static const struct regmap_range_cfg wcd934x_ifc_ranges[] = { > | ^~~~~~~~~~~~~~~~~~ > > Fix this by making REGMAP_SLIMBUS select REGMAP. > > Drop the selection of REGMAP by MFD_WCD934X, as this is not needed > (now both REGMAP_SLIMBUS and REGMAP_IRQ select REGMAP). > > Signed-off-by: Geert Uytterhoeven > --- > drivers/base/regmap/Kconfig | 1 + > drivers/mfd/Kconfig | 1 - Acked-by: Lee Jones > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig > index e25cc619c75de3d9..c3a260ed4e864959 100644 > --- a/drivers/base/regmap/Kconfig > +++ b/drivers/base/regmap/Kconfig > @@ -34,6 +34,7 @@ config REGMAP_I2C > config REGMAP_SLIMBUS > tristate > depends on SLIMBUS > + select REGMAP > > config REGMAP_SPI > tristate > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 0b6af476f554a191..5857dad2c64828fa 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -2121,7 +2121,6 @@ config MFD_STMFX > config MFD_WCD934X > tristate "Support for WCD9340/WCD9341 Codec" > depends on SLIMBUS > - select REGMAP > select REGMAP_SLIMBUS > select REGMAP_IRQ > select MFD_CORE > -- > 2.34.1 > -- Lee Jones [李琼斯]