From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Cc: "Takashi Iwai" <tiwai@suse.de>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Nuno Sá" <nuno.sa@analog.com>, "Mark Brown" <broonie@kernel.org>
Subject: [PATCH 06/11] ASoC: sigmadsp: Simplify with snd_ctl_activate_id()
Date: Tue, 18 Jul 2023 16:12:59 +0200 [thread overview]
Message-ID: <20230718141304.1032-7-tiwai@suse.de> (raw)
In-Reply-To: <20230718141304.1032-1-tiwai@suse.de>
Use the standard snd_ctl_activate_id() helper instead of an open code
for code simplification.
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: "Nuno Sá" <nuno.sa@analog.com>
Cc: Mark Brown <broonie@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/soc/codecs/sigmadsp.c | 25 ++++---------------------
1 file changed, 4 insertions(+), 21 deletions(-)
diff --git a/sound/soc/codecs/sigmadsp.c b/sound/soc/codecs/sigmadsp.c
index 3047a6fbb380..b93c078a8040 100644
--- a/sound/soc/codecs/sigmadsp.c
+++ b/sound/soc/codecs/sigmadsp.c
@@ -669,36 +669,19 @@ static void sigmadsp_activate_ctrl(struct sigmadsp *sigmadsp,
struct sigmadsp_control *ctrl, unsigned int samplerate_mask)
{
struct snd_card *card = sigmadsp->component->card->snd_card;
- struct snd_kcontrol_volatile *vd;
- struct snd_ctl_elem_id id;
bool active;
- bool changed = false;
+ int changed;
active = sigmadsp_samplerate_valid(ctrl->samplerates, samplerate_mask);
-
- down_write(&card->controls_rwsem);
- if (!ctrl->kcontrol) {
- up_write(&card->controls_rwsem);
+ if (!ctrl->kcontrol)
return;
- }
-
- id = ctrl->kcontrol->id;
- vd = &ctrl->kcontrol->vd[0];
- if (active == (bool)(vd->access & SNDRV_CTL_ELEM_ACCESS_INACTIVE)) {
- vd->access ^= SNDRV_CTL_ELEM_ACCESS_INACTIVE;
- changed = true;
- }
- up_write(&card->controls_rwsem);
-
- if (active && changed) {
+ changed = snd_ctl_activate_id(card, &ctrl->kcontrol->id, active);
+ if (active && changed > 0) {
mutex_lock(&sigmadsp->lock);
if (ctrl->cached)
sigmadsp_ctrl_write(sigmadsp, ctrl, ctrl->cache);
mutex_unlock(&sigmadsp->lock);
}
-
- if (changed)
- snd_ctl_notify(card, SNDRV_CTL_EVENT_MASK_INFO, &id);
}
/**
--
2.35.3
next prev parent reply other threads:[~2023-07-18 14:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 14:12 [PATCH 00/11] ALSA: Make control API taking controls_rwsem consistently Takashi Iwai
2023-07-18 14:12 ` [PATCH 01/11] ALSA: control: Take card->controls_rwsem in snd_ctl_rename() Takashi Iwai
2023-07-18 14:12 ` [PATCH 02/11] staging: greybus: audio_helper: Use snd_ctl_remove_id() Takashi Iwai
2023-07-18 18:00 ` Greg Kroah-Hartman
2023-07-18 14:12 ` [PATCH 03/11] ASoC: atmel: mchp-pdmc: " Takashi Iwai
2023-07-18 14:45 ` claudiu beznea
2023-07-18 14:59 ` Mark Brown
2023-07-18 14:12 ` [PATCH 04/11] ALSA: control: Take controls_rwsem lock in snd_ctl_remove() Takashi Iwai
2023-07-18 14:12 ` [PATCH 05/11] ALSA: control: Add lockdep warning to internal functions Takashi Iwai
2023-07-18 14:12 ` Takashi Iwai [this message]
2023-07-18 14:58 ` [PATCH 06/11] ASoC: sigmadsp: Simplify with snd_ctl_activate_id() Mark Brown
2023-07-18 14:13 ` [PATCH 07/11] staging: greybus: Avoid abusing controls_rwsem Takashi Iwai
2023-07-18 18:00 ` Greg Kroah-Hartman
2023-07-18 14:13 ` [PATCH 08/11] ALSA: control: Make snd_ctl_find_id() argument const Takashi Iwai
2023-07-18 14:13 ` [PATCH 09/11] ALSA: control: Introduce unlocked version for snd_ctl_find_*() helpers Takashi Iwai
2023-07-18 14:13 ` [PATCH 10/11] ALSA: control: Take lock in snd_ctl_find_id() and snd_ctl_find_numid() Takashi Iwai
2023-07-19 10:20 ` Oswald Buddenhagen
2023-07-19 10:45 ` Takashi Iwai
2023-07-18 14:13 ` [PATCH 11/11] ALSA: emu10k1: Go back and simplify with snd_ctl_find_id() Takashi Iwai
2023-07-20 8:16 ` [PATCH 00/11] ALSA: Make control API taking controls_rwsem consistently Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718141304.1032-7-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox