From: kernel test robot <lkp@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: oe-kbuild-all@lists.linux.dev, alsa-devel@alsa-project.org
Subject: [tiwai-sound:test/pcm-sockptr 18/26] drivers/media/pci/solo6x10/solo6x10-g723.c:207:12: warning: 'snd_solo_pcm_copy' defined but not used
Date: Sat, 29 Jul 2023 11:03:09 +0800 [thread overview]
Message-ID: <202307291119.03yget13-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/pcm-sockptr
head: 3fffa74b00add561981357c76375e1829059d4e5
commit: 79cf0bf97368998dd44c1863d6f54057846b68c9 [18/26] media: solo6x10: Convert to generic PCM copy ops
config: i386-buildonly-randconfig-r004-20230728 (https://download.01.org/0day-ci/archive/20230729/202307291119.03yget13-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230729/202307291119.03yget13-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307291119.03yget13-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/media/pci/solo6x10/solo6x10-g723.c:242:10: error: 'const struct snd_pcm_ops' has no member named 'copye'; did you mean 'copy'?
242 | .copye = snd_solo_pcm_copy_user,
| ^~~~~
| copy
drivers/media/pci/solo6x10/solo6x10-g723.c:242:18: error: 'snd_solo_pcm_copy_user' undeclared here (not in a function); did you mean 'snd_solo_pcm_copy'?
242 | .copye = snd_solo_pcm_copy_user,
| ^~~~~~~~~~~~~~~~~~~~~~
| snd_solo_pcm_copy
drivers/media/pci/solo6x10/solo6x10-g723.c:242:18: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
drivers/media/pci/solo6x10/solo6x10-g723.c:242:18: note: (near initialization for 'snd_solo_pcm_ops')
>> drivers/media/pci/solo6x10/solo6x10-g723.c:207:12: warning: 'snd_solo_pcm_copy' defined but not used [-Wunused-function]
207 | static int snd_solo_pcm_copy(struct snd_pcm_substream *ss, int channel,
| ^~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/snd_solo_pcm_copy +207 drivers/media/pci/solo6x10/solo6x10-g723.c
206
> 207 static int snd_solo_pcm_copy(struct snd_pcm_substream *ss, int channel,
208 unsigned long pos, sockptr_t dst,
209 unsigned long count)
210 {
211 struct solo_snd_pcm *solo_pcm = snd_pcm_substream_chip(ss);
212 struct solo_dev *solo_dev = solo_pcm->solo_dev;
213 unsigned int off = 0;
214 int err, i;
215
216 for (i = 0; i < (count / G723_FRAMES_PER_PAGE); i++) {
217 int page = (pos / G723_FRAMES_PER_PAGE) + i;
218
219 err = solo_p2m_dma_t(solo_dev, 0, solo_pcm->g723_dma,
220 SOLO_G723_EXT_ADDR(solo_dev) +
221 (page * G723_PERIOD_BLOCK) +
222 (ss->number * G723_PERIOD_BYTES),
223 G723_PERIOD_BYTES, 0, 0);
224 if (err)
225 return err;
226
227 if (copy_to_sockptr_offset(dst, off,
228 solo_pcm->g723_buf, G723_PERIOD_BYTES))
229 return -EFAULT;
230 off += G723_PERIOD_BYTES;
231 }
232
233 return 0;
234 }
235
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-07-29 3:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202307291119.03yget13-lkp@intel.com \
--to=lkp@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox