From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB5C9C001DE for ; Mon, 31 Jul 2023 14:40:09 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7000E820; Mon, 31 Jul 2023 16:39:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7000E820 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1690814406; bh=I+HTilLE0eCgqcOxm8A9AzbA88OpHR1hterp6c6XU+w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=MQB+bd6dsO+VqF4HCMexgWHNGnLx54eNuhi9URawv/Pd7UHkwEiaq551hsCkuMsRM 1+jLKuC3Pdtby/FVlBP6OQqBTUh0RkndwrT0oSHGam6QywinGeJP94Ie7F6/4bhSQ9 bHeW5pLG5mC2K+YiU/5oP/vZue0m0SAhAt2bP4uo= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0E241F8015B; Mon, 31 Jul 2023 16:39:15 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id A434AF8016D; Mon, 31 Jul 2023 16:39:15 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2DF40F8016D; Mon, 31 Jul 2023 16:39:13 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 74FB1F80149 for ; Mon, 31 Jul 2023 16:39:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 74FB1F80149 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Pg+zp2Ux Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2F031610A3; Mon, 31 Jul 2023 14:39:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79B60C433C7; Mon, 31 Jul 2023 14:39:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690814342; bh=I+HTilLE0eCgqcOxm8A9AzbA88OpHR1hterp6c6XU+w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pg+zp2UxyorlYipjOt2QuL2ulmdPZOv6nqgX8rI7HeFvug9s4uUjTa7fk79yJpEJZ kHJIg6Z09MuBmxvZJMz0zBvsfY9SuES52uCVOp98BgNUkZPsAx2MMUEjZugT4Oggog NBGUpxONXSFmhKzNBPavt7eavVNB8kxNt3n0vvryKgwCsd4BwOQsHWUxNWajJc3oH8 sZ+ZaPbj4JyaWZAwz6LO1jDGvPA7EMmXVj40RP77w9SdUECS+f+Gc2hB2WZDcmX/8l GrsKzmxO061FUgIS6HjTQ7bAT5+QxQEU5qmOPbePzUCVf5uv7ldYatz7zF8mfbHnLK /z0h20ZI/tWjg== Received: (nullmailer pid 2931468 invoked by uid 1000); Mon, 31 Jul 2023 14:38:59 -0000 Date: Mon, 31 Jul 2023 08:38:59 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Judy Hsiao , Sylwester Nawrocki , Conor Dooley , Takashi Iwai , linux-mediatek@lists.infradead.org, Fabio Estevam , alsa-devel@alsa-project.org, NXP Linux Team , Rao Mandadapu , Trevor Wu , Jonathan Bakker , Jerome Brunet , linux-arm-kernel@lists.infradead.org, Matthias Brugger , Cheng-Yi Chiang , Pengutronix Kernel Team , devicetree@vger.kernel.org, Rohit kumar , AngeloGioacchino Del Regno , Shengjiu Wang , Shawn Guo , Jaroslav Kysela , Mark Brown , Krzysztof Kozlowski , Liam Girdwood , Sascha Hauer , linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/12] ASoC: dt-bindings: mediatek,mt8188-mt6359: use common sound card Message-ID: <20230731143859.GA2928327-robh@kernel.org> References: <20230731094303.185067-1-krzysztof.kozlowski@linaro.org> <20230731094303.185067-4-krzysztof.kozlowski@linaro.org> <169080070077.2404962.11506468692056687115.robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <169080070077.2404962.11506468692056687115.robh@kernel.org> Message-ID-Hash: BY6B5HNW274OQMZAKFTX6RPFPBNC5PDI X-Message-ID-Hash: BY6B5HNW274OQMZAKFTX6RPFPBNC5PDI X-MailFrom: SRS0=3R/A=DR=robh_at_kernel.org=rob@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Jul 31, 2023 at 04:51:46AM -0600, Rob Herring wrote: > > On Mon, 31 Jul 2023 11:42:54 +0200, Krzysztof Kozlowski wrote: > > The mediatek,mt8188-mt6359 Linux sound machine driver requires the > > "model" property, so binding was incomplete. Reference the common sound > > card properties to fix that which also allows to remove duplicated > > property definitions. Leave the relevant parts of "audio-routing" > > description. > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > .../bindings/sound/mediatek,mt8188-mt6359.yaml | 17 +++++++---------- > > 1 file changed, 7 insertions(+), 10 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml: > Error in referenced schema matching $id: http://devicetree.org/schemas/sound/sound-card-common.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.example.dtb: sound: False schema does not allow {'compatible': ['mediatek,mt8188-mt6359-evb'], 'model': ['MT6359-EVB'], 'mediatek,platform': [[4294967295]], 'pinctrl-names': ['default'], 'pinctrl-0': [[4294967295]], 'audio-routing': ['Headphone', 'Headphone L', 'Headphone', 'Headphone R', 'AIN1', 'Headset Mic'], 'dai-link-0': {'link-name': ['ETDM3_OUT_BE'], 'dai-format': ['i2s'], 'mediatek,clk-provider': ['cpu'], 'codec': {'sound-dai': [[4294967295]]}}, '$nodename': ['sound']} > from schema $id: http://devicetree.org/schemas/sound/mediatek,mt8188-mt6359.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.example.dtb: sound: Unevaluated properties are not allowed ('model' was unexpected) > from schema $id: http://devicetree.org/schemas/sound/mediatek,mt8188-mt6359.yaml# Looks like patch 2 could not be applied causing this. Rob