From: Chris Morgan <macroalpha82@gmail.com>
To: alsa-devel@alsa-project.org
Cc: perex@perex.cz, danct12@disroot.org,
Chris Morgan <macromorgan@hotmail.com>
Subject: [PATCH] ucm2: Rockchip: rk817: Fix Master Playback Volume
Date: Thu, 7 Sep 2023 20:21:37 -0500 [thread overview]
Message-ID: <20230908012137.4123094-1-macroalpha82@gmail.com> (raw)
From: Chris Morgan <macromorgan@hotmail.com>
Correct the "Master Playback Volume" from a PlaybackMixerElem to a
PlaybackVolume. A user reported that without this change the hardware
volume would not change correctly. I've confirmed that when using
Pipewire the Pipewire volume and Master Playback Volume would change
independently, in some circumstances resulting in very low volume
that would be difficult to troubleshoot. By changing the Master
Playback Volume to PlaybackVolume this problem would no longer occur.
Fixes: b0497ca4b508 ("ucm2: Rockchip: rk817: Add ALSA UCM support")
Reported-by: Dang Huynh <danct12@disroot.org>
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
ucm2/Rockchip/rk817-sound/HiFi.conf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ucm2/Rockchip/rk817-sound/HiFi.conf b/ucm2/Rockchip/rk817-sound/HiFi.conf
index 8d90567..a714759 100644
--- a/ucm2/Rockchip/rk817-sound/HiFi.conf
+++ b/ucm2/Rockchip/rk817-sound/HiFi.conf
@@ -26,7 +26,7 @@ SectionDevice."Speaker" {
]
Value {
- PlaybackMixerElem "Master Playback Volume"
+ PlaybackVolume "Master Playback Volume"
PlaybackPriority 100
PlaybackPCM "hw:${CardId}"
}
@@ -55,7 +55,7 @@ SectionDevice."Headphones" {
]
Value {
- PlaybackMixerElem "Master Playback Volume"
+ PlaybackVolume "Master Playback Volume"
PlaybackPriority 200
PlaybackPCM "hw:${CardId}"
JackControl "Headphones Jack"
--
2.34.1
reply other threads:[~2023-09-08 1:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230908012137.4123094-1-macroalpha82@gmail.com \
--to=macroalpha82@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=danct12@disroot.org \
--cc=macromorgan@hotmail.com \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox