From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B402EEAA4F for ; Thu, 14 Sep 2023 15:07:40 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 639DB950; Thu, 14 Sep 2023 17:06:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 639DB950 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1694704058; bh=TXiuRN+fe9222gKISsn8I4Nogbg3rIgI0SbpBvdFjlg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=cPNF28e11noVtGZQpFo25E5UiUbEWPbhezBBCuj/FHIbsRYpCnxAtQP7rMfs1rQdp z75iNvOCCAmCfQrHyjGa1zYXFWyvha+qpIdw81Li9A10LlRPRLUQC7mph4qbE20TRN A0Q0uUoz9FhlMnyLaMUt8VI3o3yxp1fnfZbi5IH4= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 548D6F80551; Thu, 14 Sep 2023 17:06:20 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id DCC5BF80141; Thu, 14 Sep 2023 17:06:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8FC2EF80431; Tue, 12 Sep 2023 20:54:17 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 91954F80212 for ; Tue, 12 Sep 2023 20:54:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 91954F80212 Authentication-Results: alsa1.perex.cz; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=AQbfl2VA Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DEC8961342; Tue, 12 Sep 2023 18:54:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 823B5C433C7; Tue, 12 Sep 2023 18:54:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694544849; bh=TXiuRN+fe9222gKISsn8I4Nogbg3rIgI0SbpBvdFjlg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AQbfl2VAFMXprI20AyydmsAr0WY8B0+CRGiMAJBjHuM7zSB08TgOI39lOlAx4tapU SAr8+vpjsNuFUeyxhdDsGrxFGTGdtpVOQxdNr4Td1zvJiZnOs96WFm9JRZ3JUGuWAJ fzNqrnCeVj73z7hV9uCGgWxPMXMvvEXmqZeB0p0qfEOwtTjqgcfHJwKZhz722LgOz1 7N5gtqy7r3WoNRVv7/FN3geOzhHRldS2I5I6QZVjnI+HfBMQIswdDyHZ/5d6indzNa bSX/C78catM28TBZV7Q4ac0dpeVTMDC2LWq7gfdCfrIC7Q1ou6Wk/pO1Z/hKqMJ1oL wfD6zTM+4J/YA== Received: (nullmailer pid 1225743 invoked by uid 1000); Tue, 12 Sep 2023 18:54:05 -0000 Date: Tue, 12 Sep 2023 13:54:05 -0500 From: Rob Herring To: Conor Dooley Cc: Herve Codina , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-@alsa-project.org, devel@alsa-project.org, Simon Horman , Christophe JAILLET , Thomas Petazzoni Subject: Re: [PATCH v5 25/31] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer Message-ID: <20230912185405.GA1165807-robh@kernel.org> References: <20230912081527.208499-1-herve.codina@bootlin.com> <20230912101444.225809-1-herve.codina@bootlin.com> <20230912-overplay-donated-080eb97803d6@spud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230912-overplay-donated-080eb97803d6@spud> X-MailFrom: SRS0=xM+6=E4=robh_at_kernel.org=rob@kernel.org X-Mailman-Rule-Hits: implicit-dest X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header Message-ID-Hash: ICBKOL6M55VSQGED6P42K25UMMM2BGSB X-Message-ID-Hash: ICBKOL6M55VSQGED6P42K25UMMM2BGSB X-Mailman-Approved-At: Thu, 14 Sep 2023 15:06:15 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, Sep 12, 2023 at 07:13:32PM +0100, Conor Dooley wrote: > Yo, > > I'm not au fait enough with this to leave particularly meaningful > comments, so just some minor ones for you. > > On Tue, Sep 12, 2023 at 12:14:44PM +0200, Herve Codina wrote: > > The Lantiq PEF2256 is a framer and line interface component designed to > > fulfill all required interfacing between an analog E1/T1/J1 line and the > > digital PCM system highway/H.100 bus. > > > > Signed-off-by: Herve Codina > > Signed-off-by: Christophe Leroy > > Missing a co-developed-by? Whomever sends the patch should have the last Sob. > > > --- > > .../bindings/net/lantiq,pef2256.yaml | 214 ++++++++++++++++++ > > 1 file changed, 214 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/lantiq,pef2256.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/lantiq,pef2256.yaml b/Documentation/devicetree/bindings/net/lantiq,pef2256.yaml > > new file mode 100644 > > index 000000000000..c4f21678bf6a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/lantiq,pef2256.yaml > > @@ -0,0 +1,214 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/lantiq,pef2256.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Lantiq PEF2256 > > + > > +maintainers: > > + - Herve Codina > > + > > +description: > > + The Lantiq PEF2256, also known as Infineon PEF2256 or FALC56, is a framer and > > + line interface component designed to fulfill all required interfacing between > > + an analog E1/T1/J1 line and the digital PCM system highway/H.100 bus. > > + > > +properties: > > + compatible: > > + items: > > + - const: lantiq,pef2256 > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + items: > > + - description: Master clock > > My OCD is rather upset by the inconsistent capitalisation used here :/ > > > + - description: System Clock Receive > > + - description: System Clock Transmit > > + > > + clock-names: > > + items: > > + - const: mclk > > + - const: sclkr > > + - const: sclkx > > + > > + interrupts: > > + maxItems: 1 > > + > > + reset-gpios: > > + description: > > + GPIO used to reset the device. > > + maxItems: 1 > > + > > + pinctrl: > > + $ref: /schemas/pinctrl/pinctrl.yaml# > > + additionalProperties: false > > + > > + patternProperties: > > + '-pins$': > > + type: object > > + $ref: /schemas/pinctrl/pinmux-node.yaml# > > + additionalProperties: false > > + > > + properties: > > + pins: > > + enum: [ RPA, RPB, RPC, RPD, XPA, XPB, XPC, XPD ] > > + > > + function: > > + enum: [ SYPR, RFM, RFMB, RSIGM, RSIG, DLR, FREEZE, RFSP, LOS, > > + SYPX, XFMS, XSIG, TCLK, XMFB, XSIGM, DLX, XCLK, XLT, > > + GPI, GPOH, GPOL ] > > + > > + required: > > + - pins > > + - function > > + > > + lantiq,data-rate-bps: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [2048000, 4096000, 8192000, 16384000] > > -kBps is a standard suffix, would it be worth using that instead here? > What you have would fit as even multiples. > Otherwise Rob, should dt-schema grow -bps as a standard suffix? Yeah, I think that makes sense. I've added it now. Rob