From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 955EDEDEC70 for ; Wed, 13 Sep 2023 14:54:18 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 35F5BA4D; Wed, 13 Sep 2023 16:53:26 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 35F5BA4D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1694616856; bh=r3MsKyMLqXE5yq3D3uQ+6fXm7KlK1PLMGKDuISMSllA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=FvwazjO7lPybuzq8ABORkCaRNDrMpanMCKKwSW5BJVcd123QSSJLly00swcZANf6Y O+Gz0ABm6nxuGC4rAcIkeYp0TW458gIZCpAaIeBFJ9UiVsubJlEAFHdYNo2SI/Inft 4IGvmf1X/NtuM7o4taL7twUojmgcRiDaVxxdrpwE= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 12F33F80549; Wed, 13 Sep 2023 16:53:03 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 7C9D8F80425; Wed, 13 Sep 2023 16:53:03 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CBF1EF80425; Wed, 13 Sep 2023 16:53:00 +0200 (CEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CF43CF80212 for ; Wed, 13 Sep 2023 16:52:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CF43CF80212 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=EWGGroVB Received: by mail.gandi.net (Postfix) with ESMTPSA id CF61860003; Wed, 13 Sep 2023 14:52:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1694616776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aC2RwGdKDnCnTcsXt08pnHkYtsoUowN+XP5X8ItFDzc=; b=EWGGroVBltxzuCTMJt8gh/2G/eIS6B94Qbe3nrqz+sp5y/iQBhr+/O1HKlOYMDY3TE9PC4 L6RELowCewGfATaEd1BYi5ynfm7M+G1PkGyfClkGeqCeZ7brzmiVhltXORoJIwqFnz62AV QMqNup3T4xnUR3CRAG4k1LtxYWyDKI9RySRBsblI79TYUm8eHqFqp+ilb87PZjqsuTVx6R OvMePhchN2VhFn45J4AmUqmTFbk4FPvtWSv6ExxPgkEdHEYYNAgC70wnjn+uPT3yEP5nI+ IjbFoQl30h2z0mrZE0DUi/xfVs+AuF4ogRRsV4TWD7u4En8RdGI0CJTnCncG0w== Date: Wed, 13 Sep 2023 16:52:50 +0200 From: Herve Codina To: Conor Dooley Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Simon Horman , Christophe JAILLET , Thomas Petazzoni Subject: Re: [PATCH v5 08/31] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add support for QMC HDLC Message-ID: <20230913165250.02bab2ad@bootlin.com> In-Reply-To: <20230913-unruly-recite-7dbbbd7e63e0@spud> References: <20230912081527.208499-1-herve.codina@bootlin.com> <20230912101018.225246-1-herve.codina@bootlin.com> <20230912-capable-stash-c7a3e33078ac@spud> <20230913092640.76934b31@bootlin.com> <20230913-unruly-recite-7dbbbd7e63e0@spud> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Message-ID-Hash: 7MSESY4WJOF4Y5EIFD2KYCYPZ7WRVFHX X-Message-ID-Hash: 7MSESY4WJOF4Y5EIFD2KYCYPZ7WRVFHX X-MailFrom: herve.codina@bootlin.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 13 Sep 2023 15:42:45 +0100 Conor Dooley wrote: > On Wed, Sep 13, 2023 at 09:26:40AM +0200, Herve Codina wrote: > > Hi Conor, > > > > On Tue, 12 Sep 2023 18:21:58 +0100 > > Conor Dooley wrote: > > > > > On Tue, Sep 12, 2023 at 12:10:18PM +0200, Herve Codina wrote: > > > > The QMC (QUICC mutichannel controller) is a controller present in some > > > > PowerQUICC SoC such as MPC885. > > > > The QMC HDLC uses the QMC controller to transfer HDLC data. > > > > > > > > Additionally, a framer can be connected to the QMC HDLC. > > > > If present, this framer is the interface between the TDM bus used by the > > > > QMC HDLC and the E1/T1 line. > > > > The QMC HDLC can use this framer to get information about the E1/T1 line > > > > and configure the E1/T1 line. > > > > > > > > Signed-off-by: Herve Codina > > > > --- > > > > .../bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml | 13 +++++++++++++ > > > > 1 file changed, 13 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml > > > > index 82d9beb48e00..b5073531f3f1 100644 > > > > --- a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml > > > > +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml > > > > @@ -101,6 +101,16 @@ patternProperties: > > > > Channel assigned Rx time-slots within the Rx time-slots routed by the > > > > TSA to this cell. > > > > > > > > + compatible: > > > > + const: fsl,qmc-hdlc > > > > + > > > > + fsl,framer: > > > > + $ref: /schemas/types.yaml#/definitions/phandle > > > > + description: > > > > + phandle to the framer node. The framer is in charge of an E1/T1 line > > > > + interface connected to the TDM bus. It can be used to get the E1/T1 line > > > > + status such as link up/down. > > > > > > Sounds like this fsl,framer property should depend on the compatible > > > being present, no? > > > > Well from the implementation point of view, only the QMC HDLC driver uses this > > property. > > > > From the hardware description point of view, this property means that the time slots > > handled by this channel are connected to the framer. So I think it makes sense for > > any channel no matter the compatible (even if compatible is not present). > > > > Should I change and constraint the fsl,framer property to the compatible presence ? > > If so, is the following correct for this contraint ? > > --- 8< --- > > dependencies: > > - fsl,framer: [ compatible ]; > > --- 8< --- > > The regular sort of > if: > compatible: > contains: > const: foo > then: > required: > - fsl,framer > would fit the bill, no? Not sure. "fsl,framer" is an optional property (depending on the hardware we can have a framer or not). Hervé