Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
To: tiwai@suse.com, perex@perex.cz
Cc: alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com
Subject: [PATCH] ALSA: hda: hda_auto_parser: Always set codec->fixup_name when a quirk found
Date: Tue, 19 Sep 2023 16:23:22 +0300	[thread overview]
Message-ID: <20230919132322.17352-1-peter.ujfalusi@linux.intel.com> (raw)

If a fixup is found via a quirk then the codec->fixup_name is only set if
CONFIG_SND_DEBUG_VERBOSE is enabled, otherwise the fixup_name is set to
NULL.

This will result prints in __snd_hda_apply_fixup() when applying the found
fixup for example:
ehdaudio0D0: ALC236: Apply fix-func for (null)

Fixes: 73355ddd8775 ("ALSA: hda: Code refactoring snd_hda_pick_fixup()")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
---
 sound/pci/hda/hda_auto_parser.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/pci/hda/hda_auto_parser.c b/sound/pci/hda/hda_auto_parser.c
index 7c6b1fe8dfcc..7b1ddb8d40cb 100644
--- a/sound/pci/hda/hda_auto_parser.c
+++ b/sound/pci/hda/hda_auto_parser.c
@@ -1043,9 +1043,8 @@ void snd_hda_pick_fixup(struct hda_codec *codec,
 
  found_device:
 	id = q->value;
-#ifdef CONFIG_SND_DEBUG_VERBOSE
 	name = q->name;
-#endif
+
 	codec_dbg(codec, "%s: picked fixup %s for %s %04x:%04x\n",
 		  codec->core.chip_name, name ? name : "",
 		  type, q->subvendor, q->subdevice);
-- 
2.42.0


             reply	other threads:[~2023-09-19 13:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-19 13:23 Peter Ujfalusi [this message]
2023-09-19 13:37 ` [PATCH] ALSA: hda: hda_auto_parser: Always set codec->fixup_name when a quirk found Takashi Iwai
2023-09-19 13:51   ` Péter Ujfalusi
2023-09-19 14:02     ` Takashi Iwai
2023-09-19 17:16 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230919132322.17352-1-peter.ujfalusi@linux.intel.com \
    --to=peter.ujfalusi@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox