From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
linux-kernel@vger.kernel.org,
sound-open-firmware@alsa-project.org
Subject: [PATCH v5 04/12] ALSA: hda/intel: Fix error handling in azx_probe()
Date: Fri, 29 Sep 2023 16:51:18 +0200 [thread overview]
Message-ID: <20230929145123.233838-5-maarten.lankhorst@linux.intel.com> (raw)
In-Reply-To: <20230929145123.233838-1-maarten.lankhorst@linux.intel.com>
Add missing pci_set_drv to NULL call on error.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
---
sound/pci/hda/hda_intel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index ca765ac4765f4..b4ac0d43c09bc 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2176,6 +2176,7 @@ static int azx_probe(struct pci_dev *pci,
return 0;
out_free:
+ pci_set_drvdata(pci, NULL);
snd_card_free(card);
return err;
}
--
2.39.2
next prev parent reply other threads:[~2023-09-30 8:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 14:51 [PATCH v5 00/12] sound: Use -EPROBE_DEFER instead of i915 module loading Maarten Lankhorst
2023-09-29 14:51 ` [PATCH v5 01/12] ASoC/SOF/core: Ensure sof_ops_free() is still called when probe never ran Maarten Lankhorst
2023-09-29 15:25 ` Mark Brown
2023-09-29 14:51 ` [PATCH v5 02/12] ASoC: SOF: core: Add probe_early and remove_late callbacks Maarten Lankhorst
2023-09-29 15:26 ` Mark Brown
2023-09-29 14:51 ` [PATCH v5 03/12] ASoC: SOF: Intel: hda: start splitting the probe Maarten Lankhorst
2023-09-29 15:26 ` Mark Brown
2023-09-29 14:51 ` Maarten Lankhorst [this message]
2023-09-29 14:51 ` [PATCH v5 05/12] ALSA: hda/i915: Allow override of gpu binding Maarten Lankhorst
2023-09-29 14:51 ` [PATCH v5 06/12] ALSA: hda/i915: Add an allow_modprobe argument to snd_hdac_i915_init Maarten Lankhorst
2023-09-29 14:51 ` [PATCH v5 07/12] ALSA: hda/i915: Allow xe as match for i915_component_master_match Maarten Lankhorst
2023-09-29 14:51 ` [PATCH v5 08/12] ASoC: Intel: avs: Move snd_hdac_i915_init to before probe_work Maarten Lankhorst
2023-09-29 14:51 ` [PATCH v5 09/12] ALSA: hda/intel: " Maarten Lankhorst
2023-09-29 15:25 ` [PATCH v5 00/12] sound: Use -EPROBE_DEFER instead of i915 module loading Mark Brown
2023-10-02 16:52 ` [PATCH v5 10/12] ASoC: Intel: Skylake: Move snd_hdac_i915_init to before probe_work Maarten Lankhorst
2023-10-03 6:55 ` Amadeusz Sławiński
2023-10-03 7:15 ` Amadeusz Sławiński
2023-10-02 16:52 ` [PATCH v5 11/12] ASoC: SOF: Intel: Move binding to display driver outside of deferred probe Maarten Lankhorst
2023-10-02 16:52 ` [PATCH v5 12/12] ALSA: hda/i915: Remove extra argument from snd_hdac_i915_init Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230929145123.233838-5-maarten.lankhorst@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).