From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E01CAE95A9E for ; Mon, 9 Oct 2023 15:55:38 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 10293E0F; Mon, 9 Oct 2023 17:54:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 10293E0F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1696866936; bh=WHvnIgHj274hBcwT1QygQFbhFy2/Vp+GehcfkDYv8jQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=rDkkLoYUXskZT8oQ7fytN51B6ugWGHVi2bd//9pGRuzpKsCyLHWkDesXgLUynZyVe SDvIRBAE/sXmDSre8exB4BLX1D5ERatcCYB+qulxTMDtVXVfWP0xS+kto/0cY4r1C8 v6i/59KXf+BlKHZNDTbA7jBB3kCsRbKmrnkltblI= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7AFCCF80558; Mon, 9 Oct 2023 17:54:25 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 3294EF802BE; Mon, 9 Oct 2023 17:54:25 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4AA0FF8047D; Sat, 7 Oct 2023 10:35:20 +0200 (CEST) Received: from mail.andi.de1.cc (unknown [IPv6:2a02:c205:3004:2154::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id ABDFEF801EB for ; Sat, 7 Oct 2023 10:35:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz ABDFEF801EB Received: from p5dc58360.dip0.t-ipconnect.de ([93.197.131.96] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qp2m5-004c4z-Ex; Sat, 07 Oct 2023 10:35:01 +0200 Date: Sat, 7 Oct 2023 10:34:59 +0200 From: Andreas Kemnade To: Tony Lindgren Cc: =?UTF-8?B?UMOpdGVy?= Ujfalusi , bcousson@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, jarkko.nikula@bitmer.com, dmitry.torokhov@gmail.com, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 1/3] ASoC: ti: omap-mcbsp: Ignore errors for getting fck_src Message-ID: <20231007103459.29998aa8@aktux> In-Reply-To: <20231007074159.GX34982@atomide.com> References: <20230705190324.355282-1-andreas@kemnade.info> <20230705190324.355282-2-andreas@kemnade.info> <7d58d52d-2087-45af-b29e-2515b63ead13@gmail.com> <20230920063353.GQ5285@atomide.com> <20230921121626.GT5285@atomide.com> <20231006102348.GK34982@atomide.com> <20231006213003.0fbac87a@aktux> <20231007062518.GM34982@atomide.com> <20231007091156.588d7ba1@aktux> <20231007074159.GX34982@atomide.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-MailFrom: andreas@kemnade.info X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: F263LPAM6OYSSRMA43G36C5BIMOKJHNZ X-Message-ID-Hash: F263LPAM6OYSSRMA43G36C5BIMOKJHNZ X-Mailman-Approved-At: Mon, 09 Oct 2023 15:54:20 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sat, 7 Oct 2023 10:41:59 +0300 Tony Lindgren wrote: > * Andreas Kemnade [231007 07:12]: > > Well, it is a regression caused by your fix. Without it (and not reverting > > the already applied ignore patch), runtime is properly suspended. Don't know > > why yet. > > We return early from omap2_mcbsp_set_clks_src() with IS_ERR(fck_src) and > the runtime PM functions never get called? > no, we do not. This patch we are talking about to do it in a better way made its way into mainline v6.6-rc1. The other pieces of sound support did not, they need rework. Regards, Andreas