From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F135CDB465 for ; Thu, 19 Oct 2023 14:13:05 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 94042AEA; Thu, 19 Oct 2023 16:12:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 94042AEA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1697724783; bh=+b6MrpibNwRDkAxbGe5094fEFInCK5bTh3PC1pcYnDc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=UGX62ww3OJLocnc2DnpmgKBSJbHDCqErdiR50riWLBwix3+jfuf4+pQx5Rqu5mG1G 0IK+uGVxksW9uCwZ+irX/PXS2VhlnYJpGmVNqOpb/5W1dMcAQgvbR0kmfrJMIX4URB yweSpwmwcOCLXEI1iwEn5eXGeXAjZ6VkRx7e4owM= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2D1BEF805D8; Thu, 19 Oct 2023 16:10:26 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 54932F805D9; Thu, 19 Oct 2023 16:10:25 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DE929F8025F; Wed, 18 Oct 2023 08:22:06 +0200 (CEST) Received: from mail.andi.de1.cc (mail.andi.de1.cc [IPv6:2a02:c205:3004:2154::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 89E2EF80236 for ; Wed, 18 Oct 2023 08:21:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 89E2EF80236 Received: from p200300ccff145f001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff14:5f00:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qszw7-00580I-U3; Wed, 18 Oct 2023 08:21:44 +0200 Date: Wed, 18 Oct 2023 08:21:42 +0200 From: Andreas Kemnade To: Tony Lindgren Cc: =?UTF-8?B?UMOpdGVy?= Ujfalusi , bcousson@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, jarkko.nikula@bitmer.com, dmitry.torokhov@gmail.com, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 1/3] ASoC: ti: omap-mcbsp: Ignore errors for getting fck_src Message-ID: <20231018082142.5b7d3ad5@aktux> In-Reply-To: <20231018052345.GK34982@atomide.com> References: <20230705190324.355282-1-andreas@kemnade.info> <20230705190324.355282-2-andreas@kemnade.info> <7d58d52d-2087-45af-b29e-2515b63ead13@gmail.com> <20230920063353.GQ5285@atomide.com> <20230921121626.GT5285@atomide.com> <20231006102348.GK34982@atomide.com> <20231006213003.0fbac87a@aktux> <20231007062518.GM34982@atomide.com> <20231015234815.637f5c14@aktux> <20231018052345.GK34982@atomide.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-MailFrom: andreas@kemnade.info X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: QLCZ267Y6ZJZ2DWTIULLPXQNLDJKYI5R X-Message-ID-Hash: QLCZ267Y6ZJZ2DWTIULLPXQNLDJKYI5R X-Mailman-Approved-At: Thu, 19 Oct 2023 14:10:01 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 18 Oct 2023 08:23:45 +0300 Tony Lindgren wrote: > * Andreas Kemnade [231015 21:48]: > > On Sat, 7 Oct 2023 09:25:18 +0300 > > Tony Lindgren wrote: > > > If so then the following might be a fix, not familiar with runtime PM > > > done by ASoC though and not sure if some kind of locking would be > > > needed here. > > > > > just checked: that one fixes the regression. runtime suspends again. > > OK good to hear. So is there some fixes tag for this one or where did this > start happening? I'm not quite following how the dropping of platform data > could have affected this, maybe it just hid the problem because of > returning early? > yes I think so. From a perspective of OMAP[45] mith McBSP in master mode, applying "clk: ti: Fix missing omap4 mcbsp functional clock and aliases" on top of "ASoC: ti: omap-mcbsp: Ignore errors for getting fck_src" is a regression. For everyone else not. So "clk: ti: Fix missing omap4 mcbsp functional clock and aliases" did uncover a hidden problem, but of course it is the right step forward. Regards Andreas