From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13EC1C4332F for ; Wed, 8 Nov 2023 23:40:34 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3D103828; Thu, 9 Nov 2023 00:39:42 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3D103828 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1699486832; bh=lgaMG9SE8xr1h0jd/J59eB/Gs/1kHNsX/vyv61WNWtQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=DwgSm5jrPQpXckzktJwvXo9THrVQJ6Cgw6ZnsDwQFOCiBSPvorCi1ml9OZjHZKoDz o8swC/80sKLkPUJqNMfsb0ve45o7m8rdDtOfD2D4L6UCFHhIF/q6T3IAlfTl3ww5kU zvW5KiXGYK1uqPieX1OF/GLc1ywAP+k4CBtRAWT0= Received: by alsa1.perex.cz (Postfix, from userid 50401) id D7975F80564; Thu, 9 Nov 2023 00:39:19 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 166D3F8016D; Thu, 9 Nov 2023 00:39:19 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 76104F8016D; Thu, 9 Nov 2023 00:39:11 +0100 (CET) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 34084F80125 for ; Thu, 9 Nov 2023 00:38:58 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 34084F80125 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=N5+lAS1Q Received: by mail.gandi.net (Postfix) with ESMTPSA id 1BEB6240002; Wed, 8 Nov 2023 23:38:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1699486737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZWGdlfzeQ997IaAZInKpU2sKbuC+Orz4F3vDh0PjvMg=; b=N5+lAS1QuxDD2SdkvbVdLw6qWEExpftDZPduFcY4jvX3tX20kCAWoNxKTCbZRtf9w+ouLF l4fKQQcmYAJfL8NzZdxIG/Zw2NQvea1Blg8JDbZhLzGFqwUFZSMLAZQbKEtgh+f0oxmK4T EpVXWt1UurkD/XfaaScPMdGHnbdIhAsxc8NUUIWyZcFHTWS+vs9cASEwT34LE+hQQNy3eN 0IDd6wLXmMcmnxq54uddsLKPdwBZzrwtOTy4lTn/ffsBGYKNJFjj8vvBRXDFioGx8SKIzF K8zpiBozZs5QOnMp5PMhArdwmbRirW7GuvBX/PaIdsbwc92dALc61l+dNbST7Q== Date: Thu, 9 Nov 2023 00:38:54 +0100 From: Alexandre Belloni To: Krzysztof Kozlowski Cc: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Alessandro Zummo , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 06/17] dt-bindings: rtc: s3c-rtc: add specific compatibles for existing SoC Message-ID: <202311082338542f79f576@mail.local> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-7-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231108104343.24192-7-krzysztof.kozlowski@linaro.org> X-GND-Sasl: alexandre.belloni@bootlin.com Message-ID-Hash: BXNIFZS5WQUT2THS5WPLHZCYQBS53HP5 X-Message-ID-Hash: BXNIFZS5WQUT2THS5WPLHZCYQBS53HP5 X-MailFrom: alexandre.belloni@bootlin.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 08/11/2023 11:43:32+0100, Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Alexandre Belloni > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml > index d51b236939bf..bf4e11d6dffb 100644 > --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml > +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml > @@ -17,6 +17,11 @@ properties: > - samsung,s3c2416-rtc > - samsung,s3c2443-rtc > - samsung,s3c6410-rtc > + - items: > + - enum: > + - samsung,exynos7-rtc > + - samsung,exynos850-rtc > + - const: samsung,s3c6410-rtc > - const: samsung,exynos3250-rtc > deprecated: true > > -- > 2.34.1 > > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com