From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9395EC4332F for ; Fri, 10 Nov 2023 20:40:16 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9DB9D844; Fri, 10 Nov 2023 21:39:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9DB9D844 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1699648814; bh=b9+OKu32hvDBZxMxYKjNcaWKvoysggGtH5qfewgB6Ro=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=gqMU1mZFgoRnINeZ9tfahzLe3l/MYsqGUFa2PHxx53Rqk38LqQh9T7UYo7oOPbt0x Jmn7L7aKcwdXUqtRy096XUO3/Uc8wv1M8gXY/ngySrRwaoLYiO2WiBPLcNnW/K2QmN GGu4uQtm/0LGt1o8onkp/zlDDZRYP8H8hsZNumgE= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4D977F80557; Fri, 10 Nov 2023 21:39:18 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id E62B7F80431; Fri, 10 Nov 2023 21:39:17 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B0295F80431; Fri, 10 Nov 2023 21:39:15 +0100 (CET) Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 18892F800ED for ; Fri, 10 Nov 2023 21:39:12 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 18892F800ED Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3b2ec5ee2e4so1427699b6e.3 for ; Fri, 10 Nov 2023 12:39:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699648751; x=1700253551; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yS2DPG1f2BOqV0lB92Cpsm9LSSGSaVSlz4hVTLG41TM=; b=jfg43917vMPL+wWzdz6jAk/sF9do6Osbf74mitwgxuRci2OlcYxl6bBmqUOwi7yejZ tleJoTLuDnnP7KizsmVcCJArjPisgxXLYsgdODPW1p4s338qiudRJp/M1Ye1F5IHslA9 Ybb3onZAkxpH5iNf1gewW68GGhNFiTGauj9KduREcgGumhq1WPjTU4WnlpjSqD1P7WU/ WVVP5ltVd0iB97lMSWCWueKe276oZqgCVApa22YxlSL1m3BBFsvHtS2hww2Ea3hsJOdE CTEZK4eWJrkoD1parcHX2phVR4ygWuKFB6dPXNbL2kGYKqe5P6+UPkgoGpWeICt8yIaU yhzw== X-Gm-Message-State: AOJu0Yzdd4Z9s1kiVuiRLkIUUYJVedSbAiGvoKWWwJ7v3Q5wGocauP+v /qnRvg096mZqCuGBVPegRg== X-Google-Smtp-Source: AGHT+IE11yxoIUKi4thNm7Iyj/ixtWImO1W2Hn7ItLPU3Js0ofchT4UxunydV7s77gbgBpIQEqwLTQ== X-Received: by 2002:a05:6808:14c:b0:3b6:c4dd:be83 with SMTP id h12-20020a056808014c00b003b6c4ddbe83mr464930oie.52.1699648751176; Fri, 10 Nov 2023 12:39:11 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id a9-20020a05680804c900b003b29c2f50f0sm43947oie.18.2023.11.10.12.39.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 12:39:10 -0800 (PST) Received: (nullmailer pid 391980 invoked by uid 1000); Fri, 10 Nov 2023 20:39:08 -0000 Date: Fri, 10 Nov 2023 14:39:08 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 03/17] dt-bindings: i2c: samsung,s3c2410-i2c: add specific compatibles for existing SoC Message-ID: <20231110203908.GA391217-robh@kernel.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-4-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231108104343.24192-4-krzysztof.kozlowski@linaro.org> Message-ID-Hash: FUVKY42AMWYD3U2R7AK53CHG3WJYOXA6 X-Message-ID-Hash: FUVKY42AMWYD3U2R7AK53CHG3WJYOXA6 X-MailFrom: robherring2@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Nov 08, 2023 at 11:43:29AM +0100, Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlowski > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../bindings/i2c/samsung,s3c2410-i2c.yaml | 22 ++++++++++++------- > 1 file changed, 14 insertions(+), 8 deletions(-) Acked-by: Rob Herring