From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2713C48297 for ; Fri, 9 Feb 2024 10:23:23 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id ADFE283B; Fri, 9 Feb 2024 11:23:11 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz ADFE283B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1707474201; bh=cs5VZ4iM5HdhEgJi2Gu/DOwpKJdiVGb7uaKztxLeeN4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=vZE1qRKQADab3A+fg1J/WBYm0HZQTdvlHAGJqiMvCR4LAl0BACPu+OJOKZSYr2ywA HdNXTu6vaJXTJgbrX4NklrIhuZdexGXHqR5FL4pjlrXJ9JG4YKMv2rKxY+UL6vg8+s sgRkTWbX6rUCcJAy8OERMyZ7m5YtSivDF4my/bH0= Received: by alsa1.perex.cz (Postfix, from userid 50401) id E9CB5F805A0; Fri, 9 Feb 2024 11:23:01 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 2ED9CF80570; Fri, 9 Feb 2024 11:23:01 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D2875F801EB; Fri, 9 Feb 2024 11:22:56 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E81A1F800E3 for ; Fri, 9 Feb 2024 11:22:50 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E81A1F800E3 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=2utyLbyR Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6D18061F95; Fri, 9 Feb 2024 10:22:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FA98C433F1; Fri, 9 Feb 2024 10:22:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1707474168; bh=cs5VZ4iM5HdhEgJi2Gu/DOwpKJdiVGb7uaKztxLeeN4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2utyLbyRIR+omAGgzPLUuILSYLG35BqhO8gkXzWOvxSl76YEuBkYa7+cDmAl6lMSt mdwN7bSRtzSCd10x9pn8vEO8VnAkR3OyrtDpDSsMCZ881TATKJh0o5dQ/ft85GYYmU YUGytVxSQMjVhXhjiu4+WcTfmT5X2mbQQUTpeI/4= Date: Fri, 9 Feb 2024 10:22:45 +0000 From: Greg KH To: Wesley Cheng Cc: srinivas.kandagatla@linaro.org, mathias.nyman@intel.com, perex@perex.cz, conor+dt@kernel.org, corbet@lwn.net, lgirdwood@gmail.com, andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, Thinh.Nguyen@synopsys.com, broonie@kernel.org, bgoswami@quicinc.com, tiwai@suse.com, robh+dt@kernel.org, konrad.dybcio@linaro.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-sound@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-doc@vger.kernel.org, alsa-devel@alsa-project.org, Mathias Nyman Subject: Re: [PATCH v14 01/53] xhci: fix possible null pointer dereference at secondary interrupter removal Message-ID: <2024020931-unelected-scribble-50f4@gregkh> References: <20240208231406.27397-1-quic_wcheng@quicinc.com> <20240208231406.27397-2-quic_wcheng@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240208231406.27397-2-quic_wcheng@quicinc.com> Message-ID-Hash: Y2424ZF75NRG2LNOKVJ4M6OIZ62FTWDK X-Message-ID-Hash: Y2424ZF75NRG2LNOKVJ4M6OIZ62FTWDK X-MailFrom: gregkh@linuxfoundation.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Feb 08, 2024 at 03:13:14PM -0800, Wesley Cheng wrote: > From: Mathias Nyman > > Don't try to remove a secondary interrupter that is known to be invalid. > Also check if the interrupter is valid inside the spinlock that protects > the array of interrupters. > > Found by smatch static checker > > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/linux-usb/ffaa0a1b-5984-4a1f-bfd3-9184630a97b9@moroto.mountain/ > Fixes: c99b38c41234 ("xhci: add support to allocate several interrupters") > Signed-off-by: Mathias Nyman > Link: https://lore.kernel.org/r/20240125152737.2983959-2-mathias.nyman@linux.intel.com > Signed-off-by: Greg Kroah-Hartman > Signed-off-by: Wesley Cheng Wait, this is already in my tree, right? Why keep sending it? confused, greg k-h