From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 865C7C48BF8 for ; Thu, 22 Feb 2024 14:17:33 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D1914844; Thu, 22 Feb 2024 15:17:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D1914844 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1708611450; bh=SZ/Zk8BWOQjTPubYMUBoHg3tSEyPhODwMelB+zqkglQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=otI6/R9pwBGo9FBJTgB6qoSHKqA0mMbB85pwvzMyAvlfKU8VGlIY56vlVrUIHr6sR 5QRLsnQ189hNtwl9kM2JFcf18ffyG1dCzO8tocWdXqYWYK8rMry30fxBpTPOsNf3xz JYLN36pdWlf6GsgbqZs6dQRzw4EmeqJcuf+pUrEc= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2CD54F805A1; Thu, 22 Feb 2024 15:16:59 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 41FCFF805A9; Thu, 22 Feb 2024 15:16:58 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6A689F80496; Thu, 22 Feb 2024 15:16:39 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3C773F8019B for ; Thu, 22 Feb 2024 15:16:28 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3C773F8019B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=swmaF298 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 735BA61876; Thu, 22 Feb 2024 14:16:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2D59C433C7; Thu, 22 Feb 2024 14:16:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708611385; bh=SZ/Zk8BWOQjTPubYMUBoHg3tSEyPhODwMelB+zqkglQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=swmaF2984HLAl0s/d0P4xSdY/AMjSYjub6C/25DGguLpnzREhpoGB6RsRh0ImwSUk U80FUff6MDpnpx6VTr5ryRBxGQ5fI3qwuoT9pTLIBiZeZb8k90PucUg93E3D5iV4s2 hPSzdmEAwq+ir2fRC4vauk+nWBdSlBvJd3dNuiEzMbuLHSKka8WQU3Scep9y92xKai Ozpdnqy8rZir9ppdzGr19FXzCoZyNPxI7pAKa/wJObtJZrn9j2w2psydtZoDKPy5M1 zyLKOIgpZ7mvXixgVcb0Xu/SkLD7n/T9aTfLdPQrfnvLNpm63sse7N/hAqWyGy2RgH ZvvWsvgM/QbRw== Date: Thu, 22 Feb 2024 07:16:22 -0700 From: Rob Herring To: Seven Lee Cc: broonie@kernel.org, lgirdwood@gmail.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, conor+dt@kernel.org, YHCHuang@nuvoton.com, KCHSU0@nuvoton.com, CTLIN0@nuvoton.com, SJLIN0@nuvoton.com, scott6986@gmail.com, supercraig0719@gmail.com, dardar923@gmail.com Subject: Re: [PATCH v2 1/2] ASoC: dt-bindings: Added schema for "nuvoton,nau8325" Message-ID: <20240222141622.GA2748112-robh@kernel.org> References: <20240222083825.190854-1-wtli@nuvoton.com> <20240222083825.190854-2-wtli@nuvoton.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240222083825.190854-2-wtli@nuvoton.com> Message-ID-Hash: BFZZ4V5V4LI7MLCSXJVZSNE2KWJ5TNVS X-Message-ID-Hash: BFZZ4V5V4LI7MLCSXJVZSNE2KWJ5TNVS X-MailFrom: robh@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Feb 22, 2024 at 04:38:24PM +0800, Seven Lee wrote: > Added a DT schema for describing nau8325 audio amplifiers. Please test your bindings before sending. > > Signed-off-by: Seven Lee > --- > .../bindings/sound/nuvoton,nau8325.yaml | 82 +++++++++++++++++++ > 1 file changed, 82 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8325.yaml > > diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8325.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8325.yaml > new file mode 100644 > index 000000000000..fc72baf0bb7a > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8325.yaml > @@ -0,0 +1,82 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nuvoton,nau8325.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NAU8325 audio Amplifier > + > +maintainers: > + - Seven Lee > + > +allOf: > + - $ref: dai-common.yaml# > + > +properties: > + compatible: > + const: nuvoton,nau8325 > + > + reg: > + maxItems: 1 > + > + nuvoton,vref-impedance: > + $ref: /schemas/types.yaml#/definitions/uint32 Use standard unit suffixes. > + description: > + VREF impedance selection. > + enum: > + - 0 # Open > + - 1 # 25kOhm > + - 2 # 125kOhm > + - 3 # 2.5kOhm > + default: 2 > + > + nuvoton,dac-vref: > + $ref: /schemas/types.yaml#/definitions/uint32 Use standard unit suffixes. > + description: > + DAC Reference Voltage Setting. > + enum: > + - VDDA in Volts? > + - VDDA*1.5/1.8V Volts/Volts So 2 different units? > + - VDDA*1.6/1.8V > + - VDDA*1.7/1.8V > + default: 2 > + > + nuvoton,alc-enable: > + description: > + Enable digital automatic level control (ALC) function. > + type: boolean > + > + nuvoton,clock-detection-disable: > + description: > + When clock detection is enabled, it will detect whether MCLK > + and FS are within the range. MCLK range is from 2.048MHz to 24.576MHz. > + FS range is from 8kHz to 96kHz. > + type: boolean > + > + nuvoton,clock-det-data: > + description: > + Request clock detection to require 2048 non-zero samples before enabling > + the audio paths. If set then non-zero samples is required, otherwise it > + doesn't matter. > + type: boolean > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + codec@21 { > + compatible = "nuvoton,nau8325"; > + reg = <0x21>; > + nuvoton,vref-impedance = <2>; > + nuvoton,dac-vref = <2>; > + nuvoton,alc-enable; > + nuvoton,clock-det-data; > + }; > + }; > -- > 2.25.1 >