From: kernel test robot <lkp@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: oe-kbuild-all@lists.linux.dev, alsa-devel@alsa-project.org
Subject: [tiwai-sound:test/guard 50/70] sound/core/rawmidi.c:1012:6: error: cannot jump from this asm goto statement to one of its possible targets
Date: Sun, 25 Feb 2024 20:06:24 +0800 [thread overview]
Message-ID: <202402251935.CGUH0Id9-lkp@intel.com> (raw)
Hi Takashi,
FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/guard
head: 0ba3f403c3b7fdd2683aac6285903f92ba81c32d
commit: 369c285f8405ec663691db39ec59a01c70f80ded [50/70] ALSA: rawmidi: Use guard() for locking
config: powerpc-randconfig-r081-20240225 (https://download.01.org/0day-ci/archive/20240225/202402251935.CGUH0Id9-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240225/202402251935.CGUH0Id9-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402251935.CGUH0Id9-lkp@intel.com/
All errors (new ones prefixed by >>):
>> sound/core/rawmidi.c:1012:6: error: cannot jump from this asm goto statement to one of its possible targets
if (put_user(device, argp))
^
arch/powerpc/include/asm/uaccess.h:66:5: note: expanded from macro 'put_user'
__put_user(x, _pu_addr) : -EFAULT; \
^
arch/powerpc/include/asm/uaccess.h:48:3: note: expanded from macro '__put_user'
__put_user_size_goto(__pu_val, __pu_addr, __pu_size, __pu_failed); \
^
arch/powerpc/include/asm/uaccess.h:116:10: note: expanded from macro '__put_user_size_goto'
case 1: __put_user_asm_goto(x, __pus_addr, label, "stb"); break; \
^
arch/powerpc/include/asm/uaccess.h:86:2: note: expanded from macro '__put_user_asm_goto'
asm_volatile_goto( \
^
include/linux/compiler_types.h:366:33: note: expanded from macro 'asm_volatile_goto'
#define asm_volatile_goto(x...) asm goto(x)
^
sound/core/rawmidi.c:996:6: note: possible target of asm goto statement
if (get_user(device, argp))
^
arch/powerpc/include/asm/uaccess.h:295:5: note: expanded from macro 'get_user'
__get_user(x, _gu_addr) : \
^
arch/powerpc/include/asm/uaccess.h:283:2: note: expanded from macro '__get_user'
__get_user_size_allowed(__gu_val, __gu_addr, __gu_size, __gu_err); \
^
arch/powerpc/include/asm/uaccess.h:201:16: note: expanded from macro '__get_user_size_allowed'
break; \
^
sound/core/rawmidi.c:1000:2: note: jump exits scope of variable with __attribute__((cleanup))
guard(mutex)(®ister_mutex);
^
include/linux/cleanup.h:164:15: note: expanded from macro 'guard'
CLASS(_name, __UNIQUE_ID(guard))
^
include/linux/compiler.h:180:29: note: expanded from macro '__UNIQUE_ID'
#define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
^
include/linux/compiler_types.h:84:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:83:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:5:1: note: expanded from here
__UNIQUE_ID_guard309
^
sound/core/rawmidi.c:996:6: error: cannot jump from this asm goto statement to one of its possible targets
if (get_user(device, argp))
^
arch/powerpc/include/asm/uaccess.h:295:5: note: expanded from macro 'get_user'
__get_user(x, _gu_addr) : \
^
arch/powerpc/include/asm/uaccess.h:283:2: note: expanded from macro '__get_user'
__get_user_size_allowed(__gu_val, __gu_addr, __gu_size, __gu_err); \
^
arch/powerpc/include/asm/uaccess.h:199:3: note: expanded from macro '__get_user_size_allowed'
__get_user_size_goto(x, ptr, size, __gus_failed); \
^
arch/powerpc/include/asm/uaccess.h:187:10: note: expanded from macro '__get_user_size_goto'
case 1: __get_user_asm_goto(x, (u8 __user *)ptr, label, "lbz"); break; \
^
arch/powerpc/include/asm/uaccess.h:158:2: note: expanded from macro '__get_user_asm_goto'
asm_volatile_goto( \
^
include/linux/compiler_types.h:366:33: note: expanded from macro 'asm_volatile_goto'
#define asm_volatile_goto(x...) asm goto(x)
^
sound/core/rawmidi.c:1012:6: note: possible target of asm goto statement
if (put_user(device, argp))
^
arch/powerpc/include/asm/uaccess.h:66:5: note: expanded from macro 'put_user'
__put_user(x, _pu_addr) : -EFAULT; \
^
arch/powerpc/include/asm/uaccess.h:52:9: note: expanded from macro '__put_user'
\
^
sound/core/rawmidi.c:1000:2: note: jump bypasses initialization of variable with __attribute__((cleanup))
guard(mutex)(®ister_mutex);
^
include/linux/cleanup.h:164:15: note: expanded from macro 'guard'
CLASS(_name, __UNIQUE_ID(guard))
^
include/linux/compiler.h:180:29: note: expanded from macro '__UNIQUE_ID'
#define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
^
include/linux/compiler_types.h:84:22: note: expanded from macro '__PASTE'
#define __PASTE(a,b) ___PASTE(a,b)
^
include/linux/compiler_types.h:83:23: note: expanded from macro '___PASTE'
#define ___PASTE(a,b) a##b
^
<scratch space>:5:1: note: expanded from here
__UNIQUE_ID_guard309
^
2 errors generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97
Depends on [n]: SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC52xx [=y] && PPC_BESTCOMM [=n]
Selected by [m]:
- SND_MPC52xx_SOC_EFIKA [=m] && SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_EFIKA [=y]
WARNING: unmet direct dependencies detected for ADB_CUDA
Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n]
Selected by [y]:
- PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y]
vim +1012 sound/core/rawmidi.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 986
127ae6f6dad2ed Takashi Iwai 2023-05-23 987 /* ioctl to find the next device; either legacy or UMP depending on @find_ump */
127ae6f6dad2ed Takashi Iwai 2023-05-23 988 static int snd_rawmidi_next_device(struct snd_card *card, int __user *argp,
127ae6f6dad2ed Takashi Iwai 2023-05-23 989 bool find_ump)
^1da177e4c3f41 Linus Torvalds 2005-04-16 990
^1da177e4c3f41 Linus Torvalds 2005-04-16 991 {
127ae6f6dad2ed Takashi Iwai 2023-05-23 992 struct snd_rawmidi *rmidi;
^1da177e4c3f41 Linus Torvalds 2005-04-16 993 int device;
127ae6f6dad2ed Takashi Iwai 2023-05-23 994 bool is_ump;
^1da177e4c3f41 Linus Torvalds 2005-04-16 995
127ae6f6dad2ed Takashi Iwai 2023-05-23 996 if (get_user(device, argp))
^1da177e4c3f41 Linus Torvalds 2005-04-16 997 return -EFAULT;
a7a13d0676335a Dan Carpenter 2010-09-09 998 if (device >= SNDRV_RAWMIDI_DEVICES) /* next device is -1 */
a7a13d0676335a Dan Carpenter 2010-09-09 999 device = SNDRV_RAWMIDI_DEVICES - 1;
369c285f8405ec Takashi Iwai 2024-02-21 1000 guard(mutex)(®ister_mutex);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1001 device = device < 0 ? 0 : device + 1;
127ae6f6dad2ed Takashi Iwai 2023-05-23 1002 for (; device < SNDRV_RAWMIDI_DEVICES; device++) {
127ae6f6dad2ed Takashi Iwai 2023-05-23 1003 rmidi = snd_rawmidi_search(card, device);
127ae6f6dad2ed Takashi Iwai 2023-05-23 1004 if (!rmidi)
127ae6f6dad2ed Takashi Iwai 2023-05-23 1005 continue;
127ae6f6dad2ed Takashi Iwai 2023-05-23 1006 is_ump = rawmidi_is_ump(rmidi);
127ae6f6dad2ed Takashi Iwai 2023-05-23 1007 if (find_ump == is_ump)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1008 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1009 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1010 if (device == SNDRV_RAWMIDI_DEVICES)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1011 device = -1;
127ae6f6dad2ed Takashi Iwai 2023-05-23 @1012 if (put_user(device, argp))
^1da177e4c3f41 Linus Torvalds 2005-04-16 1013 return -EFAULT;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1014 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1015 }
127ae6f6dad2ed Takashi Iwai 2023-05-23 1016
:::::: The code at line 1012 was first introduced by commit
:::::: 127ae6f6dad2edb2201e27b7e6fa72994b537fad ALSA: rawmidi: Skip UMP devices at SNDRV_CTL_IOCTL_RAWMIDI_NEXT_DEVICE
:::::: TO: Takashi Iwai <tiwai@suse.de>
:::::: CC: Takashi Iwai <tiwai@suse.de>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-02-25 12:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202402251935.CGUH0Id9-lkp@intel.com \
--to=lkp@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox