Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: alsa-devel@alsa-project.org
Cc: Manuel Lauss <manuel.lauss@gmail.com>, Mark Brown <broonie@kernel.org>
Subject: [PATCH v2] ASoC: au1x: declare that FIFO is reported in frames
Date: Mon,  1 Apr 2024 22:11:51 +0200	[thread overview]
Message-ID: <20240401201151.560355-1-oswald.buddenhagen@gmx.de> (raw)

Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
---

Is this right? The comment on the field says "fifo entries of AC97/I2S
PSC", which doesn't suggest bytes. The data sheet speaks of "words" and
"byte masks", but without digging into it I can't tell how it would
behave with different sample widths and channel counts (which the driver
does not seem to limit _at all_? what am I missing?).

This is just something I stumbled over while surveying how different
drivers set the field. If this is actually a bug, it is minor.
---
 sound/soc/au1x/dbdma2.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/au1x/dbdma2.c b/sound/soc/au1x/dbdma2.c
index ea01d6490cec..2c8c01a5fb8f 100644
--- a/sound/soc/au1x/dbdma2.c
+++ b/sound/soc/au1x/dbdma2.c
@@ -66,7 +66,8 @@ struct au1xpsc_audio_dmadata {
 /* PCM hardware DMA capabilities - platform specific */
 static const struct snd_pcm_hardware au1xpsc_pcm_hardware = {
 	.info		  = SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID |
-			    SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BATCH,
+			    SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BATCH |
+			    SNDRV_PCM_INFO_FIFO_IN_FRAMES,
 	.period_bytes_min = AU1XPSC_PERIOD_MIN_BYTES,
 	.period_bytes_max = 4096 * 1024 - 1,
 	.periods_min	  = 2,
--
2.42.0.419.g70bf8a5751


             reply	other threads:[~2024-04-01 20:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-01 20:11 Oswald Buddenhagen [this message]
2024-04-05 11:22 ` [PATCH v2] ASoC: au1x: declare that FIFO is reported in frames Manuel Lauss
2024-04-05 13:16   ` Oswald Buddenhagen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240401201151.560355-1-oswald.buddenhagen@gmx.de \
    --to=oswald.buddenhagen@gmx.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=manuel.lauss@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox