From: Herve Codina <herve.codina@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Support Opensource <support.opensource@diasemi.com>,
Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
Baojun Xu <baojun.xu@ti.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] ASoC: Constify DAI ops auto_selectable_formats
Date: Mon, 17 Jun 2024 13:24:36 +0200 [thread overview]
Message-ID: <20240617132436.640e5310@bootlin.com> (raw)
In-Reply-To: <20240617092152.244981-2-krzysztof.kozlowski@linaro.org>
Hi Krzysztof,
On Mon, 17 Jun 2024 11:21:52 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> The static arrays passed as 'auto_selectable_formats' are not modified
> by the drivers nor by the core code, so make it const for code safety.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> sound/soc/codecs/ak4613.c | 2 +-
> sound/soc/codecs/da7213.c | 2 +-
> sound/soc/codecs/hdmi-codec.c | 2 +-
> sound/soc/codecs/idt821034.c | 2 +-
> sound/soc/codecs/pcm3168a.c | 2 +-
> sound/soc/codecs/peb2466.c | 2 +-
> sound/soc/generic/test-component.c | 2 +-
> sound/soc/sh/fsi.c | 2 +-
> sound/soc/sh/rcar/core.c | 2 +-
> sound/soc/soc-utils.c | 2 +-
> 10 files changed, 10 insertions(+), 10 deletions(-)
>
I think you miss sound/soc/codecs/framer-codec.c
Best regards,
Hervé
next prev parent reply other threads:[~2024-06-17 11:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 9:21 [PATCH 1/2] ASoC: soc-dai.h: Constify DAI ops auto_selectable_formats Krzysztof Kozlowski
2024-06-17 9:21 ` [PATCH 2/2] ASoC: " Krzysztof Kozlowski
2024-06-17 11:24 ` Herve Codina [this message]
2024-06-17 12:26 ` Krzysztof Kozlowski
2024-06-17 11:24 ` [PATCH 1/2] ASoC: soc-dai.h: " Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240617132436.640e5310@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=kevin-lu@ti.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shenghao-ding@ti.com \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox