Re: [Patch v4 04/10] ARM: dts: lpc32xx: Add missing dma and i2s properties

Krzysztof Kozlowski
2024-06-21T06:21:31Z

On 20/06/2024 19:56, Piotr Wojtaszczyk wrote:
> Adds properties declared in the new DT bindings:
> - nxp,lpc3220-i2s.yaml
> - nxp,lpc3220-dmamux.yaml
> for dma router/mux and I2S interface.
>
> Signed-off-by: Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>

You are doing here multiple things at once. This should be

One patch is dma properties.

>
> i2s0: i2s@20094000 {
> compatible = "nxp,lpc3220-i2s";
> reg = <0x20094000 0x1000>;
> + interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clk LPC32XX_CLK_I2S0>;
> + dmas = <&dma 0 1>, <&dma 13 1>;
> + dma-names = "rx", "tx";
> + #sound-dai-cells = <0>;

Sound dai cells is another patch (or entire node is separate patch).

> status = "disabled";
> };
>
> @@ -231,12 +255,19 @@ sd: sd@20098000 {
> <13 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clk LPC32XX_CLK_SD>;
> clock-names = "apb_pclk";
> + dmas = <&dma 4 1>;
> + dma-names = "rx";
> status = "disabled";
> };
>
> i2s1: i2s@2009c000 {
> compatible = "nxp,lpc3220-i2s";
> reg = <0x2009c000 0x1000>;
> + interrupts = <23 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clk LPC32XX_CLK_I2S1>;
> + dmas = <&dma 2 1>, <&dmamux 10 1 1>;
> + dma-names = "rx", "tx";
> + #sound-dai-cells = <0>;
> status = "disabled";
> };
>
> @@ -312,21 +343,27 @@ fab {
> compatible = "simple-bus";
> ranges = <0x20000000 0x20000000 0x30000000>;
>
> - /* System Control Block */
> - scb {
> - compatible = "simple-bus";
> - ranges = <0x0 0x40004000 0x00001000>;
> + syscon@40004000 {
> + compatible = "nxp,lpc3220-creg", "syscon", "simple-mfd";
> + reg = <0x40004000 0x114>;

This hunk is also separate patch.

Best regards,
Krzysztof