Re: [Patch v4 05/10] clk: lpc32xx: initialize regmap using parent syscon

Krzysztof Kozlowski
2024-06-21T06:22:23Z

On 20/06/2024 19:56, Piotr Wojtaszczyk wrote:
>
> - base = of_iomap(np, 0);
> - if (!base) {
> - pr_err("failed to map system control block registers\n");
> - return;
> - }
> -
> - clk_regmap = regmap_init_mmio(NULL, base, &lpc32xx_scb_regmap_config);
> + clk_regmap = syscon_node_to_regmap(np->parent);
> if (IS_ERR(clk_regmap)) {
> pr_err("failed to regmap system control block: %ld\n",
> PTR_ERR(clk_regmap));
> - iounmap(base);

This looks backwards incompatible. You should keep the fallback way.

Best regards,
Krzysztof